https-client - npm Package Compare versions

Comparing version 1.4.3 to 1.4.4

package.json

 {
   "name": "https-client",
-  "version": "1.4.3",
+  "version": "1.4.4",
   "description": "Simple REST client for `node.js` `https` module. Adds retries and timeout support to `https` module.",
@@ -5,0 +5,0 @@ "author": "Will Tesler",

src/client/HttpsClient.js

@@ -182,73 +182,80 @@ module.exports = class HttpsClient {
       const responsePromise = new Promise(resolve => {
-        const req = httpLib.request(requestOptions, res => {
-          const data = [];
+        try {
+          const req = httpLib.request(requestOptions, res => {
+            const data = [];
 
-          const statusCode = res.statusCode;
+            const statusCode = res.statusCode;
 
-          res.on('error', e => {
-            cancelResponseTimeout();
-            e.statusCode = statusCode;
-            logWarning(e);
-            resolve(e); // Network Error
-          });
-          res.on('data', chunk => {
-            cancelResponseTimeout();
-            if (onChunk) {
-              try {
-                onChunk(chunk);
-              } catch (e) {
-                logWarning(e);
-                resolve(e);
+            res.on('error', e => {
+              cancelResponseTimeout();
+              e.statusCode = statusCode;
+              logWarning(e);
+              resolve(e); // Network Error
+            });
+            res.on('data', chunk => {
+              cancelResponseTimeout();
+              if (onChunk) {
+                try {
+                  onChunk(chunk);
+                } catch (e) {
+                  logWarning(e);
+                  resolve(e);
+                }
+              } else {
+                data.push(chunk);
               }
-            } else {
-              data.push(chunk);
-            }
-          });
-          res.on('end', () => {
-            if (didTimeout) {
-              resolve();
-              return;
-            }
+            });
+            res.on('end', () => {
+              if (didTimeout) {
+                resolve();
+                return;
+              }
 
-            cancelResponseTimeout();
-            clearTimeout(deadlineTimeout);
+              cancelResponseTimeout();
+              clearTimeout(deadlineTimeout);
 
-            const responseStr = buffer.concat(data).toString();
-            let response;
-            if (headers['Accept'] === 'application/json') {
-              try {
-                response = JSON.parse(responseStr);
-                if (!response.statusCode) {
-                  response.statusCode = statusCode;
+              const responseStr = buffer.concat(data).toString();
+              let response;
+              if (headers['Accept'] === 'application/json') {
+                try {
+                  response = JSON.parse(responseStr);
+                  if (!response.statusCode) {
+                    response.statusCode = statusCode;
+                  }
+                } catch (e) {
+                  // Everything is fine.
                 }
-              } catch (e) {
-                // Everything is fine.
               }
-            }
 
-            if (!response) {
-              response = {
-                data: responseStr,
-                statusCode: statusCode
-              };
-            }
+              if (!response) {
+                response = {
+                  data: responseStr,
+                  statusCode: statusCode
+                };
+              }
 
-            if (statusCode >= 400) {
-              logWarning(response);
-              let responseStr = response;
-              const serverError = new Error(`Received not OK status code with call to ${host}${path}`);
-              serverError.statusCode = statusCode;
-              if (typeof response === 'string') {
-                serverError.message = `Received ${statusCode} code. Response treated as rejection. Full response: ${responseStr}`;
+              if (statusCode >= 400) {
+                logWarning(response);
+                let responseStr = response;
+                const serverError = new Error(`Received not OK status code with call to ${host}${path}`);
+                serverError.statusCode = statusCode;
+                if (typeof response === 'string') {
+                  serverError.message = `Received ${statusCode} code. Response treated as rejection. Full response: ${responseStr}`;
+                } else {
+                  Object.assign(serverError, response);
+                }
+                resolve(serverError);
               } else {
-                Object.assign(serverError, response);
+                // Success
+                didSucceed = true;
+                resolve(response);
               }
-              resolve(serverError);
-            } else {
-              // Success
-              didSucceed = true;
-              resolve(response);
-            }
+            });
           });
-        });
+        } catch (e) {
+          cancelResponseTimeout();
+          e.statusCode = e.code;
+          logWarning(e);
+          resolve(e); // Network Error
+        }
 
@@ -255,0 +262,0 @@ if (abortSignal) {

New alerts

Network access

Supply chain risk

This module accesses the network.

Found 2 instances in 1 package

Environment variable access

Supply chain risk

Package accesses environment variables, which may be a sign of credential stuffing or data theft.

Found 1 instance in 1 package

Fixed alerts

Network access

Supply chain risk

This module accesses the network.

Found 2 instances in 1 package

Environment variable access

Supply chain risk

Package accesses environment variables, which may be a sign of credential stuffing or data theft.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

12362

2.61%

Lines of code

267

2.69%

No dependency changes