ibankit - npm Package Compare versions

Comparing version 1.1.1 to 1.1.2

lib/bbanStructure.d.ts

@@ -12,2 +12,3 @@ import { BbanStructurePart, PartType } from "./structurePart";
     extractValue(bban: string, partType: PartType): string | null;
+    extractValueMust(bban: string, partType: PartType): string;
     static forCountry(countryCode: CountryCode | string | undefined): BbanStructure | null;
@@ -14,0 +15,0 @@ static getEntries(): BbanStructure[];

lib/exceptions.d.ts

@@ -40,1 +40,3 @@ export declare enum FormatViolation {
 }
+export declare class RequiredPartTypeMissing extends Error {
+}

lib/exceptions.js

@@ -52,2 +52,5 @@ "use strict";
 exports.InvalidCheckDigitException = InvalidCheckDigitException;
-//# sourceMappingURL=data:application/json;base64,eyJ2ZXJzaW9uIjozLCJmaWxlIjoiZXhjZXB0aW9ucy5qcyIsInNvdXJjZVJvb3QiOiIiLCJzb3VyY2VzIjpbIi4uL3NyYy9leGNlcHRpb25zLnRzIl0sIm5hbWVzIjpbXSwibWFwcGluZ3MiOiI7O0FBQUEsSUFBWSxlQWdDWDtBQWhDRCxXQUFZLGVBQWU7SUFDekIsMkRBQU8sQ0FBQTtJQUVQLDZEQUFRLENBQUE7SUFDUiwrREFBUyxDQUFBO0lBQ1QsaUZBQWtCLENBQUE7SUFDbEIsbUdBQTJCLENBQUE7SUFHM0IsaUhBQWtDLENBQUE7SUFDbEMscUhBQW9DLENBQUE7SUFDcEMseUZBQXNCLENBQUE7SUFFdEIsNkZBQXdCLENBQUE7SUFDeEIscUhBQW9DLENBQUE7SUFDcEMsb0ZBQW1CLENBQUE7SUFFbkIsc0ZBQW9CLENBQUE7SUFHcEIsMEZBQXNCLENBQUE7SUFDdEIsNEZBQXVCLENBQUE7SUFDdkIsb0VBQVcsQ0FBQTtJQUNYLHNHQUE0QixDQUFBO0lBQzVCLG9HQUEyQixDQUFBO0lBQzNCLDhFQUFnQixDQUFBO0lBQ2hCLHdGQUFxQixDQUFBO0lBR3JCLHdGQUFxQixDQUFBO0lBQ3JCLGtGQUFrQixDQUFBO0lBQ2xCLDRGQUF1QixDQUFBO0FBQ3pCLENBQUMsRUFoQ1csZUFBZSxHQUFmLHVCQUFlLEtBQWYsdUJBQWUsUUFnQzFCO0FBRUQsTUFBYSxlQUFnQixTQUFRLEtBQUs7SUFLeEMsWUFDRSxlQUFnQyxFQUNoQyxHQUFXLEVBQ1gsUUFBaUIsRUFDakIsTUFBZTtRQUVmLEtBQUssQ0FBQyxHQUFHLENBQUMsQ0FBQztRQUVYLElBQUksQ0FBQyxlQUFlLEdBQUcsZUFBZSxDQUFDO1FBQ3ZDLElBQUksQ0FBQyxRQUFRLEdBQUcsUUFBUSxDQUFDO1FBQ3pCLElBQUksQ0FBQyxNQUFNLEdBQUcsTUFBTSxDQUFDO0lBQ3ZCLENBQUM7Q0FDRjtBQWpCRCwwQ0FpQkM7QUFFRCxNQUFhLDJCQUE0QixTQUFRLEtBQUs7SUFHcEQsWUFBWSxHQUFXLEVBQUUsTUFBZTtRQUN0QyxLQUFLLENBQUMsR0FBRyxDQUFDLENBQUM7UUFDWCxJQUFJLENBQUMsTUFBTSxHQUFHLE1BQU0sQ0FBQztJQUN2QixDQUFDO0NBQ0Y7QUFQRCxrRUFPQztBQUVELE1BQWEsMEJBQTJCLFNBQVEsS0FBSztJQUluRCxZQUFZLEdBQVcsRUFBRSxRQUFpQixFQUFFLE1BQWU7UUFDekQsS0FBSyxDQUFDLEdBQUcsQ0FBQyxDQUFDO1FBRVgsSUFBSSxDQUFDLFFBQVEsR0FBRyxRQUFRLENBQUM7UUFDekIsSUFBSSxDQUFDLE1BQU0sR0FBRyxNQUFNLENBQUM7SUFDdkIsQ0FBQztDQUNGO0FBVkQsZ0VBVUMifQ==
+class RequiredPartTypeMissing extends Error {
+}
+exports.RequiredPartTypeMissing = RequiredPartTypeMissing;
+//# sourceMappingURL=data:application/json;base64,eyJ2ZXJzaW9uIjozLCJmaWxlIjoiZXhjZXB0aW9ucy5qcyIsInNvdXJjZVJvb3QiOiIiLCJzb3VyY2VzIjpbIi4uL3NyYy9leGNlcHRpb25zLnRzIl0sIm5hbWVzIjpbXSwibWFwcGluZ3MiOiI7O0FBQUEsSUFBWSxlQWdDWDtBQWhDRCxXQUFZLGVBQWU7SUFDekIsMkRBQU8sQ0FBQTtJQUVQLDZEQUFRLENBQUE7SUFDUiwrREFBUyxDQUFBO0lBQ1QsaUZBQWtCLENBQUE7SUFDbEIsbUdBQTJCLENBQUE7SUFHM0IsaUhBQWtDLENBQUE7SUFDbEMscUhBQW9DLENBQUE7SUFDcEMseUZBQXNCLENBQUE7SUFFdEIsNkZBQXdCLENBQUE7SUFDeEIscUhBQW9DLENBQUE7SUFDcEMsb0ZBQW1CLENBQUE7SUFFbkIsc0ZBQW9CLENBQUE7SUFHcEIsMEZBQXNCLENBQUE7SUFDdEIsNEZBQXVCLENBQUE7SUFDdkIsb0VBQVcsQ0FBQTtJQUNYLHNHQUE0QixDQUFBO0lBQzVCLG9HQUEyQixDQUFBO0lBQzNCLDhFQUFnQixDQUFBO0lBQ2hCLHdGQUFxQixDQUFBO0lBR3JCLHdGQUFxQixDQUFBO0lBQ3JCLGtGQUFrQixDQUFBO0lBQ2xCLDRGQUF1QixDQUFBO0FBQ3pCLENBQUMsRUFoQ1csZUFBZSxHQUFmLHVCQUFlLEtBQWYsdUJBQWUsUUFnQzFCO0FBRUQsTUFBYSxlQUFnQixTQUFRLEtBQUs7SUFLeEMsWUFDRSxlQUFnQyxFQUNoQyxHQUFXLEVBQ1gsUUFBaUIsRUFDakIsTUFBZTtRQUVmLEtBQUssQ0FBQyxHQUFHLENBQUMsQ0FBQztRQUVYLElBQUksQ0FBQyxlQUFlLEdBQUcsZUFBZSxDQUFDO1FBQ3ZDLElBQUksQ0FBQyxRQUFRLEdBQUcsUUFBUSxDQUFDO1FBQ3pCLElBQUksQ0FBQyxNQUFNLEdBQUcsTUFBTSxDQUFDO0lBQ3ZCLENBQUM7Q0FDRjtBQWpCRCwwQ0FpQkM7QUFFRCxNQUFhLDJCQUE0QixTQUFRLEtBQUs7SUFHcEQsWUFBWSxHQUFXLEVBQUUsTUFBZTtRQUN0QyxLQUFLLENBQUMsR0FBRyxDQUFDLENBQUM7UUFDWCxJQUFJLENBQUMsTUFBTSxHQUFHLE1BQU0sQ0FBQztJQUN2QixDQUFDO0NBQ0Y7QUFQRCxrRUFPQztBQUVELE1BQWEsMEJBQTJCLFNBQVEsS0FBSztJQUluRCxZQUFZLEdBQVcsRUFBRSxRQUFpQixFQUFFLE1BQWU7UUFDekQsS0FBSyxDQUFDLEdBQUcsQ0FBQyxDQUFDO1FBRVgsSUFBSSxDQUFDLFFBQVEsR0FBRyxRQUFRLENBQUM7UUFDekIsSUFBSSxDQUFDLE1BQU0sR0FBRyxNQUFNLENBQUM7SUFDdkIsQ0FBQztDQUNGO0FBVkQsZ0VBVUM7QUFFRCxNQUFhLHVCQUF3QixTQUFRLEtBQUs7Q0FBRztBQUFyRCwwREFBcUQifQ==

package.json

 {
   "name": "ibankit",
-  "version": "1.1.1",
+  "version": "1.1.2",
   "description": "IBAN and BIC utilities",
@@ -5,0 +5,0 @@ "main": "lib/index.js",

src/bbanStructure.ts

 import { CharacterType, BbanStructurePart, PartType } from "./structurePart";
 import { CountryCode } from "./country";
-import { FormatException, FormatViolation } from "./exceptions";
+import {
+  FormatException,
+  FormatViolation,
+  RequiredPartTypeMissing,
+} from "./exceptions";
 
@@ -10,26 +14,11 @@ /**
   return (
-    11 -
-    (value
-      .split("")
-      .reverse()
-      .reduce((acc, s, idx) => acc + parseInt(s, 10) * weights[idx], 0) %
-      11)
+    (11 -
+      (value
+        .split("")
+        .reduce((acc, s, idx) => acc + parseInt(s, 10) * weights[idx], 0) %
+        11)) %
+    11
   );
 }
 
-/*
- ** Return a function that is a MOD11 national check digit checker
- */
-function nationalFactory(weights: number[]) {
-  return (bban: string, structure: BbanStructure) => {
-    const accountNumber = structure.extractValue(bban, PartType.ACCOUNT_NUMBER);
-
-    if (accountNumber === null) {
-      throw new FormatException(FormatViolation.NOT_EMPTY, "account number");
-    }
-
-    return String(mod11(accountNumber, weights));
-  };
-}
-
 /**
@@ -529,3 +518,9 @@ * Class which represents bban structure
         CharacterType.n,
-        nationalFactory([5, 4, 3, 2, 7, 6, 5, 4, 3, 2]),
+        (bban: string, structure: BbanStructure) => {
+          const value = [PartType.BANK_CODE, PartType.ACCOUNT_NUMBER]
+            .map(p => structure.extractValueMust(bban, p))
+            .join("");
+
+          return String(mod11(value, [5, 4, 3, 2, 7, 6, 5, 4, 3, 2]));
+        },
       ),
@@ -715,2 +710,17 @@ ),
   /**
+   * Return part type or fail
+   */
+  extractValueMust(bban: string, partType: PartType): string {
+    const value = this.extractValue(bban, partType);
+
+    if (value === null) {
+      throw new RequiredPartTypeMissing(
+        `Required part type [${partType}] missing`,
+      );
+    }
+
+    return value;
+  }
+
+  /**
    * @param countryCode the country code.
@@ -717,0 +727,0 @@ * @return BbanStructure for specified country or null if country is not supported.

src/exceptions.ts

@@ -74,1 +74,3 @@ export enum FormatViolation {
 }
+
+export class RequiredPartTypeMissing extends Error {}

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

264773

increased by0.31%

Lines of code

4430

increased by0.43%

No dependency changes