ical - npm Package Compare versions

Comparing version 0.0.6 to 0.1.0

node-ical.js

@@ -11,3 +11,3 @@ var ical = require('./ical')
     if (err)
-    throw err;
+      return cb(err, null);
     cb(undefined, ical.parseICS(data));
@@ -20,1 +20,9 @@ })
 }
+
+
+var rrule = require('rrule').RRule
+
+ical.objectHandlers['RRULE'] = function(val, params, curr, par, line){
+  curr['rrule'] = rrule.fromString(line.replace("RRULE:", ""));
+  return curr
+}

package.json

 {"name": "ical",
- "version": "0.0.6",
+ "version": "0.1.0",
  "main": "index.js"
  ,"description": "A tolerant, minimal icalendar parser"
  , "keywords": ["ical", "ics", "calendar"]
- , "homepage": "https://github.com/peterbraden/node-ical"
+ , "homepage": "https://github.com/peterbraden/ical.js"
  , "author": "Peter Braden <[e-mail]> (peterbraden.co.uk)"
- , "repository": {"type" : "git", "url" : "git://github.com/peterbraden/node-ical.git"}
+ , "repository": {"type" : "git", "url" : "git://github.com/peterbraden/ical.js.git"}
  , "dependencies": {
  	"request": ""
+  ,	"rrule": "1.0.1"
  }
  , "devDependencies": {
- 	  "vows" : "0.6.1"
+ 	  "vows" : "0.7.0"
 	, "underscore": "1.3.0"
@@ -15,0 +16,0 @@ }

readme.md

@@ -32,4 +32,5 @@ # ical.js #
 ## Example 1 - Print list of upcoming node conferences (see example.js)
-
+```javascript
     var ical = require('ical')
+  , months = ['Jan', 'Feb', 'Mar', 'Apr', 'May', 'Jun', 'Jul', 'Aug', 'Sep', 'Oct', 'Nov', 'Dec']
 
@@ -48,4 +49,2 @@ ical.fromURL('http://lanyrd.com/topics/nodejs/nodejs.ics', {}, function(err, data) {
     });
-
-
-
+```

test/test.js

@@ -179,3 +179,24 @@ /****
     }   
+  , 'event with rrule' :{
+      topic: function(events){
+        return _.select(_.values(events), function(x){
+          return x.summary == "foobarTV broadcast starts"
+        })[0];
+      }
+      , "Has an RRULE": function(topic){
+        assert.notEqual(topic.rrule, undefined);
+      }
+      , "RRule text": function(topic){
+        assert.equal(topic.rrule.toText(), "every 5 weeks on Monday, Friday until January 30, 2013")
+      }
+    }
   }
+  , 'url request errors' : {
+    topic : function () {
+      ical.fromURL('http://not.exist/', {}, this.callback);
+    }
+    , 'are passed back to the callback' : function (err, result) {
+      assert.instanceOf(err, Error);
+    }
+  }
 }).export(module)
@@ -182,0 +203,0 @@

Fixed alerts

No website

Quality

Package does not have a website.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

167836

78.93%

Number of package files

26

85.71%

Lines of code

375

7.45%

Number of low quality alerts

1

-50%

Worsened metrics

Dependency count

2

100%

Number of lines in readme file

49

-2%

Dependency changes

• + Added

  rrule@1.0.1

• + Added

  rrule@1.0.1
  (transitive)

• + Added

  underscore@1.13.7
  (transitive)