isbinaryfile - npm Package Compare versions

Comparing version 2.0.2 to 2.0.3

index.js

@@ -8,5 +8,8 @@ var fs = require('fs');
   if (size === undefined) {
-    var file = bytes, existsSync = fs.existsSync || path.existsSync;
-    if (!existsSync(file))
-       return false;
+    var file = bytes;
+    try {
+      if(!fs.statSync(file).isFile()) return false;
+    } catch (err) {
+      // otherwise continue on
+    }
     var descriptor = fs.openSync(file, 'r');
@@ -23,5 +26,4 @@ try {
     var file = bytes, callback = size;
-    var exists = fs.exists || path.exists;
-    exists(file, function (exists) {
-      if (!exists) return callback(null, false);
+    fs.stat(file, function(err, stat) {
+      if (err || !stat.isFile()) return callback(null, false);
 
@@ -28,0 +30,0 @@ fs.open(file, 'r', function(err, descriptor){

package.json

 {
     "name": "isbinaryfile",
-    "version"         : "2.0.2",
+    "version"         : "2.0.3",
     "description": "Detects if a file is binary in Node.js. Similar to Perl's -B.",
@@ -5,0 +5,0 @@ "main"       : "./lib/panino.js",

tests/test.js

@@ -64,2 +64,14 @@ "mocha";
 
+  it('should fail a directory', function() {
+    assert(!isBinaryFile("tests/fixtures/08_dir"));
+  });
+
+  it('should fail a directory with async', function(done) {
+    isBinaryFile("tests/fixtures/08_dir", function(err, result) {
+      assert(!err);
+      assert(!result);
+      done();
+    });
+  });
+
   it('should not fail with async', function(done) {
@@ -66,0 +78,0 @@ assert.doesNotThrow(function() {

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

84186

increased by0.36%

Number of package files

15

increased by7.14%

Lines of code

151

increased by8.63%

No dependency changes