jasmine-reporters - npm Package Compare versions

Comparing version 0.4.0 to 0.4.1

package.json

@@ -5,3 +5,3 @@ {
   "description": "Reporters for the Jasmine BDD Framework",
-  "version": "0.4.0",
+  "version": "0.4.1",
   "homepage": "https://github.com/larrymyers/jasmine-reporters",
@@ -8,0 +8,0 @@ "maintainers": "Ben Loveridge <[e-mail]>",

src/jasmine.nunit_reporter.js

@@ -58,2 +58,6 @@ /* globals jasmine */
 
+        reportSpecStarting: function(spec) {
+            spec.startTime = new Date();
+        },
+
         reportRunnerResults: function(runner) {
@@ -74,33 +78,21 @@ var output = printTestResults(runner, this);
 
-        reportSpecStarting: function(spec) {
+        reportSpecResults: function(spec) {
+            var elapsed = spec.startTime ? (new Date() - spec.startTime) / 1000 : 0;
+            var results = spec.results();
+            var skipped = !!results.skipped;
+            var id = spec.id;
             var suite = spec.suite;
-
             var testSuite = this.testSuites[suite.id];
             var testSpec = {
-                elapsed: null,
-                executed: false,
+                elapsed: elapsed,
+                executed: !skipped,
                 failures: [],
                 id: spec.id,
                 name: spec.description,
-                success: false,
-                startTime: new Date()
+                success: results.passed()
             };
-
             this.testSpecs[spec.id] = testSpec;
-
             testSuite.specs.push(testSpec);
-        },
 
-        reportSpecResults: function(spec) {
-            var endTime = new Date();
-
-            var id = spec.id;
-            var results = spec.results();
-
-            var testSpec = this.testSpecs[id];
-            testSpec.executed = true;
-
-            var success = results.passed();
-            testSpec.success = success;
-            if (!success) {
+            if (!testSpec.success) {
                 var items = results.getItems();
@@ -115,3 +107,2 @@
                         };
-
                         testSpec.failures.push(failure);
@@ -122,8 +113,6 @@ }
 
-            var elapsed = (endTime - testSpec.startTime) / 1000;
-            testSpec.elapsed = elapsed;
-
-            for (var suite = spec.suite; suite; suite = suite.parentSuite) {
-                var testSuite = this.testSuites[suite.id];
+            while (suite) {
+                testSuite = this.testSuites[suite.id];
                 testSuite.elapsed = testSuite.elapsed ? (testSuite.elapsed + elapsed) : elapsed;
+                suite = suite.parentSuite;
             }
@@ -205,2 +194,12 @@ },
 
+    function getSkippedCount(specs) {
+        if (!specs.length) { return 0; }
+        for (var i = 0, count = 0; i < specs.length; i++) {
+            if (specs[i].results().skipped) {
+                count++;
+            }
+        }
+        return count;
+    }
+
     function printTestResults(runner, reporter) {
@@ -210,11 +209,12 @@ var testRun = reporter.testRun;
 
-        var specCount = runner.specs().length;
+        var date = new Date();
         var results = runner.results();
+        var specs = runner.specs();
+        var specCount = specs.length;
+        var skippedCount = getSkippedCount(specs);
 
-        var date = new Date();
-
         output += "<test-results name=\"" + escapeInvalidXmlChars(reporter.reportName) + "\" ";
         output += "total=\"" + specCount + "\" ";
         output += "failures=\"" + results.failedCount + "\" ";
-        output += "not-run=\"0\" ";
+        output += "not-run=\"" + skippedCount + "\" ";
         output += "date=\"" + dateString(date) + "\" ";
@@ -221,0 +221,0 @@ output += "time=\"" + timeString(date) + "\">";

No alert changes

Improved metrics

Total package byte prevSize

1767373

0.01%

Lines of code

17604

0.04%

No dependency changes