jetifier - npm Package Compare versions

Comparing version 1.5.0 to 1.5.1

CHANGELOG.md

 # Changelog
 
+## 1.5.1
+
+- add CRLF/LF compatibility, fix potential bug with empty line on mapping @m4tt72 :rocket:
+
 ## 1.5.0
 
-- node version courtesy of [Yassine Fathi](@m4tt72)! Super fast, no bash needed! It's amazing
+- node version courtesy of Yassine Fathi / @m4tt72! Super fast, no bash needed! It's amazing :fire:
 
@@ -7,0 +11,0 @@ ## 1.4.2

package.json

 {
   "name": "jetifier",
-  "version": "1.5.0",
+  "version": "1.5.1",
   "description": "jetifier from Android Studio, in npm package format",
@@ -5,0 +5,0 @@ "main": "index.js",

README.md

@@ -16,2 +16,3 @@
 * [Troubleshooting](#troubleshooting)
+* [Module Maintainers](#module-maintainers)
 * [Contributing](#contributing)
@@ -86,2 +87,15 @@
 
+## Module Maintainers
+
+One of the goals of this library is to enable module maintainers to support their AndroidX app users and their pre-AndroidX users at the same time, from the same codebase, so the react-native 0.59 -> 0.60 transition is smoother.
+
+Maintainers will potentially have to make a few changes for that to work well though.
+
+Here are the areas libraries may need to change to work well for AndroidX and pre-AndroidX apps at the same time:
+
+1. Dependency version overrides. In your library, all of your dependencies and your SDK versions should have version overrides. These offer your users flexibility to pin the versions to pre-AndroidX or AndroidX versions. Example: <https://github.com/razorpay/react-native-razorpay/pull/201> and showing ability to be very specific: <https://github.com/react-native-community/react-native-camera/blob/master/android/build.gradle#L78>
+1. AppCompat library *name* overrides - this may seem odd, but if you depend on the appcompat library itself, the whole name may need to be overridden to work correctly on RN0.60. Here is an example: <https://github.com/react-native-community/react-native-maps/commit/0c76619e8b4d591265348beb83f315ad05311670>
+1. There may be unexpected problems like one of your dependencies is doing something wrong, but it's not really your fault - bottomsheet had that problem <https://github.com/acaziasoftcom/react-native-bottomsheet/pull/23> - keep an open mind about the fixes and there is probably something you can do without giving up on forwards and backwards compatibility during the transition
+1. Finally, not really related to AndroidX, but you may simply have to make some changes related to the new auto-linking. <https://github.com/react-native-community/cli/blob/master/docs/dependencies.md>
+
 ## Contributing
@@ -88,0 +102,0 @@

src/utils.js

 const { readFileSync, readdirSync, statSync } = require('fs');
 const { join } = require('path');
 
-var readDir = (dir, filesList = []) => {
+const readDir = (dir, filesList = []) => {
   const files = readdirSync(dir);
@@ -21,4 +21,9 @@ for (let file of files) {
   const csvFilePath = join(__dirname, 'androidx-class-mapping.csv');
-  const lines = readFileSync(csvFilePath, { encoding: 'utf8' }).split('\n');
-  lines.pop(); // last element will always be an empty line so removing it from the array
+  const lines = readFileSync(csvFilePath, { encoding: 'utf8' }).split(/\r?\n/);
+  
+  // last element will always be an empty line so removing it from the array
+  if(lines[lines.length - 1] === "") {
+    lines.pop(); 
+  }
+  
   const result = {};
@@ -25,0 +30,0 @@ for (let line of lines) {

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

New author

Supply chain risk

A new npm collaborator published a version of the package for the first time. New collaborators are usually benign additions to a project, but do indicate a change to the security surface area of a package.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

2736575

increased by0.08%

Lines of code

53

increased by6%

Number of lines in readme file

110

increased by14.58%

Number of medium supply chain risk alerts

0

decreased by-100%

No dependency changes