just-compare - npm Package Compare versions

Comparing version 2.0.1 to 2.0.3

index.js

@@ -21,2 +21,3 @@ module.exports = compare;
   }
+
   /* eslint-disable no-self-compare */
@@ -27,5 +28,10 @@ // if both values are NaNs return true
   }
-  if ({}.toString.call(value1) != {}.toString.call(value2)) {
+
+  if (
+    typeof value1 != typeof value2 || // primitive != primitive wrapper
+    {}.toString.call(value1) != {}.toString.call(value2) // check for other (maybe nullish) objects
+  ) {
     return false;
   }
+
   if (value1 !== Object(value1)) {
@@ -35,16 +41,20 @@ // non equal primitives
   }
+
   if (!value1) {
     return false;
   }
+
   if (Array.isArray(value1)) {
     return compareArrays(value1, value2);
   }
+
   if ({}.toString.call(value1) == '[object Set]') {
     return compareArrays(Array.from(value1), Array.from(value2));
   }
+
   if ({}.toString.call(value1) == '[object Object]') {
     return compareObjects(value1, value2);
-  } else {
-    return compareNativeSubtypes(value1, value2);
   }
+
+  return compareNativeSubtypes(value1, value2);
 }
@@ -59,30 +69,33 @@
   var len = value1.length;
+
   if (len != value2.length) {
     return false;
   }
-  var alike = true;
+
   for (var i = 0; i < len; i++) {
     if (!compare(value1[i], value2[i])) {
-      alike = false;
-      break;
+      return false;
     }
   }
-  return alike;
+
+  return true;
 }
 
 function compareObjects(value1, value2) {
-  var keys1 = Object.keys(value1).sort();
-  var keys2 = Object.keys(value2).sort();
+  var keys1 = Object.keys(value1);
   var len = keys1.length;
-  if (len != keys2.length) {
+
+  if (len != Object.keys(value2).length) {
     return false;
   }
+
   for (var i = 0; i < len; i++) {
     var key1 = keys1[i];
-    var key2 = keys2[i];
-    if (!(key1 == key2 && compare(value1[key1], value2[key2]))) {
+
+    if (!(value2.hasOwnProperty(key1) && compare(value1[key1], value2[key1]))) {
       return false;
     }
   }
+
   return true;
 }

package.json

 {
   "name": "just-compare",
-  "version": "2.0.1",
+  "version": "2.0.3",
   "description": "compare two collections",
@@ -5,0 +5,0 @@ "main": "index.js",

README.md

@@ -0,1 +1,4 @@
+<!-- DO NOT EDIT THIS FILE! THIS FILE WAS AUTOGENERATED BY TEMPLATE-MATE -->
+<!-- SEE https://github.com/angus-c/just/blob/master/CONTRIBUTING.md#readme-template -->
+
 ## just-compare
@@ -2,0 +5,0 @@

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

7640

increased by4.23%

Number of package files

7

increased by16.67%

Number of lines in readme file

37

increased by8.82%

Worsened metrics

Lines of code

157

decreased by-2.48%

No dependency changes