kafkajs - npm Package Compare versions

Comparing version 1.13.0-beta.16 to 1.13.0-beta.17

package.json

 {
   "name": "kafkajs",
-  "version": "1.13.0-beta.16",
+  "version": "1.13.0-beta.17",
   "description": "A modern Apache Kafka client for node.js",
@@ -82,5 +82,5 @@ "author": "Tulio Ornelas <[e-mail]>",
   "kafkajs": {
-    "sha": "9b65843638e73dd6d3360a9b5faf45680a184826",
-    "compare": "https://github.com/tulios/kafkajs/compare/v1.12.0...9b65843638e73dd6d3360a9b5faf45680a184826"
+    "sha": "cfbb49d2133719683babe07c9e3d33068a3dae4a",
+    "compare": "https://github.com/tulios/kafkajs/compare/v1.12.0...cfbb49d2133719683babe07c9e3d33068a3dae4a"
   }
 }

src/protocol/encoder.js

@@ -176,11 +176,11 @@ const Long = require('long')
   writeEncoder(value) {
-    if (value instanceof Encoder !== true) {
+    if (value == null || value.buffer == null) {
       throw new Error('value should be an instance of Encoder')
     }
-    this.buffer = Buffer.concat([this.buffer, value.buffer])
-    return this
+
+    return this.writeBuffer(value.buffer)
   }
 
   writeEncoderArray(value) {
-    if (!Array.isArray(value) || value.some(v => !(v instanceof Encoder))) {
+    if (!Array.isArray(value) || value.some(v => v == null || !Buffer.isBuffer(v.buffer))) {
       throw new Error('all values should be an instance of Encoder[]')
@@ -198,3 +198,3 @@ }
   writeBuffer(value) {
-    if (value instanceof Buffer !== true) {
+    if (!Buffer.isBuffer(value)) {
       throw new Error('value should be an instance of Buffer')
@@ -201,0 +201,0 @@ }

No alert changes

Worsened metrics

Total package byte prevSize

513154

0

Lines of code

15185

-0.01%

No dependency changes