kafkajs - npm Package Compare versions

Comparing version 1.14.0 to 1.15.0-beta.0

package.json

 {
   "name": "kafkajs",
-  "version": "1.14.0",
+  "version": "1.15.0-beta.0",
   "description": "A modern Apache Kafka client for node.js",
@@ -81,3 +81,7 @@ "author": "Tulio Ornelas <[e-mail]>",
     ]
+  },
+  "kafkajs": {
+    "sha": "7acda2785ac0ead9b26bd04c471ea4520ac0e150",
+    "compare": "https://github.com/tulios/kafkajs/compare/v1.14.0...7acda2785ac0ead9b26bd04c471ea4520ac0e150"
   }
-}
+}

src/consumer/index.js

@@ -260,10 +260,6 @@ const Long = require('../utils/long')
 
-      instrumentationEmitter.emit(CRASH, {
-        error: e,
-        groupId,
-      })
-
-      if (e.name === 'KafkaJSNumberOfRetriesExceeded' || e.retriable === true) {
-        const shouldRestart =
-          !retry ||
+      const isErrorRetriable = e.name === 'KafkaJSNumberOfRetriesExceeded' || e.retriable === true
+      const shouldRestart =
+        isErrorRetriable &&
+        (!retry ||
           !retry.restartOnFailure ||
@@ -281,14 +277,19 @@ (await retry.restartOnFailure(e).catch(error => {
             return true
-          }))
+          })))
 
-        if (shouldRestart) {
-          const retryTime = e.retryTime || (retry && retry.initialRetryTime) || initialRetryTime
-          logger.error(`Restarting the consumer in ${retryTime}ms`, {
-            retryCount: e.retryCount,
-            retryTime,
-            groupId,
-          })
+      instrumentationEmitter.emit(CRASH, {
+        error: e,
+        groupId,
+        restart: shouldRestart,
+      })
 
-          setTimeout(() => restart(onCrash), retryTime)
-        }
+      if (shouldRestart) {
+        const retryTime = e.retryTime || (retry && retry.initialRetryTime) || initialRetryTime
+        logger.error(`Restarting the consumer in ${retryTime}ms`, {
+          retryCount: e.retryCount,
+          retryTime,
+          groupId,
+        })
+
+        setTimeout(() => restart(onCrash), retryTime)
       }
@@ -295,0 +296,0 @@ }

New alerts

No v1

Quality

Package is not semver >=1. This means it is not stable and does not support ^ ranges.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

578925

0.04%

Lines of code

17032

0.01%

Worsened metrics

Number of low quality alerts

1

Infinity%

No dependency changes