karma-phantomjs-launcher - npm Package Compare versions

Comparing version 0.2.1 to 0.2.2

CHANGELOG.md

@@ -0,1 +1,11 @@
+<a name"0.2.2"></a>
+### 0.2.2 (2015-12-24)
+
+
+#### Bug Fixes
+
+* pass PhantomJS script as the first cmd-line argument ([1c195c6b](https://github.com/karma-runner/karma-phantomjs-launcher/commit/1c195c6b))
+* do not duplicate cmd-line flags on repeated PhantomJS runs ([76228f18](https://github.com/karma-runner/karma-phantomjs-launcher/commit/76228f18))
+
+
 <a name"0.2.1"></a>
@@ -2,0 +12,0 @@ ### 0.2.1 (2015-08-05)

index.js

@@ -32,3 +32,3 @@ var fs = require('fs')
   var options = args && args.options || config && config.options || {}
-  var flags = args && args.flags || config && config.flags || []
+  var providedFlags = args && args.flags || config && config.flags || []
 
@@ -52,7 +52,2 @@ this._start = function (url) {
 
-    if (args.debug) {
-      flags = flags.concat('--remote-debugger-port=9000')
-      flags = flags.concat('--remote-debugger-autorun=yes')
-    }
-
     var file = fs.readFileSync(path.join(__dirname, 'capture.template.js'))
@@ -71,3 +66,8 @@
 
-    flags = flags.concat(captureFile)
+    // PhantomJS takes its script file as the first cmd-line argument
+    var flags = [captureFile].concat(providedFlags)
+    if (args.debug) {
+      flags.push('--remote-debugger-port=9000')
+      flags.push('--remote-debugger-autorun=yes')
+    }
 
@@ -74,0 +74,0 @@ // and start phantomjs

package.json

 {
   "name": "karma-phantomjs-launcher",
-  "version": "0.2.1",
+  "version": "0.2.2",
   "description": "A Karma plugin. Launcher for PhantomJS.",
@@ -31,2 +31,3 @@ "main": "index.js",
     "eslint-plugin-react": "^3.2.0",
+    "eslint-plugin-standard": "^1.3.1",
     "grunt": "~0.4.1",
@@ -37,3 +38,3 @@ "grunt-auto-release": "~0.0.2",
     "grunt-eslint": "^17.0.0",
-    "grunt-karma": "^0.11.0",
+    "grunt-karma": "^0.12.1",
     "grunt-npm": "~0.0.2",
@@ -43,3 +44,4 @@ "jasmine-core": "^2.3.4",
     "karma-jasmine": "^0.3.5",
-    "load-grunt-tasks": "^3.2.0"
+    "load-grunt-tasks": "^3.2.0",
+    "phantomjs": "^1.9.19"
   },
@@ -49,7 +51,7 @@ "contributors": [
     "Friedel Ziegelmayer <[e-mail]>",
+    "Jurko Gospodnetić <[e-mail]>",
     "Friedel Ziegelmayer <[e-mail]>",
+    "Dan Siwiec <[e-mail]>",
+    "Huafu Gandon <[e-mail]>",
     "Sylvain Hamel <[e-mail]>",
-    "Huafu Gandon <[e-mail]>",
-    "Nick Malaguti <[e-mail]>",
-    "Rob Barreca <[e-mail]>",
     "nherzing <[e-mail]>",
@@ -62,4 +64,6 @@ "Chad Smith <[e-mail]>",
     "Jonathan Park <[e-mail]>",
-    "Mark Derbecker <[e-mail]>"
+    "Mark Derbecker <[e-mail]>",
+    "Nick Malaguti <[e-mail]>",
+    "Rob Barreca <[e-mail]>"
   ]
 }

README.md

@@ -12,18 +12,11 @@ # karma-phantomjs-launcher
 
-The easiest way is to keep `karma-phantomjs-launcher` as a devDependency in your `package.json`.
-```json
-{
-  "devDependencies": {
-    "karma": "~0.10",
-    "karma-phantomjs-launcher": "~0.1"
-  }
-}
-```
+The easiest way is to keep `karma-phantomjs-launcher` as a devDependency in your `package.json`,
+by running
 
-You can simple do it by:
 ```bash
-npm install karma-phantomjs-launcher --save-dev
+$ npm install --save-dev karma-phantomjs-launcher
 ```
 
 ## Configuration
+
 ```js
@@ -54,9 +47,31 @@ // karma.conf.js
     }
-  });
-};
+  })
+}
 ```
 
+The `options` attribute allows you to initialize properties on
+the phantomjs `page` object, so
+
+```js
+options: {
+  windowName: 'my-window',
+  settings: {
+    webSecurityEnabled: false
+  },
+}
+```
+
+is equivalent to:
+
+```js
+var webPage = require('webpage')
+var page = webPage.create()
+
+page.windowName = 'my-window'
+page.settings.webSecurityEnabled = false
+```
+
 You can pass list of browsers as a CLI argument too:
 ```bash
-karma start --browsers PhantomJS_custom
+$ karma start --browsers PhantomJS_custom
 ```
@@ -63,0 +78,0 @@

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

14707

increased by5.24%

Lines of code

211

increased by0.48%

Number of lines in readme file

90

increased by20%

Worsened metrics

Dev dependency count

16

increased by14.29%

No dependency changes