kurento-utils - npm Package Compare versions

Comparing version 5.0.4 to 5.1.0

lib/WebRtcPeer.js

@@ -13,3 +13,2 @@ /*
  * Lesser General Public License for more details.
- *
  */
@@ -23,8 +22,7 @@
  *              previously created.
- * 
+ *
  * @function defaultOnerror
- * 
+ *
  * @param error -
  *            {String} Error message
- * 
  */
@@ -40,8 +38,7 @@ function defaultOnerror(error) {
 /**
- * 
  * @classdesc Wrapper object of an RTCPeerConnection. This object is aimed to
  *            simplify the development of WebRTC-based applications.
- * 
+ *
  * @constructor module:kurentoUtils.WebRtcPeer
- * 
+ *
  * @param mode -
@@ -67,3 +64,2 @@ *            {String} Mode in which the PeerConnection will be configured.
  *            RTCPeerConnection
- * 
  */
@@ -92,12 +88,15 @@ function WebRtcPeer(mode, localVideo, remoteVideo, onsdpoffer, onerror,
  *              SDP offer, in order to obtain an SDP answer from another peer.
- * 
+ *
  * @function module:kurentoUtils.WebRtcPeer.prototype.start
- * 
+ *
  */
-WebRtcPeer.prototype.start = function() {
+WebRtcPeer.prototype.start = function(server, options) {
 
 	var self = this;
 
+	server  = server  || this.server;
+	options = options || this.seoptionsrver;
+
 	if (!this.pc) {
-		this.pc = new RTCPeerConnection(this.server, this.options);
+		this.pc = new RTCPeerConnection(server, options);
 	}
@@ -159,5 +158,4 @@
  * @description This method frees the resources used by WebRtcPeer.
- * 
+ *
  * @function module:kurentoUtils.WebRtcPeer.prototype.dispose
- * 
  */
@@ -195,5 +193,4 @@ WebRtcPeer.prototype.dispose = function() {
  *              maxFrameRate=15, minFrameRate=15.
- * 
+ *
  * @alias module:kurentoUtils.WebRtcPeer.prototype.userMediaConstraints
- * 
  */
@@ -215,10 +212,12 @@ WebRtcPeer.prototype.userMediaConstraints = {
  *              complete the SDP negotiation.
- * 
+ *
  * @function module:kurentoUtils.WebRtcPeer.prototype.processSdpAnswer
- * 
+ *
  * @param sdpAnswer -
  *            Description of sdpAnswer
- * 
+ * @param successCallback -
+ *            Called when the remoteDescription and the remoteVideo.src have
+ *            been set successfully.
  */
-WebRtcPeer.prototype.processSdpAnswer = function(sdpAnswer) {
+WebRtcPeer.prototype.processSdpAnswer = function(sdpAnswer, successCallback) {
 	var answer = new RTCSessionDescription({
@@ -236,2 +235,5 @@ type : 'answer',
 		}
+		if (successCallback) {
+			successCallback();
+		}
 	}, this.onerror);
@@ -242,5 +244,4 @@ }
  * @description Default ICE server (stun:stun.l.google.com:19302).
- * 
+ *
  * @alias module:kurentoUtils.WebRtcPeer.prototype.server
- * 
  */
@@ -254,5 +255,4 @@ WebRtcPeer.prototype.server = {
  *              RTCPeerConnection.
- * 
+ *
  * @alias module:kurentoUtils.WebRtcPeer.prototype.options
- * 
  */
@@ -268,5 +268,5 @@ WebRtcPeer.prototype.options = {
  *              if needed.
- * 
+ *
  * @function module:kurentoUtils.WebRtcPeer.start
- * 
+ *
  * @param mode -
@@ -298,7 +298,7 @@ *            {String} Mode in which the PeerConnection will be configured.
  *            RTCPeerConnection
- * 
+ *
  * @return {module:kurentoUtils.WebRtcPeer}
  */
 WebRtcPeer.start = function(mode, localVideo, remoteVideo, onSdp, onerror,
-		mediaConstraints, videoStream, audioStream) {
+		mediaConstraints, videoStream, audioStream, server, options) {
 	var wp = new WebRtcPeer(mode, localVideo, remoteVideo, onSdp, onerror,
@@ -313,6 +313,6 @@ videoStream, audioStream);
 			wp.stream = userStream;
-			wp.start();
+			wp.start(server, options);
 		}, wp.onerror);
 	} else {
-		wp.start();
+		wp.start(server, options);
 	}
@@ -325,5 +325,5 @@
  * @description This methods creates a WebRtcPeer to receive video.
- * 
+ *
  * @function module:kurentoUtils.WebRtcPeer.startRecvOnly
- * 
+ *
  * @param remoteVideo -
@@ -338,9 +338,9 @@ *            {Object} Video tag for the remote stream
  *            {Object[]} Constraints used to create RTCPeerConnection
- * 
+ *
  * @return {module:kurentoUtils.WebRtcPeer}
  */
 WebRtcPeer.startRecvOnly = function(remoteVideo, onSdp, onError,
-		mediaConstraints) {
+		mediaConstraints, server, options) {
 	return WebRtcPeer.start('recv', null, remoteVideo, onSdp, onError,
-			mediaConstraints);
+			mediaConstraints, server, options);
 };
@@ -350,5 +350,5 @@
  * @description This methods creates a WebRtcPeer to send video.
- * 
+ *
  * @function module:kurentoUtils.WebRtcPeer.startSendOnly
- * 
+ *
  * @param localVideo -
@@ -363,9 +363,9 @@ *            {Object} Video tag for the local stream
  *            {Object[]} Constraints used to create RTCPeerConnection
- * 
+ *
  * @return {module:kurentoUtils.WebRtcPeer}
  */
 WebRtcPeer.startSendOnly = function(localVideo, onSdp, onError,
-		mediaConstraints) {
+		mediaConstraints, server, options) {
 	return WebRtcPeer.start('send', localVideo, null, onSdp, onError,
-			mediaConstraints);
+			mediaConstraints, server, options);
 };
@@ -375,5 +375,5 @@
  * @description This methods creates a WebRtcPeer to send and receive video.
- * 
+ *
  * @function module:kurentoUtils.WebRtcPeer.startSendRecv
- * 
+ *
  * @param localVideo -
@@ -390,11 +390,11 @@ *            {Object} Video tag for the local stream
  *            {Object[]} Constraints used to create RTCPeerConnection
- * 
+ *
  * @return {module:kurentoUtils.WebRtcPeer}
  */
 WebRtcPeer.startSendRecv = function(localVideo, remoteVideo, onSdp, onError,
-		mediaConstraints) {
+		mediaConstraints, server, options) {
 	return WebRtcPeer.start('sendRecv', localVideo, remoteVideo, onSdp,
-			onError, mediaConstraints);
+			onError, mediaConstraints, server, options);
 };
 
 module.exports = WebRtcPeer;

package.json

 {
   "name": "kurento-utils",
-  "version": "5.0.4",
+  "version": "5.1.0",
   "description": "Kurento Utilities",
@@ -28,11 +28,10 @@ "homepage": "http://www.kurento.org",
     "bower": "~1.3.12",
-    "grunt": "~0.4.5",
+    "grunt": "^0.4.5",
     "grunt-browserify": "~3.0.1",
+    "grunt-cli": "~0.1.13",
+    "grunt-contrib-clean": "~0.6.0",
+    "grunt-jsdoc": "^0.6.1",
     "grunt-npm2bower-sync": "^0.4.0",
-    "grunt-jsdoc": "^0.5.7",
     "grunt-shell": "^1.1.1",
-    "grunt-cli": "~0.1.13",
-    "grunt-contrib-clean": "~0.6.0",
-    "minifyify": "~4.4.0",
-    "browserify": "~6.0.2"
+    "minifyify": "~4.4.0"
   },
@@ -39,0 +38,0 @@ "dependencies": {

README_bower.md

@@ -19,5 +19,4 @@ [![][KurentoImage]][website]
 ```bash
-sudo add-apt-repository ppa:chris-lea/node.js
-sudo apt-get update
-sudo apt-get install nodejs
+curl -sL https://deb.nodesource.com/setup | sudo bash -
+sudo apt-get install -y nodejs
 sudo npm install -g bower
@@ -24,0 +23,0 @@ ```

README.md

@@ -19,5 +19,4 @@ [![][KurentoImage]][website]
 ```bash
-sudo add-apt-repository ppa:chris-lea/node.js
-sudo apt-get update
-sudo apt-get install nodejs
+curl -sL https://deb.nodesource.com/setup | sudo bash -
+sudo apt-get install -y nodejs
 sudo npm install -g bower
@@ -24,0 +23,0 @@ ```

No alert changes

Improved metrics

Total package byte prevSize

57457

0.6%

Dev dependency count

9

-10%

Worsened metrics

Lines of code

503

-0.2%

Number of lines in readme file

86

-1.15%

No dependency changes