lit-html - npm Package Compare versions

Comparing version 0.2.4 to 0.2.5

lib/lit-html.d.ts

@@ -39,6 +39,6 @@ /**
     index: number;
-    name: string;
-    rawName: string;
-    strings: string[];
-    constructor(type: string, index: number, name?: string, rawName?: string, strings?: string[]);
+    name: string | undefined;
+    rawName: string | undefined;
+    strings: string[] | undefined;
+    constructor(type: string, index: number, name?: string | undefined, rawName?: string | undefined, strings?: string[] | undefined);
 }
@@ -45,0 +45,0 @@ export declare class Template {

lib/lit-html.js

@@ -139,2 +139,6 @@ /**
                 }
+                else if (!node.nodeValue.trim()) {
+                    nodesToRemove.push(node);
+                    index--;
+                }
             }
@@ -141,0 +145,0 @@ }

lib/test/lit-html_test.js

@@ -184,7 +184,5 @@ /**
                     .renderTo(container);
-                assert.equal(container.innerHTML, `
-            <div foo="bar">
+                assert.equal(container.innerHTML, `<div foo="bar">
               baz
-              <p>qux</p>
-            </div>`);
+              <p>qux</p></div>`);
             });
@@ -191,0 +189,0 @@ });

lib/test/repeat_test.js

@@ -38,6 +38,3 @@ /**
             r(part);
-            assert.equal(container.innerHTML, `
-            <li>item: 1</li>
-            <li>item: 2</li>
-            <li>item: 3</li>`);
+            assert.equal(container.innerHTML, `<li>item: 1</li><li>item: 2</li><li>item: 3</li>`);
         });
@@ -49,13 +46,7 @@ test('shuffles are stable', () => {
             t()(part);
-            assert.equal(container.innerHTML, `
-            <li>item: 1</li>
-            <li>item: 2</li>
-            <li>item: 3</li>`);
+            assert.equal(container.innerHTML, `<li>item: 1</li><li>item: 2</li><li>item: 3</li>`);
             const children1 = Array.from(container.querySelectorAll('li'));
             items = [3, 2, 1];
             t()(part);
-            assert.equal(container.innerHTML, `
-            <li>item: 3</li>
-            <li>item: 2</li>
-            <li>item: 1</li>`);
+            assert.equal(container.innerHTML, `<li>item: 3</li><li>item: 2</li><li>item: 1</li>`);
             const children2 = Array.from(container.querySelectorAll('li'));
@@ -73,7 +64,3 @@ assert.strictEqual(children1[0], children2[2]);
             t()(part);
-            assert.equal(container.innerHTML, `
-            <li>item: 0</li>
-            <li>item: 1</li>
-            <li>item: 2</li>
-            <li>item: 3</li>`);
+            assert.equal(container.innerHTML, `<li>item: 0</li><li>item: 1</li><li>item: 2</li><li>item: 3</li>`);
         });
@@ -87,7 +74,3 @@ test('can insert an item at the end', () => {
             t()(part);
-            assert.equal(container.innerHTML, `
-            <li>item: 1</li>
-            <li>item: 2</li>
-            <li>item: 3</li>
-            <li>item: 4</li>`);
+            assert.equal(container.innerHTML, `<li>item: 1</li><li>item: 2</li><li>item: 3</li><li>item: 4</li>`);
         });
@@ -111,5 +94,3 @@ test('can replace with an empty list', () => {
             t()(part);
-            assert.equal(container.innerHTML, `
-            <li>item: 2</li>
-            <li>item: 3</li>`);
+            assert.equal(container.innerHTML, `<li>item: 2</li><li>item: 3</li>`);
             const children2 = Array.from(container.querySelectorAll('li'));
@@ -127,5 +108,3 @@ assert.strictEqual(children1[1], children2[0]);
             t()(part);
-            assert.equal(container.innerHTML, `
-            <li>item: 1</li>
-            <li>item: 2</li>`);
+            assert.equal(container.innerHTML, `<li>item: 1</li><li>item: 2</li>`);
             const children2 = Array.from(container.querySelectorAll('li'));
@@ -143,5 +122,3 @@ assert.strictEqual(children1[0], children2[0]);
             t()(part);
-            assert.equal(container.innerHTML, `
-            <li>item: 1</li>
-            <li>item: 3</li>`);
+            assert.equal(container.innerHTML, `<li>item: 1</li><li>item: 3</li>`);
             const children2 = Array.from(container.querySelectorAll('li'));
@@ -157,6 +134,3 @@ assert.strictEqual(children1[0], children2[0]);
             r(part);
-            assert.equal(container.innerHTML, `
-            <li>item: 1</li>
-            <li>item: 2</li>
-            <li>item: 3</li>`);
+            assert.equal(container.innerHTML, `<li>item: 1</li><li>item: 2</li><li>item: 3</li>`);
         });
@@ -168,12 +142,6 @@ test('shuffles a list', () => {
             t()(part);
-            assert.equal(container.innerHTML, `
-            <li>item: 1</li>
-            <li>item: 2</li>
-            <li>item: 3</li>`);
+            assert.equal(container.innerHTML, `<li>item: 1</li><li>item: 2</li><li>item: 3</li>`);
             items = [3, 2, 1];
             t()(part);
-            assert.equal(container.innerHTML, `
-            <li>item: 3</li>
-            <li>item: 2</li>
-            <li>item: 1</li>`);
+            assert.equal(container.innerHTML, `<li>item: 3</li><li>item: 2</li><li>item: 1</li>`);
         });
@@ -180,0 +148,0 @@ test('can replace with an empty list', () => {

package.json

 {
   "name": "lit-html",
-  "version": "0.2.4",
+  "version": "0.2.5",
   "description": "HTML template literals in JavaScript",
@@ -5,0 +5,0 @@ "license": "BSD-3-Clause",

src/lit-html.ts

@@ -152,2 +152,5 @@ /**
           nodesToRemove.push(node);
+        } else if (!node.nodeValue!.trim()) {
+          nodesToRemove.push(node);
+          index--;
         }
@@ -154,0 +157,0 @@ }

src/test/lit-html_test.ts

@@ -219,7 +219,5 @@ /**
           .renderTo(container);
-        assert.equal(container.innerHTML, `
-            <div foo="bar">
+        assert.equal(container.innerHTML, `<div foo="bar">
               baz
-              <p>qux</p>
-            </div>`);
+              <p>qux</p></div>`);
       });
@@ -226,0 +224,0 @@

src/test/repeat_test.ts

@@ -46,6 +46,3 @@ /**
       r(part);
-      assert.equal(container.innerHTML, `
-            <li>item: 1</li>
-            <li>item: 2</li>
-            <li>item: 3</li>`);
+      assert.equal(container.innerHTML, `<li>item: 1</li><li>item: 2</li><li>item: 3</li>`);
     });
@@ -58,6 +55,3 @@
       t()(part);
-      assert.equal(container.innerHTML, `
-            <li>item: 1</li>
-            <li>item: 2</li>
-            <li>item: 3</li>`);
+      assert.equal(container.innerHTML, `<li>item: 1</li><li>item: 2</li><li>item: 3</li>`);
       const children1 = Array.from(container.querySelectorAll('li'));
@@ -67,6 +61,3 @@
       t()(part);
-      assert.equal(container.innerHTML, `
-            <li>item: 3</li>
-            <li>item: 2</li>
-            <li>item: 1</li>`);
+      assert.equal(container.innerHTML, `<li>item: 3</li><li>item: 2</li><li>item: 1</li>`);
       const children2 = Array.from(container.querySelectorAll('li'));
@@ -86,7 +77,3 @@ assert.strictEqual(children1[0], children2[2]);
       t()(part);
-      assert.equal(container.innerHTML, `
-            <li>item: 0</li>
-            <li>item: 1</li>
-            <li>item: 2</li>
-            <li>item: 3</li>`);
+      assert.equal(container.innerHTML, `<li>item: 0</li><li>item: 1</li><li>item: 2</li><li>item: 3</li>`);
     });
@@ -102,7 +89,3 @@
       t()(part);
-      assert.equal(container.innerHTML, `
-            <li>item: 1</li>
-            <li>item: 2</li>
-            <li>item: 3</li>
-            <li>item: 4</li>`);
+      assert.equal(container.innerHTML, `<li>item: 1</li><li>item: 2</li><li>item: 3</li><li>item: 4</li>`);
     });
@@ -130,5 +113,3 @@
       t()(part);
-      assert.equal(container.innerHTML, `
-            <li>item: 2</li>
-            <li>item: 3</li>`);
+      assert.equal(container.innerHTML, `<li>item: 2</li><li>item: 3</li>`);
       const children2 = Array.from(container.querySelectorAll('li'));
@@ -148,5 +129,3 @@ assert.strictEqual(children1[1], children2[0]);
       t()(part);
-      assert.equal(container.innerHTML, `
-            <li>item: 1</li>
-            <li>item: 2</li>`);
+      assert.equal(container.innerHTML, `<li>item: 1</li><li>item: 2</li>`);
       const children2 = Array.from(container.querySelectorAll('li'));
@@ -166,5 +145,3 @@ assert.strictEqual(children1[0], children2[0]);
       t()(part);
-      assert.equal(container.innerHTML, `
-            <li>item: 1</li>
-            <li>item: 3</li>`);
+      assert.equal(container.innerHTML, `<li>item: 1</li><li>item: 3</li>`);
       const children2 = Array.from(container.querySelectorAll('li'));
@@ -183,6 +160,3 @@ assert.strictEqual(children1[0], children2[0]);
       r(part);
-      assert.equal(container.innerHTML, `
-            <li>item: 1</li>
-            <li>item: 2</li>
-            <li>item: 3</li>`);
+      assert.equal(container.innerHTML, `<li>item: 1</li><li>item: 2</li><li>item: 3</li>`);
     });
@@ -195,13 +169,7 @@
       t()(part);
-      assert.equal(container.innerHTML, `
-            <li>item: 1</li>
-            <li>item: 2</li>
-            <li>item: 3</li>`);
+      assert.equal(container.innerHTML, `<li>item: 1</li><li>item: 2</li><li>item: 3</li>`);
 
       items = [3, 2, 1];
       t()(part);
-      assert.equal(container.innerHTML, `
-            <li>item: 3</li>
-            <li>item: 2</li>
-            <li>item: 1</li>`);
+      assert.equal(container.innerHTML, `<li>item: 3</li><li>item: 2</li><li>item: 1</li>`);
     });
@@ -208,0 +176,0 @@

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Worsened metrics

Total package byte prevSize

179367

decreased by-0.24%

Lines of code

2506

decreased by-2.38%

No dependency changes