ln-service - npm Package Compare versions

Comparing version 55.0.0 to 56.0.0

CHANGELOG.md

 # Versions
 
+## 56.0.0
+
+### Breaking Changes
+
+- Minimum version of node.js is moved up from 14 to 16
+
 ## 55.0.0
@@ -4,0 +10,0 @@

package.json

@@ -14,3 +14,3 @@ {
     "invoices": "2.2.3",
-    "lightning": "8.0.0",
+    "lightning": "9.0.0",
     "macaroon": "3.0.4",
@@ -32,3 +32,3 @@ "morgan": "1.10.0",
     "ecpair": "2.1.0",
-    "ln-docker-daemons": "4.1.4",
+    "ln-docker-daemons": "5.0.0",
     "p2tr": "1.3.3",
@@ -44,3 +44,3 @@ "portfinder": "1.0.32",
   "engines": {
-    "node": ">=14"
+    "node": ">=16"
   },
@@ -71,3 +71,3 @@ "keywords": [
   },
-  "version": "55.0.0"
+  "version": "56.0.0"
 }

test/integration/test_delete_pending_channel.js

@@ -33,3 +33,3 @@ const {once} = require('events');
 const timeout = 1000 * 20;
-const times = 300;
+const times = 500;
 
@@ -36,0 +36,0 @@ // Forfeiting a pending channel should remove the pending channel

test/integration/test_get_channel.js

@@ -28,3 +28,3 @@ const {spawnLightningCluster} = require('ln-docker-daemons');
     equal(policy.base_fee_mtokens, '1000', 'Base fee mtokens');
-    equal(policy.cltv_delta, 40, 'CLTV policy');
+    equal([40, 80].includes(policy.cltv_delta), true, 'CLTV policy');
     equal(policy.fee_rate, 1, 'Fee rate');
@@ -31,0 +31,0 @@ equal(policy.is_disabled, false, 'Disabled flag');

test/integration/test_get_network_graph.js

@@ -54,3 +54,3 @@ const asyncRetry = require('async/retry');
     equal(policy.base_fee_mtokens, '1000', 'Default channel base fee');
-    equal(policy.cltv_delta, 40, 'Default channel CLTV delta');
+    equal([40, 80].includes(policy.cltv_delta), true, 'Default CLTV delta');
     equal(policy.fee_rate, 1, 'Default channel fee rate');
@@ -57,0 +57,0 @@ equal(policy.is_disabled, false, 'Channels are active');

test/integration/test_pay_private_invoice.js

@@ -80,2 +80,3 @@ const {randomBytes} = require('crypto');
         lnd,
+        cltv_delta: decodedRequest.cltv_delta,
         destination: decodedRequest.destination,
@@ -82,0 +83,0 @@ payment: invoice.payment,

test/integration/test_pay.js

@@ -70,3 +70,8 @@ const {randomBytes} = require('crypto');
   paid.hops.forEach(n => {
-    equal(n.timeout === height + 40 || n.timeout === height + 43, true);
+    equal(
+      n.timeout === height + 40 ||
+      n.timeout === height + 43 ||
+      n.timeout === height + 80,
+      true
+    );
 
@@ -73,0 +78,0 @@ delete n.timeout;

test/integration/test_subscribe_to_rpc_requests.js

@@ -120,3 +120,3 @@ const {spawnLightningCluster} = require('ln-docker-daemons');
 
-    await delay(2000);
+    await delay(2500);
 
@@ -123,0 +123,0 @@ subscription.removeAllListeners();

test/routerrpc-integration/test_pay_via_payment_details.js

@@ -39,4 +39,9 @@ const {spawnLightningCluster} = require('ln-docker-daemons');
     const height = (await getHeight({lnd})).current_block_height;
-    const invoice = await createInvoice({tokens, lnd: remote.lnd});
 
+    const invoice = await createInvoice({
+      tokens,
+      cltv_delta: 40,
+      lnd: remote.lnd,
+    });
+
     const {features} = await decodePaymentRequest({
@@ -97,3 +102,3 @@ lnd,
         err,
-        [503, 'PaymentPathfindingFailedToFindPossibleRoute'],
+        [400, 'MaxTimeoutTooNearCurrentHeightToMakePayment'],
         'Fail'
@@ -109,3 +114,3 @@ );
         id: invoice.id,
-        max_timeout_height: height + 90,
+        max_timeout_height: height + 200,
         messages: [{type: tlvType, value: tlvData}],
@@ -123,10 +128,4 @@ payment: invoice.payment,
 
-      paid.hops.forEach(n => {
-        equal(n.timeout === height + 40 || n.timeout === height + 43, true);
+      paid.hops.forEach(n => delete n.timeout);
 
-        delete n.timeout;
-
-        return;
-      });
-
       strictSame(paid.hops, expectedHops, 'Hops are returned');
@@ -133,0 +132,0 @@ } catch (err) {

test/routerrpc-integration/test_pay_via_routes.js

@@ -103,2 +103,3 @@ const {randomBytes} = require('crypto');
     lnd,
+    cltv_delta: decodedRequest.cltv_delta,
     destination: decodedRequest.destination,
@@ -105,0 +106,0 @@ payment: invoice.payment,

test/routerrpc-integration/test_subscribe_to_forwards.js

@@ -136,3 +136,8 @@ const asyncRetry = require('async/retry');
     [controlForwards, targetForwards, remoteForwards].forEach(forwards => {
-      return forwards.forEach(n => delete n.at && delete n.secret);
+      return forwards.forEach(n =>
+        delete n.at &&
+        delete n.cltv_delta &&
+        delete n.secret &&
+        delete n.timeout
+      );
     });
@@ -146,3 +151,2 @@
         {
-          cltv_delta: undefined,
           external_failure: undefined,
@@ -161,7 +165,5 @@ fee: undefined,
           out_payment: 0,
-          timeout: height + 40 + 43,
           tokens: 101,
         },
         {
-          cltv_delta: undefined,
           external_failure: undefined,
@@ -180,3 +182,2 @@ fee: undefined,
           out_payment: 0,
-          timeout: undefined,
           tokens: undefined,
@@ -199,7 +200,5 @@ },
           out_payment: 1,
-          timeout: height + 40 + 43,
           tokens: 490851,
         },
         {
-          cltv_delta: undefined,
           external_failure: undefined,
@@ -218,7 +217,5 @@ fee: undefined,
           out_payment: 1,
-          timeout: undefined,
           tokens: undefined,
         },
         {
-          cltv_delta: undefined,
           external_failure: undefined,
@@ -237,7 +234,5 @@ fee: undefined,
           out_payment: 2,
-          timeout: height + 43,
           tokens: 100,
         },
         {
-          cltv_delta: undefined,
           external_failure: undefined,
@@ -256,3 +251,2 @@ fee: undefined,
           out_payment: 2,
-          timeout: undefined,
           tokens: undefined,
@@ -265,3 +259,2 @@ },
         {
-          cltv_delta: 40,
           external_failure: undefined,
@@ -280,7 +273,5 @@ fee: 1,
           out_payment: 0,
-          timeout: 497,
           tokens: 100,
         },
         {
-          cltv_delta: undefined,
           external_failure: undefined,
@@ -299,7 +290,5 @@ fee: undefined,
           out_payment: 0,
-          timeout: undefined,
           tokens: undefined,
         },
         {
-          cltv_delta: 40,
           external_failure: 'TEMPORARY_CHANNEL_FAILURE',
@@ -318,7 +307,5 @@ fee: 1,
           out_payment: 0,
-          timeout: 497,
           tokens: 490850,
         },
         {
-          cltv_delta: undefined,
           external_failure: 'INCORRECT_OR_UNKNOWN_PAYMENT_DETAILS',
@@ -337,3 +324,2 @@ fee: undefined,
           out_payment: undefined,
-          timeout: undefined,
           tokens: undefined,
@@ -346,3 +332,2 @@ },
         {
-          cltv_delta: undefined,
           external_failure: undefined,
@@ -361,3 +346,2 @@ fee: undefined,
           out_payment: undefined,
-          timeout: undefined,
           tokens: undefined,
@@ -370,3 +354,2 @@ },
         {
-          cltv_delta: undefined,
           external_failure: undefined,
@@ -385,7 +368,5 @@ fee: undefined,
           out_payment: 0,
-          timeout: height + 40 + 43,
           tokens: 101,
         },
         {
-          cltv_delta: undefined,
           external_failure: undefined,
@@ -404,7 +385,5 @@ fee: undefined,
           out_payment: 0,
-          timeout: undefined,
           tokens: undefined,
         },
         {
-          cltv_delta: undefined,
           external_failure: undefined,
@@ -423,7 +402,5 @@ fee: undefined,
           out_payment: 1,
-          timeout: height + 40 + 43,
           tokens: 496431,
         },
         {
-          cltv_delta: undefined,
           external_failure: undefined,
@@ -442,7 +419,5 @@ fee: undefined,
           out_payment: 1,
-          timeout: undefined,
           tokens: undefined,
         },
         {
-          cltv_delta: undefined,
           external_failure: undefined,
@@ -461,7 +436,5 @@ fee: undefined,
           out_payment: 2,
-          timeout: height + 43,
           tokens: 100,
         },
         {
-          cltv_delta: undefined,
           external_failure: undefined,
@@ -480,3 +453,2 @@ fee: undefined,
           out_payment: 2,
-          timeout: undefined,
           tokens: undefined,
@@ -489,3 +461,2 @@ },
         {
-          cltv_delta: 40,
           external_failure: undefined,
@@ -504,7 +475,5 @@ fee: 1,
           out_payment: 0,
-          timeout: height + 43,
           tokens: 100,
         },
         {
-          cltv_delta: undefined,
           external_failure: undefined,
@@ -523,7 +492,5 @@ fee: undefined,
           out_payment: 0,
-          timeout: undefined,
           tokens: undefined,
         },
         {
-          cltv_delta: 40,
           external_failure: 'TEMPORARY_CHANNEL_FAILURE',
@@ -542,7 +509,5 @@ fee: 1,
           out_payment: 0,
-          timeout: height + 43,
           tokens: 496430,
         },
         {
-          cltv_delta: undefined,
           external_failure: 'INCORRECT_OR_UNKNOWN_PAYMENT_DETAILS',
@@ -561,3 +526,2 @@ fee: undefined,
           out_payment: undefined,
-          timeout: undefined,
           tokens: undefined,
@@ -570,3 +534,2 @@ },
         {
-          cltv_delta: undefined,
           external_failure: undefined,
@@ -585,3 +548,2 @@ fee: undefined,
           out_payment: undefined,
-          timeout: undefined,
           tokens: undefined,
@@ -588,0 +550,0 @@ },

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Worsened metrics

Total package byte prevSize

779973

decreased by-0.14%

Lines of code

13333

decreased by-0.23%

Dependency changes

• + Added@types/node@18.15.13(transitive)

• + Addedlightning@9.0.0(transitive)

• - Removed@types/node@18.15.11(transitive)

• - Removedlightning@8.0.0(transitive)

• Updatedlightning@9.0.0