markov-strings - npm Package Compare versions

Comparing version 0.0.3 to 0.1.0

index.js

@@ -17,3 +17,4 @@ 'use strict';
       maxWords : 0,
-      minScore : 0
+      minScore : 0,
+      maxTries : 10000
     };
@@ -74,3 +75,3 @@
     let corpus = _.cloneDeep(this.corpus);
-    const max = 10000;
+    const max = options.maxTries;
 
@@ -77,0 +78,0 @@ // Loop for maximum tries

package.json

 {
   "name": "markov-strings",
-  "version": "0.0.3",
+  "version": "0.1.0",
   "description": "A Markov string generator",
@@ -5,0 +5,0 @@ "main": "index.js",

test/test.js

@@ -107,38 +107,39 @@ 'use strict';
 
-  it('should reject all sentences', function() {
-    let options = {minWords:5};
-    for (let i = 0; i < 10; i++) {
-      expect(() => {
-        generator.generateSentence(options, result => result.split(' ').length < 5)
-      }).to.throw(Error);
-    }
+  it('should reject the sentence', function() {
+    let options = {minWords: 5, maxTries: 10};
+    expect(() => {
+      generator.generateSentence(options, result => result.split(' ').length < 5)
+    }).to.throw(Error);
   });
 
-  it('should accept all sentences', function() {
-    for (let i = 0; i < 10; i++) {
-      expect(() => {
-        generator.generateSentence({}, result => true)
-      }).to.exist;
-    }
+  it('should accept the sentence', function() {
+    expect(() => {
+      generator.generateSentence({}, result => true)
+    }).to.exist;
   });
 
-  it('should reject if the options values are not met', function() {
+  it('should reject because maxLength is unattainable', function() {
     expect(() => {
-      generator.generateSentence({maxLength:1, minWords:0, maxWords:0})
+      generator.generateSentence({maxTries: 10, maxLength: 1, minWords: 0, maxWords: 0})
     }).to.throw(Error);
+  });
 
+  it('should reject because minWords is unattainable', function() {
     expect(() => {
-      generator.generateSentence({minWords:100})
+      generator.generateSentence({maxTries: 10, minWords: 100})
     }).to.throw(Error);
+  });
 
+  it('should reject because minScore is unattainable', function() {
     expect(() => {
-      generator.generateSentence({minScore: 20})
+      generator.generateSentence({maxTries: 10, minScore: 20})
     }).to.throw(Error);
+  });
 
+  it('should reject because maxWords is unattainable', function() {
     expect(() => {
-      generator.generateSentence({maxWords: 1, minWords:0})
+      generator.generateSentence({maxTries: 10, maxWords: 1, minWords: 0})
     }).to.throw(Error);
-
   });
 
 });

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

13085

increased by1.85%

Lines of code

221

increased by1.38%

No dependency changes