maximize-iterator - npm Package Compare versions

Comparing version 2.6.0 to 2.6.1

index.js

 var nextCallback = require('iterator-next-callback');
-var nextTick = require('next-tick');
 
@@ -10,3 +9,3 @@ var createProcessor = require('./lib/createProcessor');
 
-module.exports = function maximizeIterator(iterator, fn, options, callback, skipNextTick) {
+module.exports = function maximizeIterator(iterator, fn, options, callback) {
   if (typeof fn !== 'function') throw new Error('Missing each function');
@@ -41,3 +40,3 @@ if (typeof options === 'function') {
       processor = null;
-      skipNextTick ? callback(err) : nextTick(err ? callback.bind(null, err) : callback);
+      return callback(err);
     });
@@ -47,13 +46,7 @@ processor();
     return new Promise(function (resolve, reject) {
-      maximizeIterator(
-        iterator,
-        fn,
-        options,
-        function (err) {
-          err ? reject(err) : resolve();
-        },
-        true
-      );
+      maximizeIterator(iterator, fn, options, function (err) {
+        err ? reject(err) : resolve();
+      });
     });
   }
 };

lib/createProcessor.js

@@ -16,4 +16,5 @@ var compat = require('async-compat');
   options.counter--;
-  if ((err && compat.defaultValue(options.error(err), false)) || (!err && !compat.defaultValue(keep, true))) {
-    // mark this iteration done
+
+  // mark this iteration done
+  if ((err && !options.done && compat.defaultValue(options.error(err), false)) || (!err && !compat.defaultValue(keep, true))) {
     options.err = options.err || err;
@@ -20,0 +21,0 @@ options.done = true;

package.json

 {
   "name": "maximize-iterator",
-  "version": "2.6.0",
+  "version": "2.6.1",
   "description": "Maximize the parallel calls of an iterator supporting asyncIterator interface",
@@ -32,3 +32,2 @@ "main": "index.js",
     "async-compat": "^1.4.0",
-    "next-tick": "^1.1.0",
     "iterator-next-callback": "^1.1.0"
@@ -35,0 +34,0 @@ },

No alert changes

Improved metrics

Dependency count

2

-33.33%

Worsened metrics

Total package byte prevSize

6510

-2.72%

Lines of code

90

-7.22%

Dependency changes

• - Removed

  next-tick@^1.1.0

• - Removed

  next-tick@1.1.0
  (transitive)