mobx-rest-jquery-adapter - npm Package Compare versions

Comparing version 1.0.5 to 1.0.6

lib/utils.js

+'use strict';
+
+Object.defineProperty(exports, "__esModule", {
+  value: true
+});
+exports.buildFormData = buildFormData;
+
+var _lodash = require('lodash');
+
+function arrayHasFile(arr) {
+  return !!arr.find(function (val) {
+    return val instanceof File;
+  });
+}
+function buildFormData(data) {
+  var formData = new FormData();
+  var hasFile = false;
+
+  (0, _lodash.forEach)(data, function (val, attr) {
+    hasFile = hasFile || val instanceof File;
+
+    if ((0, _lodash.isArray)(val)) {
+      hasFile = hasFile || arrayHasFile(val);
+      return formData.append(attr + '[]', val);
+    }
+
+    if (!(0, _lodash.isNull)(val)) formData.append(attr, val);
+  });
+
+  return { hasFile: hasFile, formData: formData };
+}

__tests__/adapter.spec.js

@@ -185,2 +185,29 @@ import adapter from '../src'
     })
+
+    describe('when it contains an array of files', () => {
+      const values = [{ id: 1, avatar: 'lol.png' }]
+
+      beforeEach(() => {
+        data = { files: [new File([''], 'filename')] }
+        injectDone(values)
+        action()
+      })
+
+      it('sends a xhr request with data parameters', () => {
+        expect(ret.abort).toBeTruthy()
+
+        return ret.promise.then((vals) => {
+          const res = jq.ajax.mock.calls[0][1]
+
+          expect(vals).toEqual(values)
+          expect(jq.ajax.mock.calls[0][0]).toBe('/api/users')
+          expect(res.cache).toBe(false)
+          expect(res.contentType).toBe(false)
+          expect(res.data).toBeTruthy()
+          expect(res.method).toBe('POST')
+          expect(res.processData).toBe(false)
+          expect(res.xhr).toBeTruthy()
+        })
+      })
+    })
   })
@@ -187,0 +214,0 @@

lib/index.js

@@ -11,2 +11,4 @@ 'use strict';
 
+var _utils = require('./utils');
+
 var _lodash = require('lodash');
@@ -32,2 +34,3 @@
 
+
 function ajaxOptions(options) {
@@ -42,14 +45,8 @@ if (options.method === 'GET') {
 
-  var formData = new FormData();
-  var hasFile = false;
+  var _buildFormData = (0, _utils.buildFormData)(options.data),
+      hasFile = _buildFormData.hasFile,
+      formData = _buildFormData.formData;
 
-  (0, _lodash.forEach)(options.data, function (val, attr) {
-    hasFile = hasFile || val instanceof File;
-    if (!(0, _lodash.isNull)(val)) formData.append(attr, val);
-  });
+  var baseOptions = { method: options.method };
 
-  var baseOptions = {
-    method: options.method
-  };
-
   if (hasFile) {
@@ -56,0 +53,0 @@ return Object.assign({}, baseOptions, {

package.json

 {
   "name": "mobx-rest-jquery-adapter",
-  "version": "1.0.5",
+  "version": "1.0.6",
   "description": "jQuery adapter for mobx-rest",
@@ -28,3 +28,3 @@ "repository": {
     "jquery": "3.4.0",
-    "lodash": "4.17.11"
+    "lodash": "4.17.13"
   },
@@ -31,0 +31,0 @@ "devDependencies": {

Fixed alerts

New author

Supply chain risk

A new npm collaborator published a version of the package for the first time. New collaborators are usually benign additions to a project, but do indicate a change to the security surface area of a package.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

381990

0.35%

Number of package files

13

8.33%

Lines of code

7424

0.56%

Number of medium supply chain risk alerts

0

-100%

Dependency changes

• + Added

  lodash@4.17.13
  (transitive)

• - Removed

  lodash@4.17.11
  (transitive)

• Updated

  lodash@4.17.13