mongoskin - npm Package Compare versions

Comparing version 0.3.3 to 0.3.4

examples/gridfs.js

@@ -8,3 +8,3 @@ var db = require('./config').db;
                 gs.read(function(err, reply){
-                    console.log(reply);
+                    console.log(reply.toString());
                 });
@@ -11,0 +11,0 @@ });

History.md

@@ -0,1 +1,4 @@
+0.3.4 / 2011-03-24
+ * fix global leaks
+
 0.3.3 / 2011-03-15
@@ -2,0 +5,0 @@ ==================

lib/mongoskin/admin.js

@@ -1,2 +0,3 @@
-var Admin = require('mongodb').Admin;
+var Admin = require('mongodb').Admin
+  , utils = require('./utils');
 
@@ -13,3 +14,3 @@ var SkinAdmin = exports.SkinAdmin = function(skinDb) {
       if (err) {
-        args[args.length - 1](err);
+        utils.error(err, args, 'SkinAdmin.' + name);
       } else {
@@ -16,0 +17,0 @@ method.apply(this.nativeAdmin, args);

lib/mongoskin/collection.js

@@ -32,2 +32,3 @@ /**
     SkinCursor = require('./cursor').SkinCursor,
+    utils = require('./utils'),
     STATE_CLOSE = 0,
@@ -73,3 +74,3 @@ STATE_OPENNING = 1,
       if (err) {
-        args[args.length - 1](err);
+        utils.error(err, args, 'SkinCollection.' + name);
       } else {
@@ -76,0 +77,0 @@ method.apply(collection, args);

lib/mongoskin/cursor.js

 var __slice = Array.prototype.slice,
     events = require('events'),
     Cursor = require('mongodb').Cursor,
+    utils = require('./utils'),
     STATE_CLOSE = 0,
@@ -57,3 +58,3 @@ STATE_OPENNING = 1,
       if (err) {
-        args[args.length - 1](err);
+        utils.error(err, args, 'SkinCursor.' + name);
       } else {
@@ -60,0 +61,0 @@ method.apply(cursor, args);

lib/mongoskin/db.js

 var __slice = Array.prototype.slice,
     mongodb = require('mongodb'),
     events = require('events'),
+    utils = require('./utils'),
     SkinAdmin = require('./admin').SkinAdmin,
@@ -188,3 +189,3 @@ SkinCollection = require('./collection').SkinCollection,
       if (err) {
-        return args[args.length - 1](err);
+        utils.error(err, args, 'SkinDb.' + name);
       } else {
@@ -191,0 +192,0 @@ return method.apply(db, args);

lib/mongoskin/gridfs.js

@@ -11,12 +11,14 @@ var GridStore = require('mongodb').GridStore;
 /**
- * @param filename: filename or ObjectId
+ * @param id
+ * @param filename
+ * @param mode
+ * @param options
+ * @param callback
  *  callback(err, gridStoreObject)
  */
-SkinGridStore.prototype.open = function(filename, mode, options, callback){
-  if(!callback){
-    callback = options;
-    options = undefined;
-  }
+SkinGridStore.prototype.open = function(id, filename, mode, options, callback){
+  var args = Array.prototype.slice.call(arguments);
+  var callback = args.pop();
   this.skinDb.open(function(err, db) {
-      new GridStore(db, filename, mode, options).open(callback);
+      new GridStore(db, args[0], args[1], args[2], args[3]).open(callback);
   });
@@ -23,0 +25,0 @@ }

lib/mongoskin/index.js

@@ -8,3 +8,3 @@ var url = require('url'),
     Server = mongo.Server,
-    ReplSetServers = mongo.ReplSetServers
+    ReplSetServers = mongo.ReplSetServers,
     BSONNative = mongo.BSONNative,
@@ -11,0 +11,0 @@ DEFAULT_PORT = 27017;

package.json

 {
   "name": "mongoskin",
   "description": "The future layer above node-mongodb-native",
-  "version": "0.3.3",
+  "version": "0.3.4",
   "author": "Jason Green <[e-mail]>",
@@ -22,3 +22,3 @@ "repository": {
   "dependencies": {
-    "mongodb": ">=0.9.7-3"
+    "mongodb": ">=0.9.9-7"
   },
@@ -25,0 +25,0 @@ "devDependencies": {

No alert changes

Improved metrics

Total package byte prevSize

47027

1.16%

Number of package files

22

4.76%

Lines of code

1018

1.39%

Dependency changes

• Updated

  mongodb@>=0.9.9-7