nock - npm Package Compare versions

Comparing version 0.13.2 to 0.13.3

lib/request_overrider.js

@@ -173,14 +173,16 @@ var IncomingMessage = require('http').IncomingMessage;
 
-    next.push(function() {
-      if (encoding) {
-        if (isStream(responseBody)) {
-          responseBody.setEncoding(encoding);
-        } else {
-          responseBody = responseBody.toString(encoding);
+    if (typeof responseBody !== "undefined") {
+      next.push(function() {
+        if (encoding) {
+          if (isStream(responseBody)) {
+            responseBody.setEncoding(encoding);
+          } else {
+            responseBody = responseBody.toString(encoding);
+          }
         }
-      }
-      if (! isStream(responseBody)) {
-        response.emit('data', responseBody);
-      }
-    });
+        if (! isStream(responseBody)) {
+          response.emit('data', responseBody);
+        }
+      });
+    }
 
@@ -187,0 +189,0 @@ if (! isStream(responseBody)) {

package.json

 { "name" : "nock"
 , "description" : "HTTP Server mocking for Node.js"
 , "tags" : ["Mock", "HTTP", "testing", "isolation"]
-, "version" : "0.13.2"
+, "version" : "0.13.3"
 , "author" : "Pedro Teixeira <[e-mail]>"
@@ -6,0 +6,0 @@ , "contributors" :

tests/test_intercept.js

@@ -113,7 +113,5 @@ var nock    = require('../.')
 tap.test("post with empty response body", function(t) {
-  var dataCalled = false;
-  
   var scope = nock('http://www.google.com')
      .post('/form')
-     .reply(201, "OK!");
+     .reply(200);
 
@@ -127,5 +125,4 @@ var req = http.request({
 
-     t.equal(res.statusCode, 201);
+     t.equal(res.statusCode, 200);
      res.on('end', function() {
-       t.ok(dataCalled);
        scope.done();
@@ -135,5 +132,3 @@ t.end();
      res.on('data', function(data) {
-       dataCalled = true;
-       t.ok(data instanceof Buffer, "data should be buffer");
-       t.equal(data.toString(), "OK!", "response should match");
+       t.fail("No body should be returned")
      });
@@ -140,0 +135,0 @@

No alert changes

Worsened metrics

Total package byte prevSize

66309

decreased by-0.14%

Lines of code

1914

decreased by-0.1%

No dependency changes