node-gyp - npm Package Compare versions

Comparing version 0.1.2 to 0.1.3

lib/build.js

@@ -88,4 +88,4 @@
       // Don't overwrite an existing Makefile
-      argv.push('-f');
-      argv.push('Makefile.gyp');
+      argv.push('-f')
+      argv.push('Makefile.gyp')
     }
@@ -92,0 +92,0 @@

lib/install.js

 
 module.exports = exports = install
 
-exports.usage = 'Install node development files for the specified node version'
+exports.usage = 'Install node development files for the specified node version.  Respects http_proxy/HTTP_PROXY and --proxy=<proxyurl> when downloading.'
 
@@ -99,3 +99,10 @@ /**
 
-    request(tarballUrl, downloadError)
+    var requestOpts = { uri: tarballUrl }
+    var proxyUrl = gyp.opts.proxy || process.env.http_proxy || process.env.HTTP_PROXY
+    if (proxyUrl) {
+      gyp.verbose('using proxy:', proxyUrl)
+      requestOpts.proxy = proxyUrl
+    }
+
+    request(requestOpts, downloadError)
       .pipe(zlib.createGunzip())
@@ -102,0 +109,0 @@ .pipe(parser)

lib/node-gyp.js

@@ -66,2 +66,3 @@
   , solution: String // 'build' (windows only)
+  , proxy: String // 'install'
 }
@@ -68,0 +69,0 @@

lib/util/node_version.js

@@ -8,3 +8,3 @@
 
-var regexp = /^(\d+)\.(\d+)/
+var regexp = /(\d+)\.(\d+)/
 
@@ -17,7 +17,3 @@ /**
 exports.parse = function parse (str) {
-  str = String(str)
-  if (str[0] === 'v') {
-    str = str.substring(1)
-  }
-  var m = str.match(regexp)
+  var m = String(str).match(regexp)
   return m ? m[0] : null
@@ -24,0 +20,0 @@ }

package.json

 { "name": "node-gyp"
 , "description": "Node.js native addon build tool"
 , "keywords": [ "native", "addon", "module", "c", "c++", "bindings", "gyp" ]
-, "version": "0.1.2"
+, "version": "0.1.3"
 , "author": "Nathan Rajlich <[e-mail]> (http://tootallnate.net)"
@@ -6,0 +6,0 @@ , "repository": { "type": "git", "url": "git://github.com/TooTallNate/node-gyp.git" }

README.md

@@ -126,3 +126,3 @@ node-gyp
  * `copy` - Copies a compiled bindings to an appropriate dir for runtime detection
- * `install` - Installs node development files for the given version
+ * `install` - Installs node development files for the given version.  Respects http_proxy/HTTP_PROXY and --proxy=<proxyurl> when downloading.
  * `list` - Lists the currently installed node development file versions
@@ -129,0 +129,0 @@ * `remove` - Removes a node development files for a given version

New alerts

Environment variable access

Supply chain risk

Package accesses environment variables, which may be a sign of credential stuffing or data theft.

Found 2 instances in 1 package

Improved metrics

Total package byte prevSize

47676

increased by0.73%

Lines of code

1068

increased by0.28%

Worsened metrics

Number of low supply chain risk alerts

18

increased by12.5%

No dependency changes