nodejs-file-downloader - npm Package Compare versions

Comparing version 4.5.0 to 4.5.1

Download.js

@@ -103,6 +103,6 @@ const fs = require('fs');
                 if (this.config.onResponse) {
-
+                    // debugger
                     const shouldContinue = await this.config.onResponse(response);
                     if (shouldContinue === false) {
-                        resolve();
+                       return resolve();
                     }
@@ -126,3 +126,3 @@ }
 
-        this.wrapperPromise = prom;
+        // this.wrapperPromise = prom;
 
@@ -129,0 +129,0 @@

Downloader.test.js

@@ -863,2 +863,82 @@
 
+    it('Should use shouldCotinue to stop download', async function () {
+
+        // const stream = fs.createReadStream(Path.join(__dirname, 'fixtures/Koala.jpg'));
+        // mock.onGet("/koala.jpg").reply(function (config) {
+        //     return [
+        //         200,
+        //         stream,
+        //         {'message':'do not terminate'}
+        //     ];
+        // });
+        // debugger
+        // fs.unlinkSync('./downloads/Koala.jpg')
+        // debugger
+        const host = randomHost()
+        nock(`http://www.${host}.com`)
+            .get('/Koala.jpg')
+            .reply(200, (uri, requestBody) => {
+                // debugger
+                // console.log('YOYO')
+                return fs.createReadStream(Path.join(__dirname, 'fixtures/Koala.jpg'))
+                //   fs.readFile(Path.join(__dirname, 'fixtures/Desert.jpg'), cb) // Error-first callback
+            }, { 'message': 'terminate' }).persist()
+
+
+        const downloader = new Downloader({
+            timeout: 1000,
+            // debugMode:true,
+            maxAttempts: 4,
+            onResponse: function (response) {
+                if (response.headers['message'] === 'terminate') {
+                    // return true
+                    // debugger;
+                    return false
+
+                }
+                // debugger
+                return false;
+            },
+            fileName: 'yoyo.jpg',
+            url: `http://www.${host}.com/Koala.jpg`,
+            directory: "./downloads",
+
+        })
+
+
+
+        // debugger;
+        // try {
+        try {
+            const prom = await downloader.download();
+            debugger
+            await verifyFile('./downloads/yoyo.jpg', 29051);
+            debugger
+        } catch (error) {
+            debugger
+            if(!error.code === 'ENOENT'){
+                throw error;
+            }
+            // console.log('error reached')
+            debugger
+        }
+        // finally {
+        //     debugger
+        //     // console.log('finally reached')
+        //     // await verifyFile('./downloads/yoyo.jpg', 29051);
+        // }
+
+        // } catch (error) {
+        // debugger
+        // return;
+        // }  
+
+        // throw new Error();
+
+
+
+
+
+    })
+
     it('Should get ERR_REQUEST_CANCELLED error after cancellation, while streaming', async function () {
@@ -865,0 +945,0 @@

package.json

 {
   "name": "nodejs-file-downloader",
-  "version": "4.5.0",
+  "version": "4.5.1",
   "description": "A file downloader for NodeJs",
@@ -5,0 +5,0 @@ "main": "Downloader.js",

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

181626

increased by1.31%

Lines of code

1930

increased by3.49%

No dependency changes