on-load - npm Package Compare versions

Comparing version 3.4.1 to 4.0.0

CHANGELOG.md

@@ -5,2 +5,6 @@ # on-load Change Log
 
+## 4.0.0 - 2018-08-10
+* Only load/unload nodes if `document.documentElement.contains(node)` - ([#35](https://github.com/shama/on-load/pull/35))
+* Switch from testron to tape-run.
+
 ## 3.4.1 - 2018-06-28
@@ -7,0 +11,0 @@ * Tweak browser export definition format

index.js

@@ -18,23 +18,13 @@ /* global MutationObserver */
       }
-      eachMutation(mutations[i].removedNodes, turnoff)
-      eachMutation(mutations[i].addedNodes, turnon)
+      eachMutation(mutations[i].removedNodes, function (index, el) {
+        if (!document.documentElement.contains(el)) turnoff(index, el)
+      })
+      eachMutation(mutations[i].addedNodes, function (index, el) {
+        if (document.documentElement.contains(el)) turnon(index, el)
+      })
     }
   })
-  if (document.body) {
-    beginObserve(observer)
-  } else {
-    document.addEventListener('DOMContentLoaded', function (event) {
-      beginObserve(observer)
-    })
-  }
-}
 
-function beginObserve (observer) {
-  observer.observe(document.documentElement, {
-    childList: true,
-    subtree: true,
-    attributes: true,
-    attributeOldValue: true,
-    attributeFilter: [KEY_ATTR]
-  })
+  if (document.readyState === 'complete') startObserving(observer)()
+  else document.addEventListener('DOMContentLoaded', startObserving(observer))
 }
@@ -55,2 +45,14 @@
 
+function startObserving (obs) {
+  return function () {
+    obs.observe(document.body, {
+      childList: true,
+      subtree: true,
+      attributes: true,
+      attributeOldValue: true,
+      attributeFilter: [KEY_ATTR]
+    })
+  }
+}
+
 function turnon (index, el) {
@@ -100,3 +102,3 @@ if (watch[index][0] && watch[index][2] === 0) {
     }
-    if (nodes[i].childNodes.length > 0) {
+    if (nodes[i] && nodes[i].childNodes.length > 0) {
       eachMutation(nodes[i].childNodes, fn)
@@ -103,0 +105,0 @@ }

package.json

 {
   "name": "on-load",
-  "version": "3.4.1",
+  "version": "4.0.0",
   "description": "On load/unload events for DOM elements using a MutationObserver",
@@ -12,3 +12,3 @@ "main": "server.js",
     "start": "wzrd test.js:bundle.js",
-    "test": "standard && browserify test.js | testron"
+    "test": "standard && browserify test.js | tape-run"
   },
@@ -41,7 +41,6 @@ "repository": {
   "devDependencies": {
-    "browserify": "^14.5.0",
-    "electron-prebuilt": "^0.36.9",
-    "standard": "^10.0.3",
+    "browserify": "^16.2.2",
+    "standard": "^11.0.1",
     "tape": "^4.6.0",
-    "testron": "lachenmayer/testron#fs-unlink-error",
+    "tape-run": "^4.0.0",
     "wzrd": "^1.4.0",
@@ -48,0 +47,0 @@ "yo-yo": "^1.2.1"

No alert changes

Improved metrics

Total package byte prevSize

6577

5.06%

Dev dependency count

6

-14.29%

Lines of code

103

0.98%

No dependency changes