open-in-editor - npm Package Compare versions

Comparing version 2.0.0 to 2.1.0

HISTORY.md

@@ -0,1 +1,6 @@
+## 2.1.0 (March 21, 2017)
+
+- Added basic support for `emacs` (thanks to @zefirka)
+- Fixed crash on attempt to use `vim` on non-`darwin` platform
+
 ## 2.0.0 (March 15, 2017)
@@ -13,3 +18,3 @@
 
-- Added support for JetBrain's IDEs on Windows (thanks to @Mavrin)
+- Added support for JetBrains's IDEs on Windows (thanks to @Mavrin)
 
@@ -16,0 +21,0 @@ ## 1.1.0 (November 8, 2015)

lib/detect.js

@@ -32,1 +32,11 @@ var check = require('./check');
 };
+module.exports.platformSupport = function(platforms, editor) {
+  return function() {
+    // we use only system parts so we haven't to check anything except os
+    if (platforms.indexOf(process.platform) !== -1) {
+      return Promise.resolve();
+    }
+
+    return Promise.reject('"Open in ' + editor + '" does not implemented for your platform (' + process.platform + ')');
+  };
+};

lib/editors/idea14ce.js

@@ -1,4 +0,4 @@
-var ide = require('./jetbrains-ide');
+var jetbrains = require('./common/jetbrains');
 
-var detect = ide.detect({
+var detect = jetbrains.detect({
   appFolder: 'IntelliJ IDEA 14 CE',
@@ -8,8 +8,8 @@ name: 'IDEA 14 CE',
 });
-var open = require('../open').detectAndOpenFactory(detect, ide.settings);
+var open = require('../open').detectAndOpenFactory(detect, jetbrains.settings);
 
 module.exports = {
-  settings: ide.settings,
+  settings: jetbrains.settings,
   detect: detect,
   open: open
 };

lib/editors/index.js

@@ -9,3 +9,4 @@ module.exports = {
   vim: require('./vim'),
-  visualstudio: require('./visualstudio')
+  visualstudio: require('./visualstudio'),
+  emacs: require('./emacs')
 };

lib/editors/phpstorm.js

@@ -1,4 +0,4 @@
-var ide = require('./jetbrains-ide');
+var jetbrains = require('./common/jetbrains');
 
-var detect = ide.detect({
+var detect = jetbrains.detect({
   appFolder: 'PhpStorm',
@@ -8,8 +8,8 @@ name: 'PhpStorm IDE',
 });
-var open = require('../open').detectAndOpenFactory(detect, ide.settings);
+var open = require('../open').detectAndOpenFactory(detect, jetbrains.settings);
 
 module.exports = {
-  settings: ide.settings,
+  settings: jetbrains.settings,
   detect: detect,
   open: open
 };

lib/editors/vim.js

@@ -1,29 +0,10 @@
-var osascript = function(script) {
-  return 'osascript -e \'' + script + '\'';
-};
+var runInTerminal = require('../common/terminal');
 
-var terminal = function(cmd) {
-  return 'tell application "Terminal" to do script "' + cmd + '"';
-};
-
 var settings = {
   patternOnly: true,
   escapeQuotes: true,
-  pattern: osascript(
-    terminal(
-      'cd {projectPath};' +
-      'vim {filename} \\"+call cursor({line}, {column})\\"'
-    )
-  )
+  pattern: runInTerminal('vim {filename} \\"+call cursor({line}, {column})\\"')
 };
 
-var detect = function() {
-  // we use only system parts so we haven't to check anything except os
-  if (process.platform === 'darwin') {
-    return Promise.resolve();
-  }
-
-  Promise.reject('"Open in vim" does not implemented for your platform (' + process.platform + ')');
-};
-
+var detect = require('../detect').platformSupport(['darwin'], 'vim');
 var open = require('../open').detectAndOpenFactory(detect, settings);
@@ -30,0 +11,0 @@

lib/editors/webstorm.js

@@ -1,4 +0,4 @@
-var ide = require('./jetbrains-ide');
+var jetbrains = require('./common/jetbrains');
 
-var detect = ide.detect({
+var detect = jetbrains.detect({
   appFolder: 'WebStorm',
@@ -8,8 +8,8 @@ name: 'WebStorm IDE',
 });
-var open = require('../open').detectAndOpenFactory(detect, ide.settings);
+var open = require('../open').detectAndOpenFactory(detect, jetbrains.settings);
 
 module.exports = {
-  settings: ide.settings,
+  settings: jetbrains.settings,
   detect: detect,
   open: open
 };

package.json

 {
   "name": "open-in-editor",
   "description": "Open file in editor",
-  "version": "2.0.0",
+  "version": "2.1.0",
   "author": "Roman Dvornov <[e-mail]>",
@@ -14,6 +14,10 @@ "license": "MIT",
     "code",
+    "vscode",
     "idea",
     "phpstorm",
     "webstorm",
-    "sublime"
+    "sublime",
+    "visual studio",
+    "vim",
+    "emacs"
   ],
@@ -28,4 +32,4 @@ "main": "./lib/index.js",
   "dependencies": {
-    "clap": "^1.0.8",
-    "os-homedir": "1.0.1"
+    "clap": "^1.1.3",
+    "os-homedir": "~1.0.2"
   },
@@ -32,0 +36,0 @@ "devDependencies": {},

README.md

@@ -14,2 +14,3 @@ [![NPM version](https://img.shields.io/npm/v/open-in-editor.svg)](https://www.npmjs.com/package/open-in-editor)
 - [Vim](http://www.vim.org/)
+- [Emacs](https://www.gnu.org/software/emacs/)
 - [Visual Studio](https://www.visualstudio.com/)
@@ -68,3 +69,3 @@
 
-Values: `sublime`, `atom`, `code`, `webstorm`, `phpstorm`, `idea14ce`, `vim`, `visualstudio`
+Values: `sublime`, `atom`, `code`, `webstorm`, `phpstorm`, `idea14ce`, `vim`, `emacs`, `visualstudio`
 
@@ -84,2 +85,3 @@ Default: *not set*
 - `vim` – Vim (via Terminal, Mac OS only)
+- `emacs` – Emacs (via Terminal, Mac OS only)
 - `visualstudio` – Visual Studio
@@ -86,0 +88,0 @@

New alerts

Environment variable access

Supply chain risk

Package accesses environment variables, which may be a sign of credential stuffing or data theft.

Found 1 instance in 1 package

Fixed alerts

Environment variable access

Supply chain risk

Package accesses environment variables, which may be a sign of credential stuffing or data theft.

Found 4 instances in 1 package

Improved metrics

Total package byte prevSize

27765

increased by4.45%

Number of package files

27

increased by8%

Lines of code

415

increased by4.53%

Number of lines in readme file

180

increased by1.12%

Worsened metrics

Number of low supply chain risk alerts

14

increased by75%

Dependency changes

• + Addedos-homedir@1.0.2(transitive)

• - Removedos-homedir@1.0.1(transitive)

• Updatedclap@^1.1.3

• Updatedos-homedir@~1.0.2