oribella-tap - npm Package Compare versions

Comparing version 0.3.7 to 0.4.0

CHANGELOG.md

@@ -0,3 +1,9 @@
+<a name="0.4.0"></a>
+# 0.4.0 (2016-02-22)
+
+
+
+
 <a name="0.3.7"></a>
-## [0.3.7](https://github.com/oribella/tap/compare/v0.3.6...v0.3.7) (2015-12-19)
+## 0.3.7 (2015-12-19)
 
@@ -8,3 +14,3 @@
 <a name="0.3.6"></a>
-## [0.3.6](https://github.com/oribella/tap/compare/v0.3.5...v0.3.6) (2015-12-13)
+## [0.3.6](https://github.com/oribella/tap/compare/4b39a50...v0.3.6) (2015-12-13)
 
@@ -19,3 +25,3 @@
 <a name="0.3.5"></a>
-## [0.3.5](https://github.com/oribella/tap/compare/v0.3.4...v0.3.5) (2015-12-11)
+## [0.3.5](https://github.com/oribella/tap/compare/b1ff6cc...v0.3.5) (2015-12-11)
 
@@ -30,3 +36,3 @@
 <a name="0.3.4"></a>
-## [0.3.4](https://github.com/oribella/tap/compare/v0.3.3...v0.3.4) (2015-12-11)
+## [0.3.4](https://github.com/oribella/tap/compare/cc53efd...v0.3.4) (2015-12-11)
 
@@ -41,3 +47,3 @@
 <a name="0.3.3"></a>
-## [0.3.3](https://github.com/oribella/tap/compare/v0.3.2...v0.3.3) (2015-12-11)
+## [0.3.3](https://github.com/oribella/tap/compare/a175995...v0.3.3) (2015-12-11)
 
@@ -52,3 +58,3 @@
 <a name="0.3.2"></a>
-## [0.3.2](https://github.com/oribella/tap/compare/v0.3.1...v0.3.2) (2015-12-10)
+## 0.3.2 (2015-12-10)
 
@@ -59,3 +65,3 @@
 <a name="0.3.1"></a>
-## [0.3.1](https://github.com/oribella/tap/compare/v0.3.0...v0.3.1) (2015-12-10)
+## [0.3.1](https://github.com/oribella/tap/compare/dd48890...v0.3.1) (2015-12-10)
 
@@ -70,3 +76,3 @@
 <a name="0.3.0"></a>
-# [0.3.0](https://github.com/oribella/tap/compare/v0.2.0...v0.3.0) (2015-12-10)
+# [0.3.0](https://github.com/oribella/tap/compare/e335bd3...v0.3.0) (2015-12-10)
 
@@ -81,3 +87,3 @@
 <a name="0.2.0"></a>
-# [0.2.0](https://github.com/oribella/tap/compare/0.1.0...v0.2.0) (2015-08-15)
+# [0.2.0](https://github.com/oribella/tap/compare/1da3f68...v0.2.0) (2015-08-15)
 
@@ -84,0 +90,0 @@

dist/amd/index.js

@@ -37,5 +37,5 @@ define(["exports", "oribella-framework"], function (exports, _oribellaFramework) {
       key: "start",
-      value: function start(event, pagePoints) {
-        this.startPoint = pagePoints[0];
-        this.data.pagePoints = pagePoints;
+      value: function start(event, pointers) {
+        this.data = pointers;
+        this.startPoint = pointers.pagePoints[0];
         this.result = this.subscriber.start(event, this.data, this.element);
@@ -46,11 +46,12 @@ return _oribellaFramework.RETURN_FLAG.map(this.result) + _oribellaFramework.RETURN_FLAG.STARTED;
       key: "update",
-      value: function update(event, pagePoints) {
-        if (pagePoints[0].distanceTo(this.startPoint) > this.subscriber.options.radiusThreshold) {
+      value: function update(event, pointers) {
+        if (pointers.pagePoints[0].distanceTo(this.startPoint) > this.subscriber.options.radiusThreshold) {
           return _oribellaFramework.RETURN_FLAG.REMOVE;
         }
+        return undefined;
       }
     }, {
       key: "end",
-      value: function end(event, pagePoints) {
-        this.data.pagePoints = pagePoints;
+      value: function end(event, pointers) {
+        this.data = pointers;
         this.result = this.subscriber.end(event, this.data, this.element);
@@ -61,4 +62,4 @@ return _oribellaFramework.RETURN_FLAG.map(this.result);
       key: "cancel",
-      value: function cancel(event, pagePoints) {
-        this.data.pagePoints = pagePoints;
+      value: function cancel(event, pointers) {
+        this.data = pointers;
         this.subscriber.cancel(event, this.data, this.element);
@@ -65,0 +66,0 @@ }

dist/commonjs/index.js

@@ -38,5 +38,5 @@ "use strict";
     key: "start",
-    value: function start(event, pagePoints) {
-      this.startPoint = pagePoints[0];
-      this.data.pagePoints = pagePoints;
+    value: function start(event, pointers) {
+      this.data = pointers;
+      this.startPoint = pointers.pagePoints[0];
       this.result = this.subscriber.start(event, this.data, this.element);
@@ -47,11 +47,12 @@ return _oribellaFramework.RETURN_FLAG.map(this.result) + _oribellaFramework.RETURN_FLAG.STARTED;
     key: "update",
-    value: function update(event, pagePoints) {
-      if (pagePoints[0].distanceTo(this.startPoint) > this.subscriber.options.radiusThreshold) {
+    value: function update(event, pointers) {
+      if (pointers.pagePoints[0].distanceTo(this.startPoint) > this.subscriber.options.radiusThreshold) {
         return _oribellaFramework.RETURN_FLAG.REMOVE;
       }
+      return undefined;
     }
   }, {
     key: "end",
-    value: function end(event, pagePoints) {
-      this.data.pagePoints = pagePoints;
+    value: function end(event, pointers) {
+      this.data = pointers;
       this.result = this.subscriber.end(event, this.data, this.element);
@@ -62,4 +63,4 @@ return _oribellaFramework.RETURN_FLAG.map(this.result);
     key: "cancel",
-    value: function cancel(event, pagePoints) {
-      this.data.pagePoints = pagePoints;
+    value: function cancel(event, pointers) {
+      this.data = pointers;
       this.subscriber.cancel(event, this.data, this.element);
@@ -66,0 +67,0 @@ }

dist/systemjs/index.js

@@ -40,5 +40,5 @@ System.register(["oribella-framework"], function (_export) {
           key: "start",
-          value: function start(event, pagePoints) {
-            this.startPoint = pagePoints[0];
-            this.data.pagePoints = pagePoints;
+          value: function start(event, pointers) {
+            this.data = pointers;
+            this.startPoint = pointers.pagePoints[0];
             this.result = this.subscriber.start(event, this.data, this.element);
@@ -49,11 +49,12 @@ return RETURN_FLAG.map(this.result) + RETURN_FLAG.STARTED;
           key: "update",
-          value: function update(event, pagePoints) {
-            if (pagePoints[0].distanceTo(this.startPoint) > this.subscriber.options.radiusThreshold) {
+          value: function update(event, pointers) {
+            if (pointers.pagePoints[0].distanceTo(this.startPoint) > this.subscriber.options.radiusThreshold) {
               return RETURN_FLAG.REMOVE;
             }
+            return undefined;
           }
         }, {
           key: "end",
-          value: function end(event, pagePoints) {
-            this.data.pagePoints = pagePoints;
+          value: function end(event, pointers) {
+            this.data = pointers;
             this.result = this.subscriber.end(event, this.data, this.element);
@@ -64,4 +65,4 @@ return RETURN_FLAG.map(this.result);
           key: "cancel",
-          value: function cancel(event, pagePoints) {
-            this.data.pagePoints = pagePoints;
+          value: function cancel(event, pointers) {
+            this.data = pointers;
             this.subscriber.cancel(event, this.data, this.element);
@@ -68,0 +69,0 @@ }

package.json

 {
   "name": "oribella-tap",
-  "version": "0.3.7",
+  "version": "0.4.0",
   "description": "Tap gesture",
@@ -36,8 +36,8 @@ "license": "MIT",
   "dependencies": {
-    "oribella-framework": "^0.3.4"
+    "oribella-framework": "^0.4.0"
   },
   "devDependencies": {
     "jspm": "^0.16.15",
-    "oribella-dev": "^0.1.7"
+    "oribella-dev": "^0.1.22"
   }
 }

src/index.js

@@ -19,5 +19,5 @@ import {RETURN_FLAG} from "oribella-framework";
   }
-  start(event, pagePoints) {
-    this.startPoint = pagePoints[0];
-    this.data.pagePoints = pagePoints;
+  start(event, pointers) {
+    this.data = pointers;
+    this.startPoint = pointers.pagePoints[0];
     this.result = this.subscriber.start(event, this.data, this.element);
@@ -27,16 +27,17 @@ return RETURN_FLAG.map(this.result) +
   }
-  update(event, pagePoints) {
-    if (pagePoints[0].distanceTo(this.startPoint) > this.subscriber.options.radiusThreshold) {
+  update(event, pointers) {
+    if (pointers.pagePoints[0].distanceTo(this.startPoint) > this.subscriber.options.radiusThreshold) {
       return RETURN_FLAG.REMOVE;
     }
+    return undefined;
   }
-  end(event, pagePoints) {
-    this.data.pagePoints = pagePoints;
+  end(event, pointers) {
+    this.data = pointers;
     this.result = this.subscriber.end(event, this.data, this.element);
     return RETURN_FLAG.map(this.result);
   }
-  cancel(event, pagePoints) {
-    this.data.pagePoints = pagePoints;
+  cancel(event, pointers) {
+    this.data = pointers;
     this.subscriber.cancel(event, this.data, this.element);
   }
 }

No alert changes

Improved metrics

Lines of code

289

1.4%

Worsened metrics

Total package byte prevSize

14671

-0.52%

Dependency changes

• + Added

  oribella-framework@0.4.4
  (transitive)

• - Removed

  oribella-framework@0.3.5
  (transitive)

• Updated

  oribella-framework@^0.4.0