patternity - npm Package Compare versions

Comparing version 1.0.68 to 1.0.70-rc1

lib/accordion/accordion-body.js

@@ -36,2 +36,3 @@ "use strict";
     this.applyRealMaxHeight = function () {
+      if (!_this.props.open) return;
       var detailsHeight = _this.refs.details.getDOMNode().offsetHeight;
@@ -45,8 +46,8 @@ if (detailsHeight !== _this.state.maxHeight) _this.setState({ maxHeight: detailsHeight });
     value: function componentDidMount() {
-      this.applyRealMaxHeight();
+      this.poll = setInterval(this.applyRealMaxHeight, 200);
     }
   }, {
-    key: "componentDidUpdate",
-    value: function componentDidUpdate() {
-      this.applyRealMaxHeight();
+    key: "componentWillUnmount",
+    value: function componentWillUnmount() {
+      clearInterval(this.poll);
     }
@@ -53,0 +54,0 @@ }, {

package.json

 {
   "name": "patternity",
-  "version": "1.0.68",
+  "version": "1.0.70-rc1",
   "description": "Patternity is the pattern library and style guide for all Influitive apps",
@@ -5,0 +5,0 @@ "main": "index.js",

src/accordion/accordion-body.js

@@ -5,7 +5,7 @@ import React, { Component, PropTypes } from 'react';
   componentDidMount() {
-    this.applyRealMaxHeight();
+    this.poll = setInterval(this.applyRealMaxHeight, 200);
   }
 
-  componentDidUpdate() {
-    this.applyRealMaxHeight();
+  componentWillUnmount() {
+    clearInterval(this.poll);
   }
@@ -27,2 +27,3 @@
   applyRealMaxHeight = () => {
+    if (!this.props.open) return;
     const detailsHeight = this.refs.details.getDOMNode().offsetHeight;
@@ -29,0 +30,0 @@ if (detailsHeight !== this.state.maxHeight) this.setState({maxHeight: detailsHeight});

New alerts

No v1

Quality

Package is not semver >=1. This means it is not stable and does not support ^ ranges.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

1006621

0.01%

Lines of code

9112

0.02%

Worsened metrics

Number of low quality alerts

1

Infinity%

No dependency changes