pbxproj-dom - npm Package Compare versions

Comparing version 1.0.9 to 1.0.10

package.json

 {
   "name": "pbxproj-dom",
-  "version": "1.0.9",
+  "version": "1.0.10",
   "description": "",
@@ -5,0 +5,0 @@ "main": "index.js",

pbx.d.ts

@@ -20,2 +20,3 @@ import * as ast from "./ast";
     readonly targets: PBXNativeTarget[];
+    readonly buildConfigurationsList: XCConfigurationList;
 }
@@ -22,0 +23,0 @@ export declare class PBXNativeTarget extends DocumentObject {

pbx.js

@@ -69,2 +69,9 @@ var __extends = (this && this.__extends) || (function () {
     });
+    Object.defineProperty(PBXProject.prototype, "buildConfigurationsList", {
+        get: function () {
+            return this.document[this.ast.value.get("buildConfigurationList").text];
+        },
+        enumerable: true,
+        configurable: true
+    });
     return PBXProject;
@@ -71,0 +78,0 @@ }(DocumentObject));

test.js

@@ -44,3 +44,3 @@ Object.defineProperty(exports, "__esModule", { value: true });
     });
-    it("can upgrade signing style from none to manual with specific provisioning profile for all targets", function () {
+    it("can upgrade signing style from none to manual with specific provisioning profile", function () {
         var xcode = xcode_1.Xcode.open("tests/signing-style/none.pbxproj");
@@ -55,3 +55,3 @@ xcode.setManualSigningStyle("SampleProvProfApp", {
     });
-    it("can upgrade signing style from automatic to manual with specific provisioning profile for all targets", function () {
+    it("can upgrade signing style from automatic to manual with specific provisioning profile", function () {
         var xcode = xcode_1.Xcode.open("tests/signing-style/automatic.pbxproj");
@@ -66,2 +66,24 @@ xcode.setManualSigningStyle("SampleProvProfApp", {
     });
+    it("can upgrade signing style from automatic to manual with specific provisioning profile and developer code sign identity", function () {
+        var xcode = xcode_1.Xcode.open("tests/signing-style/automatic.pbxproj");
+        xcode.setManualSigningStyle("SampleProvProfApp", {
+            uuid: "a62743b2-2513-4488-8d83-bad5f3b6716d",
+            name: "NativeScriptDevProfile",
+            team: "W7TGC3P93K",
+            identity: "iPhone Developer"
+        });
+        var expected = fs.readFileSync("tests/signing-style/manual-with-provisioning-dev.pbxproj").toString();
+        chai_1.assert.equal(xcode.toString(), expected);
+    });
+    it("can upgrade signing style from automatic to manual with specific provisioning profile and distribution code sign identity", function () {
+        var xcode = xcode_1.Xcode.open("tests/signing-style/automatic.pbxproj");
+        xcode.setManualSigningStyle("SampleProvProfApp", {
+            uuid: "a62743b2-2513-4488-8d83-bad5f3b6716d",
+            name: "NativeScriptDevProfile",
+            team: "W7TGC3P93K",
+            identity: "iPhone Distribution"
+        });
+        var expected = fs.readFileSync("tests/signing-style/manual-with-provisioning-dist.pbxproj").toString();
+        chai_1.assert.equal(xcode.toString(), expected);
+    });
     it("can upgrade signing style from none to automatic", function () {
@@ -68,0 +90,0 @@ var xcode = xcode_1.Xcode.open("tests/signing-style/none.pbxproj");

xcode.js

@@ -30,32 +30,33 @@ Object.defineProperty(exports, "__esModule", { value: true });
     Xcode.prototype.setManualSigningStyle = function (targetName, _a) {
-        var _this = this;
         var _b = _a === void 0 ? { team: undefined, uuid: undefined, name: undefined } : _a, team = _b.team, uuid = _b.uuid, name = _b.name, identity = _b.identity;
-        this.document.targets
-            .filter(function (target) { return target.name === targetName; })
-            .forEach(function (target) {
-            _this.document.projects
-                .filter(function (project) { return project.targets.indexOf(target) >= 0; })
-                .forEach(function (project) {
-                project.patch({
-                    attributes: {
-                        TargetAttributes: (_a = {},
-                            _a[target.key] = {
-                                DevelopmentTeam: team,
-                                ProvisioningStyle: "Manual"
-                            },
-                            _a)
-                    }
+        this.document.projects.forEach(function (project) {
+            var targets = project.targets.filter(function (target) { return target.name === targetName; });
+            if (targets.length > 0) {
+                project.buildConfigurationsList.buildConfigurations.forEach(function (config) {
+                    return config.patch({ buildSettings: { "CODE_SIGN_IDENTITY[sdk=iphoneos*]": identity } });
                 });
-                var _a;
-            });
-            target.buildConfigurationsList.buildConfigurations.forEach(function (config) {
-                config.patch({
-                    buildSettings: {
-                        "CODE_SIGN_IDENTITY[sdk=iphoneos*]": identity /* delete or set the CODE_SIGN_IDENTITY[sdk=iphoneos*] */,
-                        DEVELOPMENT_TEAM: team || "",
-                        PROVISIONING_PROFILE: uuid,
-                        PROVISIONING_PROFILE_SPECIFIER: name
-                    }
+                targets.forEach(function (target) {
+                    project.patch({
+                        attributes: {
+                            TargetAttributes: (_a = {},
+                                _a[target.key] = {
+                                    DevelopmentTeam: team,
+                                    ProvisioningStyle: "Manual"
+                                },
+                                _a)
+                        }
+                    });
+                    target.buildConfigurationsList.buildConfigurations.forEach(function (config) {
+                        config.patch({
+                            buildSettings: {
+                                "CODE_SIGN_IDENTITY[sdk=iphoneos*]": identity /* delete or set the CODE_SIGN_IDENTITY[sdk=iphoneos*] */,
+                                DEVELOPMENT_TEAM: team || "",
+                                PROVISIONING_PROFILE: uuid,
+                                PROVISIONING_PROFILE_SPECIFIER: name
+                            }
+                        });
+                    });
+                    var _a;
                 });
-            });
+            }
         });
@@ -62,0 +63,0 @@ };

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

146301

increased by87.98%

Number of package files

20

increased by25%

Lines of code

1942

increased by1.62%

No dependency changes