rc-animate - npm Package Compare versions

Comparing version 2.2.2 to 2.3.0

HISTORY.md

 # History
 ----
 
+## 2.3.0 / 2016-07-05
+
+- support null/undefined child: https://github.com/react-component/animate/pull/11
+
 ## 2.2.0 / 2016-06-28
@@ -5,0 +9,0 @@

lib/Animate.js

@@ -92,3 +92,5 @@ 'use strict';
     children.forEach(function (child) {
-      _this.performAppear(child.key);
+      if (child) {
+        _this.performAppear(child.key);
+      }
     });
@@ -116,3 +118,3 @@ },
       currentChildren.forEach(function (currentChild) {
-        var nextChild = (0, _ChildrenUtils.findChildInChildrenByKey)(nextChildren, currentChild.key);
+        var nextChild = currentChild && (0, _ChildrenUtils.findChildInChildrenByKey)(nextChildren, currentChild.key);
         var newChild = void 0;
@@ -129,3 +131,3 @@ if ((!nextChild || !nextChild.props[showProp]) && currentChild.props[showProp]) {
       nextChildren.forEach(function (nextChild) {
-        if (!(0, _ChildrenUtils.findChildInChildrenByKey)(currentChildren, nextChild.key)) {
+        if (!nextChild || !(0, _ChildrenUtils.findChildInChildrenByKey)(currentChildren, nextChild.key)) {
           newChildren.push(nextChild);
@@ -144,7 +146,7 @@ }
     nextChildren.forEach(function (child) {
-      var key = child.key;
-      if (currentlyAnimatingKeys[key]) {
+      var key = child && child.key;
+      if (child && currentlyAnimatingKeys[key]) {
         return;
       }
-      var hasPrev = (0, _ChildrenUtils.findChildInChildrenByKey)(currentChildren, key);
+      var hasPrev = child && (0, _ChildrenUtils.findChildInChildrenByKey)(currentChildren, key);
       if (showProp) {
@@ -166,7 +168,7 @@ var showInNext = child.props[showProp];
     currentChildren.forEach(function (child) {
-      var key = child.key;
-      if (currentlyAnimatingKeys[key]) {
+      var key = child && child.key;
+      if (child && currentlyAnimatingKeys[key]) {
         return;
       }
-      var hasNext = (0, _ChildrenUtils.findChildInChildrenByKey)(nextChildren, key);
+      var hasNext = child && (0, _ChildrenUtils.findChildInChildrenByKey)(nextChildren, key);
       if (showProp) {
@@ -289,3 +291,3 @@ var showInNow = child.props[showProp];
       children = stateChildren.map(function (child) {
-        if (child === null) {
+        if (child === null || child === undefined) {
           return child;
@@ -292,0 +294,0 @@ }

lib/ChildrenUtils.js

@@ -34,3 +34,3 @@ 'use strict';
       }
-      if (child.key === key) {
+      if (child && child.key === key) {
         ret = child;
@@ -47,3 +47,3 @@ }
     children.forEach(function (child) {
-      if (child.key === key && child.props[showProp]) {
+      if (child && child.key === key && child.props[showProp]) {
         if (ret) {
@@ -66,3 +66,3 @@ throw new Error('two child with same key for <rc-animate> children');
       }
-      found = child.key === key && !child.props[showProp];
+      found = child && child.key === key && !child.props[showProp];
     });
@@ -78,6 +78,10 @@ }
       var child2 = c2[index];
-      if (child.key !== child2.key) {
-        same = false;
-      } else if (showProp && child.props[showProp] !== child2.props[showProp]) {
-        same = false;
+      if (child && child2) {
+        if (child && !child2 || !child && child2) {
+          same = false;
+        } else if (child.key !== child2.key) {
+          same = false;
+        } else if (showProp && child.props[showProp] !== child2.props[showProp]) {
+          same = false;
+        }
       }
@@ -97,3 +101,3 @@ });
   prev.forEach(function (child) {
-    if (findChildInChildrenByKey(next, child.key)) {
+    if (child && findChildInChildrenByKey(next, child.key)) {
       if (pendingChildren.length) {
@@ -109,3 +113,3 @@ nextChildrenPending[child.key] = pendingChildren;
   next.forEach(function (child) {
-    if (nextChildrenPending.hasOwnProperty(child.key)) {
+    if (child && nextChildrenPending.hasOwnProperty(child.key)) {
       ret = ret.concat(nextChildrenPending[child.key]);
@@ -112,0 +116,0 @@ }

package.json

 {
   "name": "rc-animate",
-  "version": "2.2.2",
+  "version": "2.3.0",
   "description": "css-transition ui component for react",
@@ -5,0 +5,0 @@ "keywords": [

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

23644

increased by1.8%

Lines of code

513

increased by1.18%

No dependency changes