rc-tree - npm Package Compare versions

Comparing version 0.26.1 to 1.0.0

lib/Tree.js

@@ -221,4 +221,2 @@ 'use strict';
     value: function onCheck(treeNode) {
-      var _this3 = this;
-
       var checked = !treeNode.props.checked;
@@ -234,27 +232,15 @@ if (treeNode.props.checkPart) {
       var checkKeys = (0, _util.getTreeNodesStates)(this.props.children, checkedKeys, checked, key);
-      // this.checkPartKeys = checkKeys.checkPartKeys;
       var newSt = {
         event: 'check',
         node: treeNode,
-        allCheckedNodesKeys: checkKeys.checkedNodesKeys
+        checked: checked,
+        checkedNodesKeys: checkKeys.checkedNodesKeys
       };
+      checkedKeys = checkKeys.checkedKeys;
       if (!('checkedKeys' in this.props)) {
         this.setState({
-          checkedKeys: checkKeys.checkedKeys
+          checkedKeys: checkedKeys
         });
-        newSt.checked = checked;
-      } else {
-        checkedKeys = [].concat(_toConsumableArray(this.state.checkedKeys));
-        newSt.allCheckedNodesKeys = [];
-        Object.keys(checkKeys.treeNodesStates).forEach(function (item) {
-          var itemObj = checkKeys.treeNodesStates[item];
-          // 此处用 this.checkedKeys，能包含上一次所有选中的节点，
-          // 供用户判断点击节点，下次是否需要选中
-          if (_this3.checkedKeys.indexOf(itemObj.key) !== -1) {
-            newSt.allCheckedNodesKeys.push({ key: itemObj.key, node: itemObj.node, pos: item });
-          }
-        });
       }
-      newSt.checkedKeys = [].concat(_toConsumableArray(checkedKeys));
-      this.props.onCheck(newSt);
+      this.props.onCheck(checkedKeys, newSt);
     }
@@ -281,3 +267,4 @@ }, {
         event: 'select',
-        node: treeNode
+        node: treeNode,
+        selected: selected
       };
@@ -288,8 +275,4 @@ if (!('selectedKeys' in this.props)) {
         });
-        newSt.selected = selected;
-      } else {
-        selectedKeys = [].concat(_toConsumableArray(this.state.selectedKeys));
       }
-      newSt.selectedKeys = [].concat(_toConsumableArray(selectedKeys));
-      props.onSelect(newSt);
+      props.onSelect(selectedKeys, newSt);
     }
@@ -467,2 +450,3 @@ }, {
         pos: pos,
+        selectable: props.selectable,
         loadData: props.loadData,
@@ -561,2 +545,3 @@ onMouseEnter: props.onMouseEnter,
   showIcon: true,
+  selectable: true,
   autoExpandParent: true,
@@ -563,0 +548,0 @@ defaultExpandAll: false,

lib/TreeNode.js

@@ -229,5 +229,8 @@ 'use strict';
       var newChildren = children;
-      var allTreeNode = Array.isArray(children) && children.every(function (item) {
-        return item.type === TreeNode;
-      });
+      var allTreeNode = undefined;
+      if (Array.isArray(children)) {
+        allTreeNode = children.every(function (item) {
+          return item.type === TreeNode;
+        });
+      }
       if (children && (children.type === TreeNode || allTreeNode)) {
@@ -303,3 +306,5 @@ var _cls;
             e.preventDefault();
-            _this3.onSelect();
+            if (props.selectable) {
+              _this3.onSelect();
+            }
             // not fire check event
@@ -306,0 +311,0 @@ // if (props.checkable) {

lib/util.js

@@ -138,2 +138,3 @@ 'use strict';
 
+// TODO 效率差, 需要缓存优化
 function handleCheckState(obj, checkedPositionArr, checkIt) {
@@ -239,2 +240,3 @@ var stripTail = function stripTail(str) {
   });
+
   // debugger
@@ -241,0 +243,0 @@ handleCheckState(treeNodesStates, filterMinPosition(checkedPosition.sort()), true);

package.json

 {
   "name": "rc-tree",
-  "version": "0.26.1",
+  "version": "1.0.0",
   "description": "tree ui component for react",
@@ -5,0 +5,0 @@ "keywords": [

README.md

@@ -64,2 +64,3 @@ # rc-tree
 |showIcon | whether show icon | bool | true |
+|selectable | whether can be selected | bool | true |
 |multiple | whether multiple select | bool | false |
@@ -76,4 +77,4 @@ |checkable | whether support checked | bool/React Node | false |
 |onExpand | fire on treeNode expand or not | function(node, expanded, expandedKeys) | - |
-|onCheck | click the treeNode/checkbox to fire | function(e:{checked:bool, node, checkedKeys, event, allCheckedNodesKeys}) | - |
-|onSelect | click the treeNode to fire | function(e:{selected:bool, node, selectedKeys, event}) | - |
+|onCheck | click the treeNode/checkbox to fire | function(checkedKeys, e:{checked:bool, node, event}) | - |
+|onSelect | click the treeNode to fire | function(selectedKeys, e:{selected:bool, node, event}) | - |
 |filterTreeNode | filter some treeNodes as you need. it should return true | function(node) | - |
@@ -80,0 +81,0 @@ |loadData | load data asynchronously and the return value should be a promise | function(node) | - |

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

No v1

Quality

Package is not semver >=1. This means it is not stable and does not support ^ ranges.

Found 1 instance in 1 package

Improved metrics

Number of low quality alerts

0

decreased by-100%

Number of lines in readme file

125

increased by0.81%

Worsened metrics

Total package byte prevSize

61073

decreased by-1.03%

Lines of code

1534

decreased by-0.52%

No dependency changes