react-draggable-tab - npm Package Compare versions

Comparing version 0.10.0 to 0.10.1

CHANGELOG.md

 ## Change Log
 
+### Ver 0.10.1
+
+  * #101 [Received `false` for a non-boolean attribute `uncloseable`](https://github.com/georgeOsdDev/react-draggable-tab/issues/101)
 ### Ver 0.10.0
@@ -4,0 +7,0 @@

example/app.js

@@ -48,3 +48,3 @@ 'use strict';
       tabs:[
-        (<Tab key={'tab0'} title={'unclosable tab'} uncloseable={true} {...this.makeListeners('tab0')}>
+        (<Tab key={'tab0'} title={'unclosable tab'} unclosable={true} {...this.makeListeners('tab0')}>
           <div>
@@ -51,0 +51,0 @@ <h1>This tab cannot close</h1>

lib/components/Tab.js

@@ -51,3 +51,3 @@ 'use strict';
   afterTitle: _react2.default.createElement('span', null),
-  uncloseable: false,
+  unclosable: false,
   tabClassNames: {
@@ -72,3 +72,3 @@ tab: '',
   afterTitle: _propTypes2.default.element,
-  uncloseable: _propTypes2.default.bool,
+  unclosable: _propTypes2.default.bool,
   tabClassNames: _propTypes2.default.shape({
@@ -75,0 +75,0 @@ tab: _propTypes2.default.string,

lib/components/Tabs.js

@@ -455,3 +455,3 @@ 'use strict';
     value: function getCloseButton(tab, style, classes, hoverStyleBase) {
-      if (tab.props.uncloseable) {
+      if (tab.props.unclosable) {
         return '';
@@ -526,3 +526,4 @@ }
             onMouseLeave = _tab$props.onMouseLeave,
-            others = _objectWithoutProperties(_tab$props, ['beforeTitle', 'title', 'afterTitle', 'tabClassNames', 'tabStyles', 'containerStyle', 'hiddenContainerStyle', 'onMouseEnter', 'onMouseLeave']);
+            unclosable = _tab$props.unclosable,
+            others = _objectWithoutProperties(_tab$props, ['beforeTitle', 'title', 'afterTitle', 'tabClassNames', 'tabStyles', 'containerStyle', 'hiddenContainerStyle', 'onMouseEnter', 'onMouseLeave', 'unclosable']);
 
@@ -610,7 +611,2 @@ // override inline each tab styles
               ref: tab.key
-              // TODO: This copies props to <li> which it does not understand.
-              // This isn't a major problem, but the 'uncloseable' prop is
-              // passed as a boolean. In Development mode react-dom will give a
-              // warning that non-boolean prop 'uncloseable' is being passed as
-              // a boolean to <li>.
             }, others),
@@ -617,0 +613,0 @@ _react2.default.createElement(

package.json

 {
   "name": "react-draggable-tab",
-  "version": "0.10.0",
+  "version": "0.10.1",
   "description": "Draggable chrome like tab react component ",
@@ -10,4 +10,4 @@ "main": "./lib/index.js",
     "start:example:basex": "npm run clean && npm run build && (npm run watch:example & npm run browser)",
-    "start:example:base": "npm run clean && npm run build && ",
-    "start:example": "cross-env NODE_ENV=development npm run start:example:base",
+    "start:example:base": "npm run clean && npm run build",
+    "start:example": "cross-env NODE_ENV=development npm run start:example:basex",
     "start:example:prod": "cross-env NODE_ENV=production npm run start:example:base",
@@ -69,2 +69,3 @@ "test:local": "karma start",
     "react-test-renderer": "^16.3.2",
+    "rimraf": "^2.6.2",
     "watchify": "^3.9.0"
@@ -71,0 +72,0 @@ },

src/components/Tab.js

@@ -21,3 +21,3 @@ import React from 'react';
   afterTitle: <span />,
-  uncloseable: false,
+  unclosable: false,
   tabClassNames: {
@@ -45,3 +45,3 @@ tab: '',
   afterTitle: PropTypes.element,
-  uncloseable: PropTypes.bool,
+  unclosable: PropTypes.bool,
   tabClassNames: PropTypes.shape({
@@ -48,0 +48,0 @@ tab: PropTypes.string,

src/components/Tabs.js

@@ -355,3 +355,3 @@ import React from 'react';
   getCloseButton(tab, style, classes, hoverStyleBase) {
-    if (tab.props.uncloseable) {
+    if (tab.props.unclosable) {
       return '';
@@ -419,2 +419,3 @@ }
         onMouseLeave,
+        unclosable,
         ...others
@@ -491,7 +492,2 @@ } = tab.props;
               ref={tab.key}
-              // TODO: This copies props to <li> which it does not understand.
-              // This isn't a major problem, but the 'uncloseable' prop is
-              // passed as a boolean. In Development mode react-dom will give a
-              // warning that non-boolean prop 'uncloseable' is being passed as
-              // a boolean to <li>.
               {...others}>
@@ -498,0 +494,0 @@ <span style={TabStyles.beforeTitle} className={tabBeforeTitleClasses}>{beforeTitle}</span>

test/components/Tab_spec.js

@@ -18,3 +18,3 @@ 'use strict';
     expect(component.props.title).to.be.equal('untitled');
-    expect(component.props.uncloseable).to.be.equal(false);
+    expect(component.props.unclosable).to.be.equal(false);
 
@@ -21,0 +21,0 @@ expect(component.props.tabClassNames).to.be.an('object');

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Worsened metrics

Total package byte prevSize

391956

decreased by-0.11%

Dev dependency count

35

increased by2.94%

Lines of code

4278

decreased by-0.19%

No dependency changes