react-google-maps - npm Package Compare versions

Comparing version 2.0.2 to 2.0.3

CHANGELOG.md

@@ -0,1 +1,14 @@
+<a name"2.0.3"></a>
+### 2.0.3 (2015-08-18)
+
+
+#### Bug Fixes
+
+* **OverlayView:**
+  * add invariant for mapPaneName ([f102577c](https://github.com/tomchentw/react-google-maps/commit/f102577c))
+  * add invariant checking for position props ([757bda08](https://github.com/tomchentw/react-google-maps/commit/757bda08))
+  * add position to propTypes ([1fc968ad](https://github.com/tomchentw/react-google-maps/commit/1fc968ad), closes [#99](https://github.com/tomchentw/react-google-maps/issues/99))
+* **package.json:** remove object-path ([ee55b7a5](https://github.com/tomchentw/react-google-maps/commit/ee55b7a5))
+
+
 <a name"2.0.2"></a>
@@ -2,0 +15,0 @@ ### 2.0.2 (2015-08-08)

lib/addons/InfoBox.js

@@ -27,2 +27,4 @@ "use strict";
 
+var _addonsCreatorsInfoBoxCreator2 = _interopRequireDefault(_addonsCreatorsInfoBoxCreator);
+
 /*
@@ -33,4 +35,2 @@ * Original author: @wuct
 
-var _addonsCreatorsInfoBoxCreator2 = _interopRequireDefault(_addonsCreatorsInfoBoxCreator);
-
 var InfoBox = (function (_Component) {
@@ -37,0 +37,0 @@ _inherits(InfoBox, _Component);

lib/creators/OverlayViewCreator.js

@@ -21,2 +21,6 @@ "use strict";
 
+var _invariant = require("invariant");
+
+var _invariant2 = _interopRequireDefault(_invariant);
+
 var _utilsDefaultPropsCreator = require("../utils/defaultPropsCreator");
@@ -37,3 +41,4 @@
   mapPaneName: _react.PropTypes.string,
-  getPixelPositionOffset: _react.PropTypes.func
+  getPixelPositionOffset: _react.PropTypes.func,
+  position: _react.PropTypes.object
 };
@@ -88,3 +93,3 @@
       var overlayView = new google.maps.OverlayView();
-      overlayView.setValues((0, _utilsComposeOptions2["default"])(overlayViewProps, ["mapPaneName", "getPixelPositionOffset", "children"]));
+      overlayView.setValues((0, _utilsComposeOptions2["default"])(overlayViewProps, ["mapPaneName", "getPixelPositionOffset", "position", "children"]));
 
@@ -123,2 +128,4 @@ overlayView.onAdd = function () {
         var mapPaneName = this.get("mapPaneName");
+        (0, _invariant2["default"])(!!mapPaneName, "OverlayView requires a mapPaneName/defaultMapPaneName in your props instead of %s", mapPaneName);
+
         this.getPanes()[mapPaneName].appendChild(this._containerElement);
@@ -154,2 +161,4 @@ };
         var position = this.get("position");
+        (0, _invariant2["default"])(!!position, "OverlayView requires a position/defaultPosition in your props instead of %s", position);
+
         if (projection && position) {
@@ -156,0 +165,0 @@ if (!(position instanceof google.maps.LatLng)) {

lib/DirectionsRenderer.js

@@ -27,2 +27,4 @@ "use strict";
 
+var _creatorsDirectionsRendererCreator2 = _interopRequireDefault(_creatorsDirectionsRendererCreator);
+
 /*
@@ -33,4 +35,2 @@ * Original author: @alexishevia
 
-var _creatorsDirectionsRendererCreator2 = _interopRequireDefault(_creatorsDirectionsRendererCreator);
-
 var DirectionsRenderer = (function (_Component) {
@@ -37,0 +37,0 @@ _inherits(DirectionsRenderer, _Component);

lib/DrawingManager.js

@@ -27,2 +27,4 @@ "use strict";
 
+var _creatorsDrawingManagerCreator2 = _interopRequireDefault(_creatorsDrawingManagerCreator);
+
 /*
@@ -33,4 +35,2 @@ * Original author: @idolize
 
-var _creatorsDrawingManagerCreator2 = _interopRequireDefault(_creatorsDrawingManagerCreator);
-
 var DrawingManager = (function (_Component) {
@@ -37,0 +37,0 @@ _inherits(DrawingManager, _Component);

lib/GoogleMap.js

@@ -132,3 +132,8 @@ "use strict";
       var _props = this.props;
+      var containerTagName = _props.containerTagName;
+      var containerProps = _props.containerProps;
+      var children = _props.children;
 
+      var mapProps = _objectWithoutProperties(_props, ["containerTagName", "containerProps", "children"]);
+
       // TODO: support asynchronous load of google.maps API at this level.
@@ -139,8 +144,2 @@ //
       //
-      var containerTagName = _props.containerTagName;
-      var containerProps = _props.containerProps;
-      var children = _props.children;
-
-      var mapProps = _objectWithoutProperties(_props, ["containerTagName", "containerProps", "children"]);
-
       var map = _creatorsGoogleMapHolder2["default"]._createMap(domEl, mapProps);
@@ -147,0 +146,0 @@ this.setState({ map: map });

lib/OverlayView.js

@@ -27,2 +27,4 @@ "use strict";
 
+var _creatorsOverlayViewCreator2 = _interopRequireDefault(_creatorsOverlayViewCreator);
+
 /*
@@ -33,4 +35,2 @@ * Original author: @petebrowne
 
-var _creatorsOverlayViewCreator2 = _interopRequireDefault(_creatorsOverlayViewCreator);
-
 var OverlayView = (function (_Component) {
@@ -37,0 +37,0 @@ _inherits(OverlayView, _Component);

lib/Rectangle.js

@@ -27,2 +27,4 @@ "use strict";
 
+var _creatorsRectangleCreator2 = _interopRequireDefault(_creatorsRectangleCreator);
+
 /*
@@ -33,4 +35,2 @@ * Original author: @alistairjcbrown
 
-var _creatorsRectangleCreator2 = _interopRequireDefault(_creatorsRectangleCreator);
-
 var Rectangle = (function (_Component) {
@@ -37,0 +37,0 @@ _inherits(Rectangle, _Component);

package.json

 {
   "__template__gist__": "https://gist.github.com/tomchentw/368a93bb748ad9d576f1#file-package-json",
   "name": "react-google-maps",
-  "version": "2.0.2",
+  "version": "2.0.3",
   "description": "React.js Google Maps integration component",
@@ -64,3 +64,3 @@ "main": "lib/index.js",
     "google-maps-infobox": "^1.1.13",
-    "object-path": "^0.9.2",
+    "invariant": "^2.1.0",
     "react": "^0.13.0"
@@ -67,0 +67,0 @@ },

src/creators/OverlayViewCreator.js

@@ -7,2 +7,3 @@ import {
 } from "react";
+import {default as invariant} from "invariant";
 
@@ -18,2 +19,3 @@ import {default as defaultPropsCreator} from "../utils/defaultPropsCreator";
   getPixelPositionOffset: PropTypes.func,
+  position: PropTypes.object,
 // [].map.call($0.querySelectorAll("tr>td>code"), function(it){ return it.textContent; }).filter(function(it){ return it.match(/^set/) && !it.match(/^setMap/); })
@@ -38,2 +40,3 @@ // https://developers.google.com/maps/documentation/javascript/3.exp/reference
       "getPixelPositionOffset",
+      "position",
       "children",
@@ -77,2 +80,4 @@ ]));
       const mapPaneName = this.get("mapPaneName");
+      invariant(!!mapPaneName, "OverlayView requires a mapPaneName/defaultMapPaneName in your props instead of %s", mapPaneName);
+
       this.getPanes()[mapPaneName].appendChild(this._containerElement);
@@ -105,2 +110,4 @@ };
       let position = this.get("position");
+      invariant(!!position, "OverlayView requires a position/defaultPosition in your props instead of %s", position);
+
       if (projection && position) {
@@ -107,0 +114,0 @@ if (!(position instanceof google.maps.LatLng)) {

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

248482

increased by0.56%

Lines of code

4661

increased by0.22%

Dependency changes

• + Addedinvariant@^2.1.0

• + Addedinvariant@2.2.4(transitive)

• + Addedjs-tokens@4.0.0(transitive)

• + Addedloose-envify@1.4.0(transitive)

• - Removedobject-path@^0.9.2

• - Removedobject-path@0.9.2(transitive)