react-google-maps - npm Package Compare versions

Comparing version 4.7.1 to 4.7.2

CHANGELOG.md

@@ -0,1 +1,11 @@
+<a name="4.7.2"></a>
+## [4.7.2](https://github.com/tomchentw/react-google-maps/compare/v4.7.1...v4.7.2) (2016-01-07)
+
+
+### Bug Fixes
+
+* **OverlayViewCreator:** position container after render ([f5b0a4c](https://github.com/tomchentw/react-google-maps/commit/f5b0a4c)), closes [#167](https://github.com/tomchentw/react-google-maps/issues/167)
+
+
+
 <a name="4.7.1"></a>
@@ -2,0 +12,0 @@ ## [4.7.1](https://github.com/tomchentw/react-google-maps/compare/v4.7.0...v4.7.1) (2015-12-30)

lib/creators/OverlayViewCreator.js

@@ -107,5 +107,4 @@ "use strict";
       overlayView.draw = function draw() {
+        this._mountContainerToPane();
         this._renderContent();
-        this._mountContainerToPane();
-        this._positionContainerElement();
       };
@@ -120,3 +119,2 @@
       overlayView._redraw = function _redraw(mapPaneNameChanged) {
-        this._renderContent();
         if (mapPaneNameChanged) {
@@ -126,7 +124,9 @@ this._unmountContainerFromPane();
         }
-        this._positionContainerElement();
+        this._renderContent();
       };
 
       overlayView._renderContent = function _renderContent() {
-        (0, _reactDom.render)(_react.Children.only(this.get("children")), this._containerElement);
+        if (this._containerElement) {
+          (0, _reactDom.render)(_react.Children.only(this.get("children")), this._containerElement, this._positionContainerElement.bind(this));
+        }
       };
@@ -133,0 +133,0 @@

package.json

 {
   "__template__gist__": "https://gist.github.com/tomchentw/368a93bb748ad9d576f1#file-package-json",
   "name": "react-google-maps",
-  "version": "4.7.1",
+  "version": "4.7.2",
   "description": "React.js Google Maps integration component",
@@ -6,0 +6,0 @@ "main": "lib/index.js",

src/creators/OverlayViewCreator.js

@@ -56,5 +56,4 @@ import {
     overlayView.draw = function draw() {
+      this._mountContainerToPane();
       this._renderContent();
-      this._mountContainerToPane();
-      this._positionContainerElement();
     };
@@ -69,3 +68,2 @@
     overlayView._redraw = function _redraw(mapPaneNameChanged) {
-      this._renderContent();
       if (mapPaneNameChanged) {
@@ -75,10 +73,13 @@ this._unmountContainerFromPane();
       }
-      this._positionContainerElement();
+      this._renderContent();
     };
 
     overlayView._renderContent = function _renderContent() {
-      render(
-        Children.only(this.get(`children`)),
-        this._containerElement
-      );
+      if (this._containerElement) {
+        render(
+          Children.only(this.get(`children`)),
+          this._containerElement,
+          this._positionContainerElement.bind(this)
+        );
+      }
     };
@@ -85,0 +86,0 @@

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

354284

increased by0.11%

Lines of code

6726

increased by0.01%

No dependency changes