react-konva - npm Package Compare versions

Comparing version 1.5.4-beta to 1.5.5-beta

package.json

 {
   "name": "react-konva",
   "description": "React binding to canvas element via Konva framework",
-  "version": "1.5.4-beta",
+  "version": "1.5.5-beta",
   "keywords": ["react", "canvas", "jsx", "konva"],
@@ -14,3 +14,4 @@ "bugs": "https://github.com/lavrton/react-konva/issues",
   "dependencies": {
-    "fbjs": "^0.8.14"
+    "fbjs": "^0.8.14",
+    "react-reconciler": "^0.2.0"
   },
@@ -20,4 +21,3 @@ "peerDependencies": {
     "konva": "^1.6.3",
-    "react-dom": "~16.0.0",
-    "react-reconciler": "^0.2.0"
+    "react-dom": "~16.0.0"
   },
@@ -24,0 +24,0 @@ "devDependencies": {

react-konva.js

@@ -486,3 +486,3 @@ (function webpackUniversalModuleDefinition(root, factory) {
   createTextInstance: function createTextInstance(text, rootContainerInstance, internalInstanceHandle) {
-    return text;
+    invariant(false, 'Text components are not supported for now in ReactKonva.');
   },
@@ -521,3 +521,3 @@ finalizeInitialChildren: function finalizeInitialChildren(domElement, type, props) {
   shouldSetTextContent: function shouldSetTextContent(type, props) {
-    return typeof props.children === 'string' || typeof props.children === 'number';
+    return false;
   },
@@ -532,7 +532,16 @@
     appendChild: function appendChild(parentInstance, child) {
-      parentInstance.add(child);
+      if (child.parent === parentInstance) {
+        child.moveToTop();
+      } else {
+        parentInstance.add(child);
+      }
+
       updatePicture(parentInstance);
     },
     appendChildToContainer: function appendChildToContainer(parentInstance, child) {
-      parentInstance.add(child);
+      if (child.parent === parentInstance) {
+        child.moveToTop();
+      } else {
+        parentInstance.add(child);
+      }
       updatePicture(parentInstance);
@@ -542,4 +551,7 @@ },
       invariant(child !== beforeChild, 'ReactKonva: Can not insert node before itself');
-      parentInstance.add(child);
-      child.setZIndex(beforeChild.getZIndex());
+      if (child.parent !== parentInstance) {
+        parentInstance.add(child);
+      }
+      var newIndex = Math.max(beforeChild.getZIndex() - 1, 0);
+      child.setZIndex(newIndex);
       updatePicture(parentInstance);
@@ -549,4 +561,7 @@ },
       invariant(child !== beforeChild, 'ReactKonva: Can not insert node before itself');
-      parentInstance.add(child);
-      child.setZIndex(beforeChild.getZIndex());
+      if (child.parent !== parentInstance) {
+        parentInstance.add(child);
+      }
+      var newIndex = Math.max(beforeChild.getZIndex() - 1, 0);
+      child.setZIndex(newIndex);
       updatePicture(parentInstance);
@@ -563,3 +578,3 @@ },
     commitTextUpdate: function commitTextUpdate(textInstance, oldText, newText) {
-      // Noop
+      invariant(false, 'Text components are not yet supported in ReactKonva.');
     },
@@ -571,6 +586,2 @@ commitMount: function commitMount(instance, type, newProps) {
       instance._applyProps(instance, newProps, oldProps);
-      if (instance.getZIndex() !== fiberInstance.index) {
-        instance.setZIndex(fiberInstance.index);
-        updatePicture(instance);
-      }
     }
@@ -577,0 +588,0 @@ }

No alert changes

Improved metrics

Total package byte prevSize

41745

0.77%

Lines of code

840

1.2%

Dependency changes

• + Added

  react-reconciler@^0.2.0