react-sortable-hoc - npm Package Compare versions

Comparing version 0.6.6 to 0.6.7

CHANGELOG.md

 Changelog
 ------------
+### 0.6.7
+Fixes issues with Jest Snapshot testing trying to serialize the `window` object and running out of memory [#249](https://github.com/clauderic/react-sortable-hoc/issues/249). Thanks [@cameronmcefee](https://github.com/cameronmcefee)!
+
 ### 0.6.6
@@ -4,0 +7,0 @@ Fixes an issue with Internet Explorer 11 introduced in `0.6.5` [#248](https://github.com/clauderic/react-sortable-hoc/pull/248). Thanks [@humiston](https://github.com/humiston)!

dist/commonjs/SortableContainer/index.js

@@ -416,7 +416,13 @@ 'use strict';
         var _props = this.props,
-            contentWindow = _props.contentWindow,
             getContainer = _props.getContainer,
             useWindowAsScrollContainer = _props.useWindowAsScrollContainer;
 
+        /*
+         *  Set our own default rather than using defaultProps because Jest
+         *  snapshots will serialize window, causing a RangeError
+         *  https://github.com/clauderic/react-sortable-hoc/issues/249
+         */
 
+        var contentWindow = this.props.contentWindow || window;
+
         this.container = typeof getContainer === 'function' ? getContainer(this.getWrappedInstance()) : (0, _reactDom.findDOMNode)(this);
@@ -734,3 +740,2 @@ this.document = this.container.ownerDocument || document;
     hideSortableGhost: true,
-    contentWindow: typeof window !== 'undefined' ? window : null,
     shouldCancelStart: function shouldCancelStart(e) {
@@ -737,0 +742,0 @@ // Cancel sorting if the event target is an `input`, `textarea`, `select` or `option`

dist/es6/SortableContainer/index.js

@@ -388,7 +388,13 @@ import _extends from 'babel-runtime/helpers/extends';
         var _props = this.props,
-            contentWindow = _props.contentWindow,
             getContainer = _props.getContainer,
             useWindowAsScrollContainer = _props.useWindowAsScrollContainer;
 
+        /*
+         *  Set our own default rather than using defaultProps because Jest
+         *  snapshots will serialize window, causing a RangeError
+         *  https://github.com/clauderic/react-sortable-hoc/issues/249
+         */
 
+        var contentWindow = this.props.contentWindow || window;
+
         this.container = typeof getContainer === 'function' ? getContainer(this.getWrappedInstance()) : findDOMNode(this);
@@ -706,3 +712,2 @@ this.document = this.container.ownerDocument || document;
     hideSortableGhost: true,
-    contentWindow: typeof window !== 'undefined' ? window : null,
     shouldCancelStart: function shouldCancelStart(e) {
@@ -709,0 +714,0 @@ // Cancel sorting if the event target is an `input`, `textarea`, `select` or `option`

package.json

 {
   "name": "react-sortable-hoc",
-  "version": "0.6.6",
+  "version": "0.6.7",
   "description": "Set of higher-order components to turn any list into a sortable, touch-friendly, animated list",
@@ -5,0 +5,0 @@ "author": {

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

1222325

increased by0.09%

Lines of code

10237

increased by0.12%

No dependency changes