read-all-stream - npm Package Compare versions

Comparing version 2.1.1 to 2.1.2

index.js

 'use strict';
 
-var concat = require('concat-stream');
+var Writable = require('readable-stream').Writable;
+var inherits = require('util').inherits;
 
+function BufferStream() {
+	Writable.call(this, { objectMode: true });
+	this.buffer = [];
+	this.length = 0;
+}
+
+inherits(BufferStream, Writable);
+BufferStream.prototype._write = function(chunk, enc, next) {
+	if (!Buffer.isBuffer(chunk)) {
+		chunk = new Buffer(chunk);
+	}
+
+	this.buffer.push(chunk);
+	this.length += chunk.length;
+	next();
+};
+
 module.exports = function read(stream, options, cb) {
@@ -25,11 +43,17 @@ if (!stream) {
 
-	stream
-		.once('error', cb)
-		.pipe(concat({encoding: 'buffer'}, function (data) {
-			if (options.encoding) {
-				data = data.toString(options.encoding);
-			}
+	var sink = new BufferStream();
 
-			cb(null, data);
-		}));
+	sink.on('finish', function () {
+		var data = Buffer.concat(this.buffer, this.length);
+
+		if (options.encoding) {
+			data = data.toString(options.encoding);
+		}
+
+		cb(null, data);
+	});
+
+	stream.once('error', cb);
+
+	stream.pipe(sink);
 };

package.json

 {
   "name": "read-all-stream",
-  "version": "2.1.1",
+  "version": "2.1.2",
   "description": "Read all stream content and pass it to callback",
@@ -15,4 +15,3 @@ "license": "MIT",
   "scripts": {
-    "test": "mocha",
-    "coverage": "istanbul cover _mocha -- -R spec"
+    "test": "mocha"
   },
@@ -29,9 +28,7 @@ "files": [
   "devDependencies": {
-    "fast-apply": "0.0.3",
-    "istanbul": "^0.3.2",
     "mocha": "*"
   },
   "dependencies": {
-    "concat-stream": "^1.4.8"
+    "readable-stream": "~1.1.13"
   }
 }

No alert changes

Improved metrics

Total package byte prevSize

2897

14.69%

Dev dependency count

1

-66.67%

Lines of code

43

65.38%

Dependency changes

• + Added

  readable-stream@~1.1.13

• + Added

  isarray@0.0.1
  (transitive)

• + Added

  readable-stream@1.1.14
  (transitive)

• + Added

  string_decoder@0.10.31
  (transitive)

• - Removed

  concat-stream@^1.4.8

• - Removed

  buffer-from@1.1.2
  (transitive)

• - Removed

  concat-stream@1.6.2
  (transitive)

• - Removed

  isarray@1.0.0
  (transitive)

• - Removed

  process-nextick-args@2.0.1
  (transitive)

• - Removed

  readable-stream@2.3.8
  (transitive)

• - Removed

  safe-buffer@5.1.2
  (transitive)

• - Removed

  string_decoder@1.1.1
  (transitive)

• - Removed

  typedarray@0.0.6
  (transitive)

• - Removed

  util-deprecate@1.0.2
  (transitive)