redis-semaphore - npm Package Compare versions

Comparing version 0.3.3 to 1.0.0

lib/fair-semaphore/index.js

@@ -6,3 +6,2 @@ const TimeoutError = require('../errors/TimeoutError')
 const uuid4 = require('uuid/v4')
-require('../utils/promisifyRedis')
 
@@ -9,0 +8,0 @@ function getKey(key) {

lib/mutex/acquire.js

@@ -15,9 +15,3 @@ const debug = require('debug')('redis-semaphore:mutex:acquire')
     debug(key, identifier, 'attempt')
-    const result = await client.setAsync(
-      key,
-      identifier,
-      'NX',
-      'PX',
-      lockTimeout
-    )
+    const result = await client.set(key, identifier, 'NX', 'PX', lockTimeout)
     debug('result', typeof result, result)
@@ -24,0 +18,0 @@ if (result === 'OK') {

lib/mutex/index.js

@@ -6,3 +6,2 @@ const TimeoutError = require('../errors/TimeoutError')
 const uuid4 = require('uuid/v4')
-require('../utils/promisifyRedis')
 
@@ -9,0 +8,0 @@ function getKey(key) {

lib/RedisMutex.js

@@ -1,2 +0,2 @@
-const RedisClient = require('redis').RedisClient
+const Redis = require('ioredis')
 const LostLockError = require('./errors/LostLockError')
@@ -28,4 +28,4 @@ const debug = require('debug')('redis-semaphore:mutex:instance')
     }
-    if (!(client instanceof RedisClient)) {
-      throw new Error('"client" must be instance of RedisClient')
+    if (!(client instanceof Redis)) {
+      throw new Error('"client" must be instance of ioredis client')
     }
@@ -32,0 +32,0 @@ if (!key) {

lib/semaphore/index.js

@@ -6,3 +6,2 @@ const TimeoutError = require('../errors/TimeoutError')
 const uuid4 = require('uuid/v4')
-require('../utils/promisifyRedis')
 
@@ -9,0 +8,0 @@ function getKey(key) {

lib/semaphore/release.js

@@ -5,3 +5,3 @@ const debug = require('debug')('redis-semaphore:semaphore:release')
   debug(key, identifier)
-  const result = await client.zremAsync(key, identifier)
+  const result = await client.zrem(key, identifier)
   debug('result', typeof result, result)
@@ -8,0 +8,0 @@ return result === 1

lib/utils/createEval.js

@@ -12,3 +12,3 @@ const debug = require('debug')('redis-semaphore:eval')
 function isNoScriptError(err) {
-  return err.command === 'EVALSHA' && err.code === 'NOSCRIPT'
+  return err.command.name === 'evalsha' && err.message.startsWith('NOSCRIPT')
 }
@@ -25,3 +25,3 @@
     try {
-      return await client.evalshaAsync(evalSHAArgs)
+      return await client.evalsha(evalSHAArgs)
     } catch (err) {
@@ -31,3 +31,3 @@ if (isNoScriptError(err)) {
         debug(sha1, 'fallback to eval, args:', evalArgs)
-        return await client.evalAsync(evalArgs)
+        return await client.eval(evalArgs)
       } else {
@@ -34,0 +34,0 @@ throw err

package.json

 {
   "name": "redis-semaphore",
-  "version": "0.3.3",
+  "version": "1.0.0",
   "description": "Distributed mutex and semaphore based on Redis",
@@ -26,2 +26,3 @@ "main": "index.js",
     "benchmark": "^2.1.4",
+    "bluebird": "^3.5.2",
     "chai": "4.1.2",
@@ -32,5 +33,5 @@ "chai-as-promised": "7.1.1",
     "eslint-plugin-node": "7.0.1",
+    "ioredis": "^4.1.0",
     "istanbul": "0.4.5",
     "mocha": "5.2.0",
-    "redis": "^2.8.0",
     "sinon": "6.1.5",
@@ -44,6 +45,5 @@ "sinon-chai": "3.2.0",
   "peerDependencies": {
-    "redis": "^2.8.0"
+    "ioredis": "^4.1.0"
   },
   "dependencies": {
-    "bluebird": "^3.5.1",
     "debug": "^3.1.0",
@@ -50,0 +50,0 @@ "uuid": "^3.3.2"

Fixed alerts

No v1

Quality

Package is not semver >=1. This means it is not stable and does not support ^ ranges.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

143515

27%

Dependency count

3

-25%

Number of low quality alerts

1

-50%

Worsened metrics

Dev dependency count

14

7.69%

Number of package files

31

-3.12%

Lines of code

683

-2.15%

Dependency changes

• + Added

  @ioredis/commands@1.2.0
  (transitive)

• + Added

  cluster-key-slot@1.1.2
  (transitive)

• + Added

  debug@4.4.1
  (transitive)

• + Added

  denque@1.5.1
  (transitive)

• + Added

  ioredis@4.30.0
  (transitive)

• + Added

  lodash.defaults@4.2.0
  (transitive)

• + Added

  lodash.flatten@4.4.0
  (transitive)

• + Added

  lodash.isarguments@3.1.0
  (transitive)

• + Added

  p-map@2.1.0
  (transitive)

• + Added

  redis-errors@1.2.0
  (transitive)

• + Added

  redis-parser@3.0.0
  (transitive)

• + Added

  standard-as-callback@2.1.0
  (transitive)

• - Removed

  bluebird@^3.5.1

• - Removed

  bluebird@3.7.2
  (transitive)

• - Removed

  double-ended-queue@2.1.0-0
  (transitive)

• - Removed

  redis@2.8.0
  (transitive)

• - Removed

  redis-commands@1.7.0
  (transitive)

• - Removed

  redis-parser@2.6.0
  (transitive)