ref-napi - npm Package Compare versions

Comparing version 3.0.1 to 3.0.2

lib/ref.js

@@ -749,4 +749,8 @@ 'use strict';
   debug('writing pointer to buffer', buf, offset, ptr);
-  exports._writePointer(buf, offset, ptr);
-  exports._attach(buf, ptr);
+  // Passing true as a fourth parameter does an a stronger
+  // version of attach which ensures ptr is only collected after
+  // the finalizer for buf has run. See
+  // https://github.com/node-ffi-napi/ref-napi/issues/54
+  // for why this is necessary
+  exports._writePointer(buf, offset, ptr, true);
 };
@@ -753,0 +757,0 @@

package.json

@@ -5,3 +5,3 @@ {
   "engines": {
-    "node": ">= 6.0"
+    "node": ">= 10.0"
   },
@@ -25,3 +25,3 @@ "keywords": [
   ],
-  "version": "3.0.1",
+  "version": "3.0.2",
   "license": "MIT",
@@ -28,0 +28,0 @@ "author": "Anna Henningsen <[e-mail]>",

test/pointer.js

@@ -46,8 +46,10 @@ 'use strict';
     setImmediate(() => {
-      assert(parent_gc, '"parent" has not been garbage collected');
-      gc();
       setImmediate(() => {
+        assert(parent_gc, '"parent" has not been garbage collected');
+        gc();
         setImmediate(() => {
-          assert(child_gc, '"child" has not been garbage collected');
-          done();
+          setImmediate(() => {
+            assert(child_gc, '"child" has not been garbage collected');
+            done();
+          });
         });
@@ -54,0 +56,0 @@ });

test/reinterpret.js

@@ -55,6 +55,8 @@ 'use strict';
     setImmediate(() => {
-      assert(otherGCd, '"other" has not been garbage collected');
-      assert(origGCd, '"buf" has not been garbage collected');
+      setImmediate(() => {
+        assert(otherGCd, '"other" has not been garbage collected');
+        assert(origGCd, '"buf" has not been garbage collected');
+      });
     });
   });
 });

No alert changes

Improved metrics

Total package byte prevSize

2410755

0.19%

Lines of code

3325

0.24%

No dependency changes