rmc-dialog - npm Package Compare versions

Comparing version 1.0.5 to 1.0.6

es/DialogWrap.d.ts

@@ -11,2 +11,3 @@ /// <reference types="react" />
     _component: any;
+    container: any;
     componentDidMount(): void;
@@ -21,5 +22,5 @@ shouldComponentUpdate({visible}: {
     removeContainer: () => void;
-    getContainer: () => Element;
+    getContainer: () => any;
     renderDialog(visible: any): void;
     render(): any;
 }

es/DialogWrap.js

@@ -35,19 +35,19 @@ import _extends from 'babel-runtime/helpers/extends';
         _this.removeContainer = function () {
-            var container = document.querySelector('#' + _this.props.prefixCls + '-container');
-            if (container) {
+            if (_this.container) {
                 if (!IS_REACT_16) {
-                    ReactDOM.unmountComponentAtNode(container);
+                    ReactDOM.unmountComponentAtNode(_this.container);
                 }
-                container.parentNode.removeChild(container);
+                _this.container.parentNode.removeChild(_this.container);
+                _this.container = null;
             }
         };
         _this.getContainer = function () {
-            var prefixCls = _this.props.prefixCls;
-            var container = document.querySelector('#' + prefixCls + '-container');
-            if (!container) {
-                container = document.createElement('div');
-                container.setAttribute('id', prefixCls + '-container');
+            if (!_this.container) {
+                var container = document.createElement('div');
+                var containerId = _this.props.prefixCls + '-container-' + new Date().getTime();
+                container.setAttribute('id', containerId);
                 document.body.appendChild(container);
+                _this.container = container;
             }
-            return container;
+            return _this.container;
         };
@@ -54,0 +54,0 @@ return _this;

lib/DialogWrap.d.ts

@@ -11,2 +11,3 @@ /// <reference types="react" />
     _component: any;
+    container: any;
     componentDidMount(): void;
@@ -21,5 +22,5 @@ shouldComponentUpdate({visible}: {
     removeContainer: () => void;
-    getContainer: () => Element;
+    getContainer: () => any;
     renderDialog(visible: any): void;
     render(): any;
 }

lib/DialogWrap.js

@@ -67,19 +67,19 @@ 'use strict';
         _this.removeContainer = function () {
-            var container = document.querySelector('#' + _this.props.prefixCls + '-container');
-            if (container) {
+            if (_this.container) {
                 if (!IS_REACT_16) {
-                    _reactDom2['default'].unmountComponentAtNode(container);
+                    _reactDom2['default'].unmountComponentAtNode(_this.container);
                 }
-                container.parentNode.removeChild(container);
+                _this.container.parentNode.removeChild(_this.container);
+                _this.container = null;
             }
         };
         _this.getContainer = function () {
-            var prefixCls = _this.props.prefixCls;
-            var container = document.querySelector('#' + prefixCls + '-container');
-            if (!container) {
-                container = document.createElement('div');
-                container.setAttribute('id', prefixCls + '-container');
+            if (!_this.container) {
+                var container = document.createElement('div');
+                var containerId = _this.props.prefixCls + '-container-' + new Date().getTime();
+                container.setAttribute('id', containerId);
                 document.body.appendChild(container);
+                _this.container = container;
             }
-            return container;
+            return _this.container;
         };
@@ -86,0 +86,0 @@ return _this;

package.json

 {
   "name": "rmc-dialog",
-  "version": "1.0.5",
+  "version": "1.0.6",
   "description": "mobile dialog ui component for react",
@@ -5,0 +5,0 @@ "keywords": [

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Lines of code

1553

increased by0.13%

Worsened metrics

Total package byte prevSize

67821

decreased by-0.02%

No dependency changes