rollup-plugin-node-resolve - npm Package Compare versions

Comparing version 5.1.0 to 5.1.1

CHANGELOG.md

 # rollup-plugin-node-resolve changelog
 
+## 5.1.1 (2019-06-29)
+
+* Move Rollup version check to buildStart hook to avoid issues ([#232](https://github.com/rollup/rollup-plugin-node-resolve/pull/232) by @lukastaegert)
+
 ## 5.1.0 (2019-06-22)
@@ -4,0 +8,0 @@

dist/rollup-plugin-node-resolve.cjs.js

@@ -60,4 +60,8 @@ 'use strict';
 
+const existsAsync = file => new Promise(fulfil => fs.exists(file, fulfil));
+
 const readFileAsync = file => new Promise((fulfil, reject) => fs.readFile(file, (err, contents) => err ? reject(err) : fulfil(contents)));
 
+const realpathAsync = file => new Promise((fulfil, reject) => fs.realpath(file, (err, contents) => err ? reject(err) : fulfil(contents)));
+
 const statAsync = file => new Promise((fulfil, reject) => fs.stat(file, (err, contents) => err ? reject(err) : fulfil(contents)));
@@ -241,3 +245,3 @@
 
-    options(options) {
+    buildStart(options) {
       preserveSymlinks = options.preserveSymlinks;
@@ -377,7 +381,9 @@
 
+        if (hasPackageEntry && !preserveSymlinks && resolved) {
+          return existsAsync(resolved).then(exists => exists ? realpathAsync(resolved) : resolved);
+        }
+
+        return resolved;
+      }).then(resolved => {
         if (hasPackageEntry) {
-          if (!preserveSymlinks && resolved && fs.existsSync(resolved)) {
-            resolved = fs.realpathSync(resolved);
-          }
-
           if (builtins.has(resolved) && preferBuiltins && isPreferBuiltinsSet) {
@@ -384,0 +390,0 @@ return null;

dist/rollup-plugin-node-resolve.es.js

@@ -56,4 +56,8 @@ import { dirname, join, resolve, normalize, sep, extname } from 'path';
 
+const existsAsync = file => new Promise(fulfil => fs.exists(file, fulfil));
+
 const readFileAsync = file => new Promise((fulfil, reject) => fs.readFile(file, (err, contents) => err ? reject(err) : fulfil(contents)));
 
+const realpathAsync = file => new Promise((fulfil, reject) => fs.realpath(file, (err, contents) => err ? reject(err) : fulfil(contents)));
+
 const statAsync = file => new Promise((fulfil, reject) => fs.stat(file, (err, contents) => err ? reject(err) : fulfil(contents)));
@@ -237,3 +241,3 @@
 
-    options(options) {
+    buildStart(options) {
       preserveSymlinks = options.preserveSymlinks;
@@ -373,7 +377,9 @@
 
+        if (hasPackageEntry && !preserveSymlinks && resolved) {
+          return existsAsync(resolved).then(exists => exists ? realpathAsync(resolved) : resolved);
+        }
+
+        return resolved;
+      }).then(resolved => {
         if (hasPackageEntry) {
-          if (!preserveSymlinks && resolved && fs.existsSync(resolved)) {
-            resolved = fs.realpathSync(resolved);
-          }
-
           if (builtins.has(resolved) && preferBuiltins && isPreferBuiltinsSet) {
@@ -380,0 +386,0 @@ return null;

package.json

 {
   "name": "rollup-plugin-node-resolve",
   "description": "Bundle third-party dependencies in node_modules",
-  "version": "5.1.0",
+  "version": "5.1.1",
   "devDependencies": {
@@ -6,0 +6,0 @@ "@babel/core": "^7.4.5",

src/index.js

@@ -16,4 +16,8 @@ import {dirname, extname, join, normalize, resolve, sep} from 'path';
 
+const existsAsync = file => new Promise(fulfil => fs.exists(file, fulfil));
+
 const readFileAsync = file => new Promise((fulfil, reject) => fs.readFile(file, (err, contents) => err ? reject(err) : fulfil(contents)));
 
+const realpathAsync = file => new Promise((fulfil, reject) => fs.realpath(file, (err, contents) => err ? reject(err) : fulfil(contents)));
+
 const statAsync = file => new Promise((fulfil, reject) => fs.stat(file, (err, contents) => err ? reject(err) : fulfil(contents)));
@@ -187,3 +191,3 @@
 
-		options ( options ) {
+		buildStart ( options ) {
 			preserveSymlinks = options.preserveSymlinks;
@@ -311,7 +315,10 @@ const [major, minor] = this.meta.rollupVersion.split('.').map(Number);
 
+					if ( hasPackageEntry && !preserveSymlinks && resolved ) {
+						return existsAsync( resolved )
+							.then(exists => exists ? realpathAsync( resolved ) : resolved);
+					}
+					return resolved;
+				})
+				.then(resolved => {
 					if ( hasPackageEntry ) {
-						if ( !preserveSymlinks && resolved && fs.existsSync( resolved ) ) {
-							resolved = fs.realpathSync( resolved );
-						}
-
 						if (builtins.has(resolved) && preferBuiltins && isPreferBuiltinsSet) {
@@ -318,0 +325,0 @@ return null;

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

55510

increased by2.06%

Lines of code

1053

increased by1.35%

No dependency changes