rsmq - npm Package Compare versions

Comparing version 0.8.0 to 0.8.1

CHANGELOG.md

 # CHANGELOG for rsmq
 
+## 0.8.1
+
+* Make sure `setQueueAttributes` does refresh `modified` field. Fix for #47. Thanks @igr
+
 ## 0.8.0
@@ -4,0 +8,0 @@

index.js

@@ -475,3 +475,3 @@ // Generated by CoffeeScript 1.11.1
           }
-          mc = [["hsetnx", "" + _this.redisns + options.qname + ":Q", "modified", resp[0]]];
+          mc = [["hset", "" + _this.redisns + options.qname + ":Q", "modified", resp[0]]];
           for (l = 0, len2 = k.length; l < len2; l++) {
@@ -478,0 +478,0 @@ item = k[l];

package.json

 {
     "name": "rsmq",
     "description": "A really simple message queue based on Redis",
-    "version": "0.8.0",
+    "version": "0.8.1",
     "license": "MIT",
@@ -6,0 +6,0 @@ "author": "P. Liess <[e-mail]>",

test/test.js

@@ -20,4 +20,8 @@ // Generated by CoffeeScript 1.11.1
   rsmq2 = null;
-  queue1 = "test1";
-  queue2 = "test2";
+  queue1 = {
+    name: "test1"
+  };
+  queue2 = {
+    name: "test2"
+  };
   q1m1 = null;
@@ -73,3 +77,3 @@ q1m2 = null;
       rsmq.createQueue({
-        qname: queue1,
+        qname: queue1.name,
         vt: -20
@@ -83,3 +87,3 @@ }, function(err, resp) {
       rsmq.createQueue({
-        qname: queue1,
+        qname: queue1.name,
         vt: "not_a_number"
@@ -93,3 +97,3 @@ }, function(err, resp) {
       rsmq.createQueue({
-        qname: queue1,
+        qname: queue1.name,
         vt: 10000000
@@ -103,3 +107,3 @@ }, function(err, resp) {
       rsmq.createQueue({
-        qname: queue1,
+        qname: queue1.name,
         delay: -20
@@ -113,3 +117,3 @@ }, function(err, resp) {
       rsmq.createQueue({
-        qname: queue1,
+        qname: queue1.name,
         delay: "not_a_number"
@@ -123,3 +127,3 @@ }, function(err, resp) {
       rsmq.createQueue({
-        qname: queue1,
+        qname: queue1.name,
         delay: 10000000
@@ -133,3 +137,3 @@ }, function(err, resp) {
       rsmq.createQueue({
-        qname: queue1,
+        qname: queue1.name,
         maxsize: -20
@@ -143,3 +147,3 @@ }, function(err, resp) {
       rsmq.createQueue({
-        qname: queue1,
+        qname: queue1.name,
         maxsize: "not_a_number"
@@ -153,3 +157,3 @@ }, function(err, resp) {
       rsmq.createQueue({
-        qname: queue1,
+        qname: queue1.name,
         maxsize: 66000
@@ -163,3 +167,3 @@ }, function(err, resp) {
       rsmq.createQueue({
-        qname: queue1,
+        qname: queue1.name,
         maxsize: 900
@@ -173,3 +177,3 @@ }, function(err, resp) {
       rsmq.createQueue({
-        qname: queue1,
+        qname: queue1.name,
         maxsize: -2
@@ -190,3 +194,3 @@ }, function(err, resp) {
       rsmq.createQueue({
-        qname: queue1
+        qname: queue1.name
       }, function(err, resp) {
@@ -200,3 +204,3 @@ should.not.exist(err);
       rsmq.createQueue({
-        qname: queue1
+        qname: queue1.name
       }, function(err, resp) {
@@ -211,3 +215,3 @@ err.message.should.equal("Queue exists");
         resp.length.should.equal(1);
-        resp.should.containEql(queue1);
+        resp.should.containEql(queue1.name);
         done();
@@ -218,3 +222,3 @@ });
       rsmq.createQueue({
-        qname: queue2,
+        qname: queue2.name,
         maxsize: 2048
@@ -231,7 +235,17 @@ }, function(err, resp) {
         resp.length.should.equal(2);
-        resp.should.containEql(queue1);
-        resp.should.containEql(queue2);
+        resp.should.containEql(queue1.name);
+        resp.should.containEql(queue2.name);
         done();
       });
     });
+    it('Should succeed: GetQueueAttributes of queue 1', function(done) {
+      rsmq.getQueueAttributes({
+        qname: queue1.name
+      }, function(err, resp) {
+        should.not.exist(err);
+        resp.msgs.should.equal(0);
+        queue1.modified = resp.modified;
+        done();
+      });
+    });
     it('Should fail: GetQueueAttributes of bogus queue', function(done) {
@@ -264,3 +278,3 @@ rsmq.getQueueAttributes({
       rsmq.setQueueAttributes({
-        qname: queue1,
+        qname: queue1.name,
         vt: 1234
@@ -275,15 +289,19 @@ }, function(err, resp) {
     it('setQueueAttributes: Should return the queue with a new delay attribute', function(done) {
-      rsmq.setQueueAttributes({
-        qname: queue1,
-        delay: 7
-      }, function(err, resp) {
-        resp.vt.should.equal(1234);
-        resp.delay.should.equal(7);
-        resp.maxsize.should.equal(65536);
-        done();
-      });
+      this.timeout(2000);
+      setTimeout(function() {
+        rsmq.setQueueAttributes({
+          qname: queue1.name,
+          delay: 7
+        }, function(err, resp) {
+          resp.vt.should.equal(1234);
+          resp.delay.should.equal(7);
+          resp.maxsize.should.equal(65536);
+          resp.modified.should.be.above(queue1.modified);
+          done();
+        });
+      }, 1100);
     });
     it('setQueueAttributes: Should return the queue with an umlimited maxsize', function(done) {
       rsmq.setQueueAttributes({
-        qname: queue1,
+        qname: queue1.name,
         maxsize: -1
@@ -299,3 +317,3 @@ }, function(err, resp) {
       rsmq.setQueueAttributes({
-        qname: queue1,
+        qname: queue1.name,
         maxsize: 2048
@@ -311,3 +329,3 @@ }, function(err, resp) {
       rsmq.setQueueAttributes({
-        qname: queue1,
+        qname: queue1.name,
         maxsize: 65536,
@@ -325,3 +343,3 @@ vt: 30,
       rsmq.setQueueAttributes({
-        qname: queue1,
+        qname: queue1.name,
         maxsize: 50
@@ -335,3 +353,3 @@ }, function(err, resp) {
       rsmq.setQueueAttributes({
-        qname: queue1,
+        qname: queue1.name,
         vt: -5
@@ -362,3 +380,3 @@ }, function(err, resp) {
       rsmq.sendMessage({
-        qname: queue1,
+        qname: queue1.name,
         messXage: "Hello"
@@ -372,3 +390,3 @@ }, function(err, resp) {
       rsmq.sendMessage({
-        qname: queue1,
+        qname: queue1.name,
         message: 123
@@ -382,3 +400,3 @@ }, function(err, resp) {
       rsmq2.sendMessage({
-        qname: queue1,
+        qname: queue1.name,
         message: "Hello"
@@ -399,3 +417,3 @@ }, function(err, resp) {
         pq.push({
-          qname: queue2,
+          qname: queue2.name,
           message: "test message number:" + i
@@ -417,3 +435,3 @@ });
       rsmq.sendMessage({
-        qname: queue1,
+        qname: queue1.name,
         message: "World"
@@ -431,3 +449,3 @@ }, function(err, resp) {
       rsmq2.receiveMessage({
-        qname: queue1
+        qname: queue1.name
       }, function(err, resp) {
@@ -440,3 +458,3 @@ resp.id.should.equal(q1m1.id);
       rsmq.receiveMessage({
-        qname: queue1
+        qname: queue1.name
       }, function(err, resp) {
@@ -449,3 +467,3 @@ resp.id.should.equal(q1m2.id);
       rsmq.getQueueAttributes({
-        qname: queue1
+        qname: queue1.name
       }, function(err, resp) {
@@ -459,3 +477,3 @@ resp.msgs.should.equal(2);
       rsmq.sendMessage({
-        qname: queue1,
+        qname: queue1.name,
         message: "Booo!!"
@@ -473,3 +491,3 @@ }, function(err, resp) {
       rsmq.getQueueAttributes({
-        qname: queue1
+        qname: queue1.name
       }, function(err, resp) {
@@ -483,3 +501,3 @@ resp.msgs.should.equal(3);
       rsmq.popMessage({
-        qname: queue1
+        qname: queue1.name
       }, function(err, resp) {
@@ -492,3 +510,3 @@ resp.id.should.equal(q1m3.id);
       rsmq.getQueueAttributes({
-        qname: queue1
+        qname: queue1.name
       }, function(err, resp) {
@@ -502,3 +520,3 @@ resp.msgs.should.equal(2);
       rsmq.popMessage({
-        qname: queue1
+        qname: queue1.name
       }, function(err, resp) {
@@ -511,3 +529,3 @@ should.not.exist(resp.id);
       rsmq.changeMessageVisibility({
-        qname: queue1,
+        qname: queue1.name,
         id: "abcdefghij0123456789abcdefghij01",
@@ -522,3 +540,3 @@ vt: 10
       rsmq.changeMessageVisibility({
-        qname: queue1,
+        qname: queue1.name,
         id: q1m2.id,
@@ -533,3 +551,3 @@ vt: 10
       rsmq.receiveMessage({
-        qname: queue1
+        qname: queue1.name
       }, function(err, resp) {
@@ -542,3 +560,3 @@ should.not.exist(resp.id);
       rsmq.changeMessageVisibility({
-        qname: queue1,
+        qname: queue1.name,
         id: q1m2.id,
@@ -553,3 +571,3 @@ vt: 0
       rsmq.receiveMessage({
-        qname: queue1
+        qname: queue1.name
       }, function(err, resp) {
@@ -562,3 +580,3 @@ resp.id.should.equal(q1m2.id);
       rsmq.receiveMessage({
-        qname: queue1
+        qname: queue1.name
       }, function(err, resp) {
@@ -571,3 +589,3 @@ should.not.exist(resp.id);
       rsmq.deleteMessage({
-        qname: queue1
+        qname: queue1.name
       }, function(err, resp) {
@@ -580,3 +598,3 @@ err.message.should.equal("No id supplied");
       rsmq.deleteMessage({
-        qname: queue1,
+        qname: queue1.name,
         id: "sdafsdf"
@@ -590,3 +608,3 @@ }, function(err, resp) {
       rsmq.deleteMessage({
-        qname: queue1,
+        qname: queue1.name,
         id: q1m1.id
@@ -600,3 +618,3 @@ }, function(err, resp) {
       rsmq.deleteMessage({
-        qname: queue1,
+        qname: queue1.name,
         id: q1m1.id
@@ -610,3 +628,3 @@ }, function(err, resp) {
       rsmq.changeMessageVisibility({
-        qname: queue1,
+        qname: queue1.name,
         id: q1m1.id,
@@ -627,3 +645,3 @@ vt: 10
       rsmq.sendMessage({
-        qname: queue1,
+        qname: queue1.name,
         message: text
@@ -641,3 +659,3 @@ }, function(err, resp) {
         pq.push({
-          qname: queue2,
+          qname: queue2.name,
           vt: 0
@@ -655,3 +673,3 @@ });
           dq.push({
-            qname: queue2,
+            qname: queue2.name,
             id: e.id
@@ -673,3 +691,3 @@ });
       rsmq.getQueueAttributes({
-        qname: queue2
+        qname: queue2.name
       }, function(err, resp) {
@@ -686,3 +704,3 @@ should.not.exist(err);
         pq.push({
-          qname: queue2,
+          qname: queue2.name,
           vt: 0
@@ -700,3 +718,3 @@ });
           dq.push({
-            qname: queue2,
+            qname: queue2.name,
             id: e.id
@@ -719,3 +737,3 @@ });
       rsmq.receiveMessage({
-        qname: queue2
+        qname: queue2.name
       }, function(err, resp) {
@@ -728,3 +746,3 @@ should.not.exist(resp.id);
       rsmq.getQueueAttributes({
-        qname: queue2
+        qname: queue2.name
       }, function(err, resp) {
@@ -740,3 +758,3 @@ should.not.exist(err);
       rsmq.setQueueAttributes({
-        qname: queue2,
+        qname: queue2.name,
         delay: 0,
@@ -756,3 +774,3 @@ vt: 30,
       rsmq.sendMessage({
-        qname: queue2,
+        qname: queue2.name,
         message: longmsg
@@ -762,3 +780,3 @@ }, function(err, resp1) {
         rsmq.receiveMessage({
-          qname: queue2
+          qname: queue2.name
         }, function(err, resp2) {
@@ -774,5 +792,5 @@ should.not.exist(err);
   describe('CLEANUP', function() {
-    it('Remove queue1', function(done) {
+    it('Remove  queue1.name', function(done) {
       rsmq.deleteQueue({
-        qname: queue1
+        qname: queue1.name
       }, function(err, resp) {
@@ -786,3 +804,3 @@ should.not.exist(err);
       rsmq.deleteQueue({
-        qname: queue2
+        qname: queue2.name
       }, function(err, resp) {
@@ -789,0 +807,0 @@ should.not.exist(err);

No alert changes

Improved metrics

Total package byte prevSize

93908

increased by1.77%

Lines of code

1314

increased by1.39%

No dependency changes