sdk-base - npm Package Compare versions

Comparing version 1.1.0 to 2.0.0

History.md

 
+2.0.0 / 2016-03-11
+==================
+
+  * refactor: listen on error synchronous
+
 1.1.0 / 2015-11-14 
@@ -3,0 +8,0 @@ ==================

index.js

@@ -22,17 +22,5 @@ /**
 
-var defer = global.setImmediate
-  ? setImmediate
-  : process.nextTick;
-
 function Base() {
-  // defer bind default error handler
-  defer(function () {
-    if (!this.listeners('error').length) {
-      /**
-       * default error handler
-       */
-      this.on('error', this.defaultErrorHandler.bind(this));
-    }
-  }.bind(this));
   EventEmitter.call(this);
+  this.on('error', this.defaultErrorHandler.bind(this));
 }
@@ -49,2 +37,6 @@
 Base.prototype.defaultErrorHandler = function (err) {
+  if (this._events.error.length > 1) {
+    // ignore defaultErrorHandler
+    return;
+  }
   console.error('\n[%s][pid: %s][%s][%s] %s: %s \nError Stack:\n  %s',
@@ -51,0 +43,0 @@ Date(), process.pid, this.constructor.name, __filename, err.name,

package.json

 {
   "name": "sdk-base",
-  "version": "1.1.0",
+  "version": "2.0.0",
   "description": "a base class for sdk with default error handler",
@@ -5,0 +5,0 @@ "main": "index.js",

No alert changes

Worsened metrics

Total package byte prevSize

4230

decreased by-1.9%

Lines of code

47

decreased by-12.96%

No dependency changes