simple-git - npm Package Compare versions

Comparing version 1.15.0 to 1.16.0

package.json

 {
   "name": "simple-git",
   "description": "Simple GIT interface for node.js",
-  "version": "1.15.0",
+  "version": "1.16.0",
   "author": "Steve King <[e-mail]>",
@@ -6,0 +6,0 @@ "contributors": [

src/git.js

@@ -238,3 +238,3 @@ (function () {
       return this.tag(['-l'], function (err, data) {
-         then && then(err, !err && this._parseListTags(data));
+         then && then(err, !err && require('./TagList').parse(data));
       });
@@ -709,23 +709,2 @@ };
 
-   Git.prototype._parseListTags = function (tags) {
-      var tagList = tags.split('\n').sort(function (tagA, tagB) {
-         var partsA = tagA.split('.');
-         var partsB = tagB.split('.');
-
-         for (var i = 0, l = Math.max(partsA.length, partsB.length); i < l; i++) {
-            var diff = partsA[i] - partsB[i];
-            if (diff) {
-               return diff > 0 ? 1 : -1;
-            }
-         }
-
-         return 0;
-      });
-
-      return {
-         latest: tagList.length && tagList[tagList.length - 1],
-         all: tagList
-      };
-   };
-
    Git.prototype._parseStatus = function (status) {
@@ -732,0 +711,0 @@ var line;

test/testCommands.js

@@ -460,1 +460,24 @@
 };
+
+exports.tag = {
+    setUp: function (done) {
+        Instance();
+        done();
+    },
+
+    'with max count shorthand property': function (test) {
+        git.tags(function (err, result) {
+            test.equals(null, err, 'not an error');
+            test.same(["tag", "-l"], theCommandRun());
+            test.equals('1.2.1', result.latest);
+            test.same(['0.1.1', '1.1.1', '1.2.1'], result.all);
+
+            test.done();
+        });
+
+        closeWith('0.1.1\n\
+        1.2.1\n\
+        1.1.1\
+        ');
+    }
+};

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

51752

increased by1.11%

Number of package files

10

increased by11.11%

Lines of code

1230

increased by1.65%

No dependency changes