simple-git - npm Package Compare versions

Comparing version 1.26.2 to 1.27.0

package.json

 {
   "name": "simple-git",
   "description": "Simple GIT interface for node.js",
-  "version": "1.26.2",
+  "version": "1.27.0",
   "author": "Steve King <[e-mail]>",
@@ -6,0 +6,0 @@ "contributors": [

src/git.js

@@ -904,2 +904,6 @@ (function () {
 
+         spawned.on('error', function (err) {
+            stdErr.push(new Buffer(err.stack, 'ascii'));
+         });
+
          spawned.on('close', function (exitCode, exitSignal) {
@@ -906,0 +910,0 @@ delete this._childProcess;

test/testCommands.js

 
+function MockBuffer (content, type) {
+    this.type = type;
+    this.toString = function () { return content; }
+}
+
+MockBuffer.concat = function () {
+
+};
+
 function MockChild () {
@@ -23,13 +32,32 @@ mockChildProcesses.push(this);
 
-    return git = new Git(baseDir, new MockChildProcess, {concat: sinon.spy(function (things) { return [].join.call(things, '\n'); })});
+    var Buffer = MockBuffer;
+    Buffer.concat = sinon.spy(function (things) {
+        return [].join.call(things, '\n'); });
+
+    return git = new Git(baseDir, new MockChildProcess, Buffer);
 }
 
 function closeWith (data) {
-    var stdout = mockChildProcesses[mockChildProcesses.length - 1].stdout.on.args[0][1];
-    var close = mockChildProcesses[mockChildProcesses.length - 1].on.args[0][1];
+    if (typeof data === "string") {
+        mockChildProcesses[mockChildProcesses.length - 1].stdout.on.args[0][1](data);
+    }
 
-    stdout(data);
-    close(0);
+    mockChildProcesses[mockChildProcesses.length - 1].on.args.forEach(function (handler) {
+        if (handler[0] === 'close') {
+            handler[1](typeof data === "number" ? data : 0);
+        }
+    });
 }
 
+function errorWith (someMessage) {
+    var handlers = mockChildProcesses[mockChildProcesses.length - 1].on.args;
+    handlers.forEach(function (handler) {
+        if (handler[0] === 'error') {
+            handler[1]({
+                stack: someMessage
+            });
+        }
+    });
+}
+
 function theCommandRun() {
@@ -54,2 +82,20 @@ return mockChildProcess.spawn.args[0][1];
 
+exports.childProcess = {
+    setUp: function (done) {
+        Instance();
+        done()
+    },
+
+    'handles child process errors': function (test) {
+        git.init(function (err) {
+            test.equals('SOME ERROR', err);
+            test.done();
+        });
+
+        errorWith('SOME ERROR');
+        closeWith(-2);
+    }
+};
+
+
 exports.commit = {
@@ -56,0 +102,0 @@ setUp: function (done) {

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Filesystem access

Supply chain risk

Accesses the file system, and could potentially read sensitive data.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

72627

increased by1.88%

Number of package files

12

increased by9.09%

Lines of code

1715

increased by2.94%

Worsened metrics

Number of low supply chain risk alerts

3

increased by50%

No dependency changes