sinon-stub-promise - npm Package Compare versions

Comparing version 0.0.9 to 0.1.0

index.js

@@ -5,3 +5,3 @@ function buildThenable() {
       try {
-        if (this.resolved) {
+        if (this.resolved && !this.rejected) {
           var returned = onFulfill(this.resolveValue);
@@ -86,2 +86,1 @@
 }
-

package.json

 {
   "name": "sinon-stub-promise",
-  "version": "0.0.9",
+  "version": "0.1.0",
   "description": "Synchronous Promise stubbing for Sinon.JS",
@@ -5,0 +5,0 @@ "author": "Alex May <[e-mail]>",

README.md

@@ -87,1 +87,5 @@ # sinon-stub-promise
 that will grow over time as we identify any short comings of this library.
+
+## To Do
+
+* Allow for chaining with `withArgs`. Ideally we could do things like `sinon.stub().withArgs(42).resolves('value')`.

spec/index_spec.js

@@ -267,3 +267,21 @@ var sinon = require('sinon');
     });
+
+    it('does not execute additional then blocks when an error is thrown', function(done) {
+      promise.resolves();
+
+      var callCount = 0;
+      promise()
+        .then(function() {
+          throw new Error('Stop the insanity');
+        })
+        .then(function() {
+          callCount++;
+        })
+        .catch(function(error) {
+          expect(callCount).to.eql(0);
+          expect(error.message).to.eql('Stop the insanity');
+          done();
+        });
+    });
   });
 });

New alerts

New author

Supply chain risk

A new npm collaborator published a version of the package for the first time. New collaborators are usually benign additions to a project, but do indicate a change to the security surface area of a package.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

11804

increased by5.57%

Lines of code

296

increased by5.71%

Number of lines in readme file

91

increased by4.6%

Worsened metrics

Number of medium supply chain risk alerts

1

increased byInfinity%

No dependency changes