sinon - npm Package Compare versions

Comparing version 1.17.6 to 1.17.7

Changelog.txt

 
+v1.17.7 / 2016-12-31
+==================
+
+  * Fix #1026: stub watch method on object
+  * Fix invalid test for "does not walk the same property twice"
+  * Fix spying/stubbing on *etter methods
+  * restoring *etters does not invoke the getter #1124
+
 v1.17.6 / 2016-09-19
@@ -3,0 +11,0 @@ ==================

lib/sinon/spy.js

@@ -34,7 +34,11 @@ /**
             if (types) {
+                // A new descriptor is needed here because we can only wrap functions
+                // By passing the original descriptor we would end up trying to spy non-function properties
+                var descriptor = {};
                 var methodDesc = sinon.getPropertyDescriptor(object, property);
+
                 for (var i = 0; i < types.length; i++) {
-                    methodDesc[types[i]] = spy.create(methodDesc[types[i]]);
+                    descriptor[types[i]] = spy.create(methodDesc[types[i]]);
                 }
-                return sinon.wrapMethod(object, property, methodDesc);
+                return sinon.wrapMethod(object, property, descriptor);
             }
@@ -41,0 +45,0 @@

lib/sinon/util/core.js

@@ -106,3 +106,4 @@ /**
             // when using hasOwn.call on objects from other frames.
-            var owned = object.hasOwnProperty ? object.hasOwnProperty(property) : hasOwn.call(object, property);
+            var owned = (object.hasOwnProperty && object.hasOwnProperty === hasOwn) ?
+                object.hasOwnProperty(property) : hasOwn.call(object, property);
 
@@ -171,5 +172,13 @@ if (hasES5Support) {
 
+                // this only supports ES5 getter/setter, for ES3.1 and lower
+                // __lookupSetter__ / __lookupGetter__ should be integrated
+                if (hasES5Support) {
+                    var checkDesc = sinon.getPropertyDescriptor(object, property);
+                    if (checkDesc.value === method) {
+                        object[property] = wrappedMethod;
+                    }
+
                 // Use strict equality comparison to check failures then force a reset
                 // via direct assignment.
-                if (object[property] === method) {
+                } else if (object[property] === method) {
                     object[property] = wrappedMethod;
@@ -176,0 +185,0 @@ }

lib/sinon/walk.js

@@ -24,3 +24,3 @@ /**
             Object.getOwnPropertyNames(obj).forEach(function (k) {
-                if (!seen[k]) {
+                if (seen[k] !== true) {
                     seen[k] = true;
@@ -27,0 +27,0 @@ var target = typeof Object.getOwnPropertyDescriptor(obj, k).get === "function" ?

package.json

 {
   "name": "sinon",
   "description": "JavaScript test spies, stubs and mocks.",
-  "version": "1.17.6",
+  "version": "1.17.7",
   "homepage": "http://sinonjs.org/",
@@ -6,0 +6,0 @@ "author": "Christian Johansen",

pkg/sinon-ie.js

 /**
- * Sinon.JS 1.17.6, 2016/09/19
+ * Sinon.JS 1.17.7, 2016/12/31
  *
@@ -4,0 +4,0 @@ * @author Christian Johansen ([e-mail])

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

798363

increased by0.43%

Lines of code

19283

increased by0.25%

No dependency changes