smelly-cli - npm Package Compare versions

Comparing version 0.0.9 to 0.0.10

build/src/find-smells.js

@@ -64,3 +64,3 @@ "use strict";
                 const smellDetector = new smelly_detector_1.SmellDetector(fileContents, language);
-                const smells = smellDetector.findAll();
+                const smells = smellDetector.findAll().smells;
                 aggregator.push({ fileName: file, smells, language });
@@ -78,3 +78,3 @@ }
             const smellDetector = new smelly_detector_1.SmellDetector(fileContents, language);
-            const result = smellDetector.findAll();
+            const result = smellDetector.findAll().smells;
             if (result.length) {
@@ -81,0 +81,0 @@ result.forEach((e) => {

package.json

 {
   "name": "smelly-cli",
-  "version": "0.0.9",
+  "version": "0.0.10",
   "private": false,
@@ -27,2 +27,3 @@ "description": "Find out the smells in your tests, suggestions for correction and the theory behind them",
     "ts-loader": "*",
+    "vitest": "*",
     "ts-mocha": "^10.0.0",
@@ -32,9 +33,9 @@ "ts-node": "^10.9.2"
   "scripts": {
-    "compile": "rm -rf build/ && tsc && cp index.js build/",
+    "compile": "npm run clean && tsc && cp index.js build/",
     "watch": "webpack --watch",
-    "clean": "rm -rf out/ dist/ types/",
+    "clean": "rm -rf build/ out/ dist/ types/",
     "compile-tests": "npm run clean && tsc -p . --outDir out",
     "watch-tests": "tsc -p . -w --outDir out",
     "lint": "eslint . --ext ts",
-    "test": "rm -rf smelly-report.html && ts-mocha -p tsconfig.json ./**/**.test.ts",
+    "test": "rm -rf smelly-report.html && vitest --watch=false ./**/**.test.ts",
     "test:watch": "nodemon --exec 'npm run test' --watch 'src/**' --ext 'ts' --delay 5",
@@ -41,0 +42,0 @@ "test:coverage": "nyc --reporter=lcov ts-mocha -p tsconfig.json ts-node/register ./**/**.test.ts",

src/find-smells.ts

@@ -45,3 +45,3 @@ import path from 'path';
         const smellDetector = new SmellDetector(fileContents, language);
-        const smells = smellDetector.findAll();
+        const smells = smellDetector.findAll().smells;
         aggregator.push({ fileName: file, smells, language });
@@ -62,3 +62,3 @@ }
       const smellDetector = new SmellDetector(fileContents, language);
-      const result = smellDetector.findAll();
+      const result = smellDetector.findAll().smells;
 
@@ -65,0 +65,0 @@ if (result.length) {

test/cli.test.ts

@@ -0,4 +1,4 @@
+import { test, describe, expect } from 'vitest';
 import { exec } from "child_process";
 import { promisify } from "util";
-import * as assert from 'assert';
 
@@ -9,7 +9,7 @@ const execPromise = promisify(exec);
 
-  it('find no smells for a given path', async () => {
+  test('find no smells for a given path', async () => {
     const { stdout } = await execPromise(`npm run cli -- fake-data/no-smells/ javascript --report=html --report-output=$(pwd)`);
 
-    assert.equal(true, stdout.includes("Report HTML generated"));
+    expect(stdout).toContain("Report HTML generated");
   });
 });

tsconfig.json

@@ -20,3 +20,6 @@ {
 		// "noUnusedParameters": true,  /* Report errors on unused parameters. */
-	}
+	},
+	"exclude": [
+		"test",
+	]
 }

Fixed alerts

Shell access

Supply chain risk

This module accesses the system shell. Accessing the system shell increases the risk of executing arbitrary code.

Found 1 instance in 1 package

Improved metrics

Number of medium supply chain risk alerts

0

decreased by-100%

Worsened metrics

Total package byte prevSize

48816

decreased by-3.96%

Dev dependency count

15

increased by7.14%

Number of package files

22

decreased by-8.33%

Lines of code

1179

decreased by-2.64%

No dependency changes