ssh2 - npm Package Compare versions

Comparing version 0.1.1 to 0.1.2

lib/agent.js

@@ -62,22 +62,16 @@ var Socket = require('net').Socket;
       } else if (type === SIGN_RESPONSE) {
-        if (keyType === 'rsa') {
-          if (!sig) {
-            siglen <<= 8;
-            siglen += chunk[i];
-            if (++count === 4) {
-              sig = new Buffer(siglen);
-              count = 0;
-            }
-          } else {
-            sig[count] = chunk[i];
-            if (++count === siglen) {
-              sock.removeAllListeners('data');
-              return sock.destroy();
-            }
+        /*
+          byte			  SSH2_AGENT_SIGN_RESPONSE
+          string			signature_blob
+        */
+        if (!sig) {
+          siglen <<= 8;
+          siglen += chunk[i];
+          if (++count === 4) {
+            sig = new Buffer(siglen);
+            count = 0;
           }
         } else {
-          if (!sig)
-            sig = new Buffer(40);
           sig[count] = chunk[i];
-          if (++count === 40) {
+          if (++count === siglen) {
             sock.removeAllListeners('data');
@@ -84,0 +78,0 @@ return sock.destroy();

lib/Connection.js

@@ -1381,5 +1381,7 @@ var net = require('net'),
       }
-      privAlgo = signed.toString('ascii', 8, 11);
-      //privAlgoLen = 4 + privAlgo.length;
-      signature = signed.slice(15); // skip algoLen + algo + sigLen
+      privAlgo = pubKeyType;
+      if (privAlgo === 'rsa')
+        signature = signed.slice(15); // skip algoLen + algo + sigLen
+      else
+        signature = signed;
       sigLen = signature.length;
@@ -1450,4 +1452,2 @@ sendSigReq();
 
-    //privAlgoLen = 4 + this._privateKey.type.length;
-
     return sendSigReq();
@@ -1454,0 +1454,0 @@ }

package.json

 { "name": "ssh2",
-  "version": "0.1.1",
+  "version": "0.1.2",
   "author": "Brian White <[e-mail]>",
@@ -4,0 +4,0 @@ "description": "An SSH2 client module written in pure JavaScript for node.js",

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Worsened metrics

Total package byte prevSize

169587

decreased by-0.15%

Lines of code

4205

decreased by-0.12%

No dependency changes