supertest-session - npm Package Compare versions

Comparing version 0.0.6 to 0.0.7

index.js

@@ -1,3 +0,3 @@
-var _ = require('lodash'),
-    cookie = require('cookie'),
+var cookie = require('cookie'),
+    methods = require('methods'),
     request = require('supertest');
@@ -16,7 +16,9 @@
 function serializeCookie (c) {
-  return _.compact(Object.keys(c).map(function (k) {
-    if (reservedAvs.indexOf(k.toLowerCase()) === -1) {
-      return decodeURIComponent(cookie.serialize(k, c[k]));
+  return Object.keys(c).reduce(function (pairs, key) {
+    var isReserved = reservedAvs.indexOf(key.toLowerCase()) === -1;
+    if (isReserved) {
+      return pairs.concat(decodeURIComponent(cookie.serialize(key, c[key])));
     }
-  }));
+    return pairs;
+  }, []);
 }
@@ -31,3 +33,3 @@
 
-    if (config.envs && _.isObject(config.envs)) {
+    if (config.envs && (config.envs instanceof Object)) {
       Object.keys(config.envs).forEach(function(e) {
@@ -54,3 +56,3 @@ process.env[e] = config.envs[e];
 
-  Session.prototype._destroy = function () {
+  Session.prototype.destroy = function () {
     if (config.destroy) config.destroy.call(this);
@@ -61,15 +63,14 @@ this.cookies = null;
   Session.prototype.request = function (meth, route) {
-    var req = request(this.app);
-    req = req[meth](route);
+    var req = request(this.app)[meth](route);
+    var sess = this;
+    var _end = req.end.bind(req);
 
     this._before(req);
 
-    req.end = _.wrap(req.end.bind(req), function (end, callback) {
-      return end(_.wrap(callback, function (callback, err, res) {
-        if (err === null) {
-          this._after(req, res);
-        }
+    req.end = function (callback) {
+      return _end(function (err, res) {
+        if (err === null) sess._after(req, res);
         return callback(err, res);
-      }.bind(this)));
-    }.bind(this));
+      });
+    };
 
@@ -79,12 +80,16 @@ return req;
 
-  Session.prototype.destroy = function () {
-    this._destroy();
-  };
-
-  ['get', 'put', 'post', 'del', 'patch'].forEach(function (m) {
-    Session.prototype[m] = _.partial(Session.prototype.request, m);
+  methods.forEach(function (m) {
+    Session.prototype[m] = function () {
+      var args = [].slice.call(arguments);
+      return this.request.apply(this, [m].concat(args));
+    };
   });
 
-  if (_.isObject(config.helpers)) {
-    _.extend(Session.prototype, config.helpers);
+  // Back-compatibility only; will be removed in future version bump.
+  Session.prototype.del = Session.prototype.delete;
+
+  if (config.helpers instanceof Object) {
+    Object.keys(config.helpers).forEach(function (key) {
+      Session.prototype[key] = config.helpers[key];
+    });
   }
@@ -91,0 +96,0 @@

package.json

 {
   "name": "supertest-session",
-  "version": "0.0.6",
+  "version": "0.0.7",
   "description": "Cookie-based session persistence for Supertest",
   "main": "index.js",
   "scripts": {
-    "test": "./node_modules/jasmine-node/bin/jasmine-node --forceexit test",
+    "lint": "./node_modules/jshint/bin/jshint .",
+    "test": "npm run lint && ./node_modules/jasmine-node/bin/jasmine-node test",
     "cover": "./node_modules/istanbul/lib/cli.js cover ./node_modules/jasmine-node/bin/jasmine-node ./spec/ && cat ./coverage/lcov.info | ./node_modules/coveralls/bin/coveralls.js"
@@ -32,6 +33,4 @@ },
     "cookie": "^0.1.2",
-    "coveralls": "^2.11.2",
-    "jasmine-node": "^1.14.5",
-    "lodash": "~2.2.1",
-    "supertest": "^0.14.0"
+    "methods": "^1.1.0",
+    "supertest": "^0.15.0"
   },
@@ -41,6 +40,9 @@ "devDependencies": {
     "cookie-session": "^1.1.0",
+    "coveralls": "^2.11.2",
     "express": "^4.9.5",
     "istanbul": "^0.3.0",
+    "jasmine-node": "^1.14.5",
+    "jshint": "^2.5.10",
     "through": "^2.3.6"
   }
 }

README.md

@@ -7,3 +7,2 @@ # Supertest sessions
 Status](https://travis-ci.org/rjz/supertest-session.svg?branch=master)](https://travis-ci.org/rjz/supertest-session)
-
 [![Coverage
@@ -10,0 +9,0 @@ Status](https://coveralls.io/repos/rjz/supertest-session/badge.png)](https://coveralls.io/r/rjz/supertest-session)

test/main_spec.js

@@ -48,18 +48,10 @@ var tr = require('through'),
 
-  it('supports streaming', function (done) {
-    sess = new Session();
-    sess.get('/')
-      .pipe(tr(function (data) {
-        assert.equal(data.toString('utf8'), 'GET,,1');
-      }, done));
-  });
-
   describe('method sugar', function () {
     var methods = {
-          'del'   : 'DELETE',
-          'get'   : 'GET',
-          'post'  : 'POST',
-          'put'   : 'PUT',
-          'patch' : 'PATCH'
-        };
+      'del'   : 'DELETE',
+      'get'   : 'GET',
+      'post'  : 'POST',
+      'put'   : 'PUT',
+      'patch' : 'PATCH'
+    };
 
@@ -66,0 +58,0 @@ Object.keys(methods).forEach(function (key) {

No alert changes

Improved metrics

Total package byte prevSize

10440

0.93%

Dependency count

3

-40%

Number of package files

12

20%

Worsened metrics

Dev dependency count

8

60%

Lines of code

184

-1.08%

Number of lines in readme file

98

-1.01%

Dependency changes

• + Added

  methods@^1.1.0

• + Added

  debug@2.6.9
  (transitive)

• + Added

  methods@1.1.2
  (transitive)

• + Added

  superagent@0.21.0
  (transitive)

• + Added

  supertest@0.15.0
  (transitive)

• - Removed

  coveralls@^2.11.2

• - Removed

  jasmine-node@^1.14.5

• - Removed

  lodash@~2.2.1

• - Removed

  ansi-regex@2.1.1
  (transitive)

• - Removed

  ansi-styles@2.2.1
  (transitive)

• - Removed

  argparse@1.0.10
  (transitive)

• - Removed

  asn1@0.2.6
  (transitive)

• - Removed

  assert-plus@0.2.01.0.0
  (transitive)

• - Removed

  asynckit@0.4.0
  (transitive)

• - Removed

  aws-sign2@0.6.0
  (transitive)

• - Removed

  aws4@1.13.2
  (transitive)

• - Removed

  balanced-match@1.0.2
  (transitive)

• - Removed

  bcrypt-pbkdf@1.0.2
  (transitive)

• - Removed

  boom@2.10.1
  (transitive)

• - Removed

  brace-expansion@1.1.12
  (transitive)

• - Removed

  caseless@0.11.0
  (transitive)

• - Removed

  chalk@1.1.3
  (transitive)

• - Removed

  coffeescript@1.12.7
  (transitive)

• - Removed

  combined-stream@1.0.8
  (transitive)

• - Removed

  commander@2.20.3
  (transitive)

• - Removed

  concat-map@0.0.1
  (transitive)

• - Removed

  core-util-is@1.0.2
  (transitive)

• - Removed

  coveralls@2.13.3
  (transitive)

• - Removed

  cryptiles@2.0.5
  (transitive)

• - Removed

  dashdash@1.14.1
  (transitive)

• - Removed

  debug@1.0.5
  (transitive)

• - Removed

  delayed-stream@1.0.0
  (transitive)

• - Removed

  ecc-jsbn@0.1.2
  (transitive)

• - Removed

  escape-string-regexp@1.0.5
  (transitive)

• - Removed

  esprima@2.7.3
  (transitive)

• - Removed

  extend@3.0.2
  (transitive)

• - Removed

  extsprintf@1.3.0
  (transitive)

• - Removed

  forever-agent@0.6.1
  (transitive)

• - Removed

  form-data@2.1.4
  (transitive)

• - Removed

  fs.realpath@1.0.0
  (transitive)

• - Removed

  gaze@1.1.3
  (transitive)

• - Removed

  generate-function@2.3.1
  (transitive)

• - Removed

  generate-object-property@1.2.0
  (transitive)

• - Removed

  getpass@0.1.7
  (transitive)

• - Removed

  glob@7.1.7
  (transitive)

• - Removed

  globule@1.3.4
  (transitive)

• - Removed

  growl@1.7.0
  (transitive)

• - Removed

  har-validator@2.0.6
  (transitive)

• - Removed

  has-ansi@2.0.0
  (transitive)

• - Removed

  hawk@3.1.3
  (transitive)

• - Removed

  hoek@2.16.3
  (transitive)

• - Removed

  http-signature@1.1.1
  (transitive)

• - Removed

  inflight@1.0.6
  (transitive)

• - Removed

  is-my-ip-valid@1.0.1
  (transitive)

• - Removed

  is-my-json-valid@2.20.6
  (transitive)

• - Removed

  is-property@1.0.2
  (transitive)

• - Removed

  is-typedarray@1.0.0
  (transitive)

• - Removed

  isstream@0.1.2
  (transitive)

• - Removed

  jasmine-growl-reporter@0.2.1
  (transitive)

• - Removed

  jasmine-node@1.16.2
  (transitive)

• - Removed

  jasmine-reporters@1.0.2
  (transitive)

• - Removed

  js-yaml@3.6.1
  (transitive)

• - Removed

  jsbn@0.1.1
  (transitive)

• - Removed

  json-schema@0.4.0
  (transitive)

• - Removed

  json-stringify-safe@5.0.1
  (transitive)

• - Removed

  jsonpointer@5.0.1
  (transitive)

• - Removed

  jsprim@1.4.2
  (transitive)

• - Removed

  lcov-parse@0.0.10
  (transitive)

• - Removed

  lodash@2.2.14.17.21
  (transitive)

• - Removed

  log-driver@1.2.5
  (transitive)

• - Removed

  methods@1.1.0
  (transitive)

• - Removed

  mime-db@1.52.0
  (transitive)

• - Removed

  mime-types@2.1.35
  (transitive)

• - Removed

  minimatch@3.0.8
  (transitive)

• - Removed

  minimist@1.2.0
  (transitive)

• - Removed

  mkdirp@0.3.5
  (transitive)

• - Removed

  oauth-sign@0.8.2
  (transitive)

• - Removed

  once@1.4.0
  (transitive)

• - Removed

  path-is-absolute@1.0.1
  (transitive)

• - Removed

  pinkie@2.0.4
  (transitive)

• - Removed

  pinkie-promise@2.0.1
  (transitive)

• - Removed

  punycode@1.4.1
  (transitive)

• - Removed

  qs@6.3.3
  (transitive)

• - Removed

  request@2.79.0
  (transitive)

• - Removed

  requirejs@2.3.7
  (transitive)

• - Removed

  safer-buffer@2.1.2
  (transitive)

• - Removed

  sntp@1.0.9
  (transitive)

• - Removed

  sprintf-js@1.0.3
  (transitive)

• - Removed

  sshpk@1.18.0
  (transitive)

• - Removed

  stringstream@0.0.6
  (transitive)

• - Removed

  strip-ansi@3.0.1
  (transitive)

• - Removed

  superagent@0.19.0
  (transitive)

• - Removed

  supertest@0.14.0
  (transitive)

• - Removed

  supports-color@2.0.0
  (transitive)

• - Removed

  tough-cookie@2.3.4
  (transitive)

• - Removed

  tunnel-agent@0.4.3
  (transitive)

• - Removed

  tweetnacl@0.14.5
  (transitive)

• - Removed

  underscore@1.9.2
  (transitive)

• - Removed

  uuid@3.4.0
  (transitive)

• - Removed

  verror@1.10.0
  (transitive)

• - Removed

  walkdir@0.0.12
  (transitive)

• - Removed

  wrappy@1.0.2
  (transitive)

• - Removed

  xtend@4.0.2
  (transitive)

• Updated

  supertest@^0.15.0