swiper - npm Package Compare versions

Comparing version 4.0.0-beta.1 to 4.0.0-beta.2

bower.json

@@ -8,3 +8,3 @@ {
   "description": "Most modern mobile touch slider and framework with hardware accelerated transitions",
-  "version": "4.0.0-beta.1",
+  "version": "4.0.0-beta.2",
   "author": "Vladimir Kharlampidi",
@@ -11,0 +11,0 @@ "homepage": "http://www.idangero.us/swiper/",

CHANGELOG.md

 # Change Log
 
+## Swiper 4.0.0-beta.2 - Released on September 2, 2017
+  * Disable a11y by default
+  * Fixed issue with events sharing between multiple swipers
+  * Fixed issue with resize handling after destroy
+  * Few minor fixes
+
+## Swiper 4.0.0-beta.1 - Released on August 30, 2017
+  * Initial 4.0.0 release
+
 ## Swiper 3.4.2 - Released on March 10, 2017
@@ -4,0 +13,0 @@ * Fixed an issue with lazy loading callbacks when swiper is destroyed

component.json

@@ -5,3 +5,3 @@ {
   "description": "Most modern mobile touch slider and framework with hardware accelerated transitions",
-  "version": "4.0.0-beta.1",
+  "version": "4.0.0-beta.2",
   "keywords": ["swiper", "swipe", "slider", "touch", "ios", "mobile", "cordova", "phonegap", "app", "framework", "carousel", "gallery"],
@@ -8,0 +8,0 @@ "dependencies": {

package.js

@@ -1,2 +0,2 @@
-var version = '4.0.0-beta.1';
+var version = '4.0.0-beta.2';
 
@@ -3,0 +3,0 @@ Package.describe({

package.json

 {
   "name": "swiper",
-  "version": "4.0.0-beta.1",
+  "version": "4.0.0-beta.2",
   "description": "Most modern mobile touch slider and framework with hardware accelerated transitions",
@@ -71,4 +71,4 @@ "main": "dist/js/swiper.js",
   "dependencies": {
-    "dom7": "^1.7.0"
+    "dom7": "^1.7.1"
   }
 }

src/components/a11y/a11y.js

@@ -156,3 +156,3 @@ import $ from '../../utils/dom';
     a11y: {
-      enabled: true,
+      enabled: false,
       notificationClass: 'swiper-notification',
@@ -159,0 +159,0 @@ prevSlideMessage: 'Previous slide',

src/components/core/core-class.js

@@ -286,2 +286,5 @@ import window from '../../utils/window';
 
+    // Init Flag
+    swiper.initialized = false;
+
     // Detach events
@@ -317,2 +320,7 @@ swiper.detachEvents();
 
+    // Detach emitter events
+    Object.keys(swiper.eventsListeners).forEach((eventName) => {
+      swiper.off(eventName);
+    });
+
     if (deleteInstance !== false) {
@@ -319,0 +327,0 @@ swiper.$el[0].swiper = null;

src/components/core/events/index.js

@@ -11,7 +11,2 @@ import Device from '../../../utils/device';
 
-let onTouchStartBound;
-let onTouchMoveBound;
-let onTouchEndBound;
-let onClickBound;
-
 function attachEvents() {
@@ -23,8 +18,8 @@ const swiper = this;
   if (process.env.TARGET !== 'desktop') {
-    onTouchStartBound = onTouchStart.bind(swiper);
-    onTouchMoveBound = onTouchMove.bind(swiper);
-    onTouchEndBound = onTouchEnd.bind(swiper);
+    swiper.onTouchStart = onTouchStart.bind(swiper);
+    swiper.onTouchMove = onTouchMove.bind(swiper);
+    swiper.onTouchEnd = onTouchEnd.bind(swiper);
   }
 
-  onClickBound = onClick.bind(swiper);
+  swiper.onClick = onClick.bind(swiper);
 
@@ -37,16 +32,16 @@ const target = params.touchEventsTarget === 'container' ? el : wrapperEl;
     if (Browser.ie) {
-      target.addEventListener(touchEvents.start, onTouchStartBound, false);
-      (Support.touch ? target : document).addEventListener(touchEvents.move, onTouchMoveBound, capture);
-      (Support.touch ? target : document).addEventListener(touchEvents.end, onTouchEndBound, false);
+      target.addEventListener(touchEvents.start, swiper.onTouchStart, false);
+      (Support.touch ? target : document).addEventListener(touchEvents.move, swiper.onTouchMove, capture);
+      (Support.touch ? target : document).addEventListener(touchEvents.end, swiper.onTouchEnd, false);
     } else {
       if (Support.touch) {
         const passiveListener = touchEvents.start === 'onTouchStart' && Support.passiveListener && params.passiveListeners ? { passive: true, capture: false } : false;
-        target.addEventListener(touchEvents.start, onTouchStartBound, passiveListener);
-        target.addEventListener(touchEvents.move, onTouchMoveBound, capture);
-        target.addEventListener(touchEvents.end, onTouchEndBound, passiveListener);
+        target.addEventListener(touchEvents.start, swiper.onTouchStart, passiveListener);
+        target.addEventListener(touchEvents.move, swiper.onTouchMove, capture);
+        target.addEventListener(touchEvents.end, swiper.onTouchEnd, passiveListener);
       }
       if ((params.simulateTouch && !Device.ios && !Device.android) || (params.simulateTouch && !Support.touch && Device.ios)) {
-        target.addEventListener('mousedown', onTouchStartBound, false);
-        document.addEventListener('mousemove', onTouchMoveBound, capture);
-        document.addEventListener('mouseup', onTouchEndBound, false);
+        target.addEventListener('mousedown', swiper.onTouchStart, false);
+        document.addEventListener('mousemove', swiper.onTouchMove, capture);
+        document.addEventListener('mouseup', swiper.onTouchEnd, false);
       }
@@ -56,6 +51,6 @@ }
     if (params.preventClicks || params.preventClicksPropagation) {
-      target.addEventListener('click', onClickBound, true);
+      target.addEventListener('click', swiper.onClick, true);
     }
   } else {
-    target.addEventListener('click', onClickBound, false);
+    target.addEventListener('click', swiper.onClick, false);
   }
@@ -78,16 +73,16 @@
     if (Browser.ie) {
-      target.removeEventListener(touchEvents.start, onTouchStartBound, false);
-      (Support.touch ? target : document).removeEventListener(touchEvents.move, onTouchMoveBound, capture);
-      (Support.touch ? target : document).removeEventListener(touchEvents.end, onTouchEndBound, false);
+      target.removeEventListener(touchEvents.start, swiper.onTouchStart, false);
+      (Support.touch ? target : document).removeEventListener(touchEvents.move, swiper.onTouchMove, capture);
+      (Support.touch ? target : document).removeEventListener(touchEvents.end, swiper.onTouchEnd, false);
     } else {
       if (Support.touch) {
         const passiveListener = touchEvents.start === 'onTouchStart' && Support.passiveListener && params.passiveListeners ? { passive: true, capture: false } : false;
-        target.removeEventListener(touchEvents.start, onTouchStartBound, passiveListener);
-        target.removeEventListener(touchEvents.move, onTouchMoveBound, capture);
-        target.removeEventListener(touchEvents.end, onTouchEndBound, passiveListener);
+        target.removeEventListener(touchEvents.start, swiper.onTouchStart, passiveListener);
+        target.removeEventListener(touchEvents.move, swiper.onTouchMove, capture);
+        target.removeEventListener(touchEvents.end, swiper.onTouchEnd, passiveListener);
       }
       if ((params.simulateTouch && !Device.ios && !Device.android) || (params.simulateTouch && !Support.touch && Device.ios)) {
-        target.removeEventListener('mousedown', onTouchStartBound, false);
-        document.removeEventListener('mousemove', onTouchMoveBound, capture);
-        document.removeEventListener('mouseup', onTouchEndBound, false);
+        target.removeEventListener('mousedown', swiper.onTouchStart, false);
+        document.removeEventListener('mousemove', swiper.onTouchMove, capture);
+        document.removeEventListener('mouseup', swiper.onTouchEnd, false);
       }
@@ -97,6 +92,6 @@ }
     if (params.preventClicks || params.preventClicksPropagation) {
-      target.removeEventListener('click', onClickBound, true);
+      target.removeEventListener('click', swiper.onClick, true);
     }
   } else {
-    target.removeEventListener('click', onClickBound, true);
+    target.removeEventListener('click', swiper.onClick, true);
   }
@@ -103,0 +98,0 @@

src/components/lazy/lazy.js

@@ -28,3 +28,3 @@ import $ from '../../utils/dom';
       swiper.loadImage($imageEl[0], (src || background), srcset, sizes, false, () => {
-        if (typeof swiper === 'undefined' || swiper === null || !swiper) return;
+        if (typeof swiper === 'undefined' || swiper === null || !swiper || (swiper && !swiper.params)) return;
         if (background) {
@@ -31,0 +31,0 @@ $imageEl.css('background-image', `url("${background}")`);

src/modules/resize/resize.js

@@ -0,3 +1,21 @@
+import window from '../../utils/window';
+import Utils from '../../utils/utils';
+
 export default {
   name: 'resize',
+  create() {
+    const swiper = this;
+    Utils.extend(swiper, {
+      resize: {
+        resizeHandler() {
+          if (!swiper || !swiper.initialized) return;
+          swiper.emit('resize');
+        },
+        orientationChangeHandler() {
+          if (!swiper || !swiper.initialized) return;
+          swiper.emit('orientationchange');
+        },
+      },
+    });
+  },
   on: {
@@ -7,12 +25,13 @@ init() {
       // Emit resize
-      window.addEventListener('resize', () => {
-        swiper.emit('resize');
-      }, false);
+      window.addEventListener('resize', swiper.resize.resizeHandler);
 
       // Emit orientationchange
-      window.addEventListener('orientationchange', () => {
-        swiper.emit('orientationchange');
-      });
+      window.addEventListener('orientationchange', swiper.resize.orientationChangeHandler);
     },
+    destroy() {
+      const swiper = this;
+      window.removeEventListener('resize', swiper.resize.resizeHandler);
+      window.removeEventListener('orientationchange', swiper.resize.orientationChangeHandler);
+    },
   },
 };

src/utils/class.js

@@ -19,2 +19,3 @@ import Utils from './utils';
     const self = this;
+    if (typeof handler !== 'function') return self;
     events.split(' ').forEach((event) => {
@@ -28,2 +29,3 @@ if (!self.eventsListeners[event]) self.eventsListeners[event] = [];
     const self = this;
+    if (typeof handler !== 'function') return self;
     function onceHandler(...args) {
@@ -30,0 +32,0 @@ handler.apply(self, args);

src/utils/dom.js

@@ -5,7 +5,4 @@ import $ from 'dom7/src/$';
 // Methods
-Object.keys(Methods).forEach((key) => {
-  if ($.fn[key]) return;
-  $.fn[key] = Methods[key];
-});
+$.use(Methods);
 
 export default $;

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Major refactor

Supply chain risk

Package has recently undergone a major refactor. It may be unstable or indicate significant internal changes. Use caution when updating to versions that include significant changes.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

1378687

increased by0.56%

Lines of code

24550

increased by0.39%

Number of medium supply chain risk alerts

0

decreased by-100%

Dependency changes

• Updateddom7@^1.7.1