tap-listener - npm Package Compare versions

Comparing version 1.1.1 to 1.1.2

bower.json

 {
   "name": "tap-listener",
   "main": "tap-listener.js",
-  "version": "1.1.1",
+  "version": "1.1.2",
   "dependencies": {
@@ -6,0 +6,0 @@ "unipointer": "~1.1.0"

package.json

 {
   "name": "tap-listener",
-  "version": "1.1.1",
+  "version": "1.1.2",
   "description": "Listens to taps",
@@ -5,0 +5,0 @@ "main": "tap-listener.js",

tap-listener.js

 /*!
- * Tap listener v1.1.1
+ * Tap listener v1.1.2
  * listens to taps
@@ -10,5 +10,4 @@ * MIT license
 ( function( window, factory ) {
-  /*global define: false, module: false, require: false */
-  'use strict';
   // universal module definition
+  /*jshint strict: false*/ /*globals define, module, require */
 
@@ -40,11 +39,2 @@ if ( typeof define == 'function' && define.amd ) {
 
-// handle IE8 prevent default
-function preventDefaultEvent( event ) {
-  if ( event.preventDefault ) {
-    event.preventDefault();
-  } else {
-    event.returnValue = false;
-  }
-}
-
 // --------------------------  TapListener -------------------------- //
@@ -80,12 +70,2 @@
 
-var pointerDown = TapListener.prototype.pointerDown;
-
-TapListener.prototype.pointerDown = function( event ) {
-  // prevent default event for touch, disables tap then click
-  if ( event.type == 'touchstart' ) {
-    preventDefaultEvent( event );
-  }
-  pointerDown.apply( this, arguments );
-};
-
 var isPageOffset = window.pageYOffset !== undefined;
@@ -98,2 +78,7 @@ /**
 TapListener.prototype.pointerUp = function( event, pointer ) {
+  // ignore emulated mouse up clicks
+  if ( this.isIgnoringMouseUp && event.type == 'mouseup' ) {
+    return;
+  }
+
   var pointerPoint = Unipointer.getPointerPoint( pointer );
@@ -113,2 +98,11 @@ var boundingRect = this.tapElement.getBoundingClientRect();
   }
+
+  // set flag for emulated clicks 300ms after touchend
+  if ( event.type != 'mouseup' ) {
+    this.isIgnoringMouseUp = true;
+    // reset flag after 300ms
+    setTimeout( function() {
+      delete this.isIgnoringMouseUp;
+    }.bind( this ), 320 );
+  }
 };
@@ -115,0 +109,0 @@

No alert changes

Worsened metrics

Total package byte prevSize

5662

decreased by-1.97%

Lines of code

130

decreased by-3.7%

No dependency changes