timm - npm Package Compare versions

Comparing version 1.2.4 to 1.2.5

CHANGELOG.md

 # Changelog
 
+## 1.2.5 (April 2, 2017)
+
+* Improve `replaceAt` performance [#9, @gamtiq]
+
 ## 1.2.4 (March 4, 2017)
@@ -4,0 +8,0 @@

lib/timm.js

@@ -252,3 +252,10 @@ 'use strict';
   if (array[idx] === newItem) return array;
-  return array.slice(0, idx).concat([newItem]).concat(array.slice(idx + 1));
+
+  var len = array.length;
+  var result = Array(len);
+  for (var i = 0; i < len; i++) {
+    result[i] = array[i];
+  }
+  result[idx] = newItem;
+  return result;
 }
@@ -255,0 +262,0 @@

lib/timm.min.js

@@ -1,2 +0,2 @@
-"use strict";function throwStr(e){throw new Error(e)}function clone(e){if(Array.isArray(e))return e.slice();for(var r=Object.keys(e),t={},n=0;n<r.length;n++){var o=r[n];t[o]=e[o]}return t}function doMerge(e,r){var t=r;!(null!=t)&&throwStr(INVALID_ARGS);for(var n=!1,o=arguments.length,a=Array(o>2?o-2:0),s=2;o>s;s++)a[s-2]=arguments[s];for(var l=0;l<a.length;l++){var u=a[l];if(null!=u){var i=Object.keys(u);if(i.length)for(var c=0;c<=i.length;c++){var f=i[c];if(!e||void 0===t[f]){var d=u[f];void 0!==d&&d!==t[f]&&(n||(n=!0,t=clone(t)),t[f]=d)}}}}return t}function isObject(e){var r="undefined"==typeof e?"undefined":_typeof(e);return null!=e&&("object"===r||"function"===r)}function addLast(e,r){return e.concat(Array.isArray(r)?r:[r])}function addFirst(e,r){return Array.isArray(r)?r.concat(e):[r].concat(e)}function removeLast(e){return e.length?e.slice(0,e.length-1):e}function removeFirst(e){return e.length?e.slice(1):e}function insert(e,r,t){return e.slice(0,r).concat(Array.isArray(t)?t:[t]).concat(e.slice(r))}function removeAt(e,r){return r>=e.length||0>r?e:e.slice(0,r).concat(e.slice(r+1))}function replaceAt(e,r,t){return e[r]===t?e:e.slice(0,r).concat([t]).concat(e.slice(r+1))}function getIn(e,r){if(!Array.isArray(r)&&throwStr(INVALID_ARGS),null==e)return void 0;for(var t=e,n=0;n<r.length;n++){var o=r[n];if(t=null!=t?t[o]:void 0,void 0===t)return t}return t}function set(e,r,t){var n="number"==typeof r?[]:{},o=null==e?n:e;if(o[r]===t)return o;var a=clone(o);return a[r]=t,a}function doSetIn(e,r,t,n){var o=void 0,a=r[n];if(n===r.length-1)o=t;else{var s=isObject(e)?e[a]:"number"==typeof r[n+1]?[]:{};o=doSetIn(s,r,t,n+1)}return set(e,a,o)}function setIn(e,r,t){return r.length?doSetIn(e,r,t,0):t}function updateIn(e,r,t){var n=getIn(e,r),o=t(n);return setIn(e,r,o)}function merge(e,r,t,n,o,a){for(var s=arguments.length,l=Array(s>6?s-6:0),u=6;s>u;u++)l[u-6]=arguments[u];return l.length?doMerge.call.apply(doMerge,[null,!1,e,r,t,n,o,a].concat(l)):doMerge(!1,e,r,t,n,o,a)}function mergeIn(e,r,t,n,o,a,s){var l=getIn(e,r);null==l&&(l={});for(var u=void 0,i=arguments.length,c=Array(i>7?i-7:0),f=7;i>f;f++)c[f-7]=arguments[f];return u=c.length?doMerge.call.apply(doMerge,[null,!1,l,t,n,o,a,s].concat(c)):doMerge(!1,l,t,n,o,a,s),setIn(e,r,u)}function omit(e,r){for(var t=Array.isArray(r)?r:[r],n=!1,o=0;o<t.length;o++)if(hasOwnProperty.call(e,t[o])){n=!0;break}if(!n)return e;for(var a={},s=Object.keys(e),l=0;l<s.length;l++){var u=s[l];t.indexOf(u)>=0||(a[u]=e[u])}return a}function addDefaults(e,r,t,n,o,a){for(var s=arguments.length,l=Array(s>6?s-6:0),u=6;s>u;u++)l[u-6]=arguments[u];return l.length?doMerge.call.apply(doMerge,[null,!0,e,r,t,n,o,a].concat(l)):doMerge(!0,e,r,t,n,o,a)}Object.defineProperty(exports,"__esModule",{value:!0});var _typeof="function"==typeof Symbol&&"symbol"==typeof Symbol.iterator?function(e){return typeof e}:function(e){return e&&"function"==typeof Symbol&&e.constructor===Symbol&&e!==Symbol.prototype?"symbol":typeof e};exports.clone=clone,exports.addLast=addLast,exports.addFirst=addFirst,exports.removeLast=removeLast,exports.removeFirst=removeFirst,exports.insert=insert,exports.removeAt=removeAt,exports.replaceAt=replaceAt,exports.getIn=getIn,exports.set=set,exports.setIn=setIn,exports.updateIn=updateIn,exports.merge=merge,exports.mergeIn=mergeIn,exports.omit=omit,exports.addDefaults=addDefaults;/*!
+"use strict";function throwStr(e){throw new Error(e)}function clone(e){if(Array.isArray(e))return e.slice();for(var r=Object.keys(e),t={},n=0;n<r.length;n++){var o=r[n];t[o]=e[o]}return t}function doMerge(e,r){var t=r;!(null!=t)&&throwStr(INVALID_ARGS);for(var n=!1,o=arguments.length,a=Array(o>2?o-2:0),s=2;o>s;s++)a[s-2]=arguments[s];for(var u=0;u<a.length;u++){var l=a[u];if(null!=l){var i=Object.keys(l);if(i.length)for(var c=0;c<=i.length;c++){var f=i[c];if(!e||void 0===t[f]){var d=l[f];void 0!==d&&d!==t[f]&&(n||(n=!0,t=clone(t)),t[f]=d)}}}}return t}function isObject(e){var r="undefined"==typeof e?"undefined":_typeof(e);return null!=e&&("object"===r||"function"===r)}function addLast(e,r){return e.concat(Array.isArray(r)?r:[r])}function addFirst(e,r){return Array.isArray(r)?r.concat(e):[r].concat(e)}function removeLast(e){return e.length?e.slice(0,e.length-1):e}function removeFirst(e){return e.length?e.slice(1):e}function insert(e,r,t){return e.slice(0,r).concat(Array.isArray(t)?t:[t]).concat(e.slice(r))}function removeAt(e,r){return r>=e.length||0>r?e:e.slice(0,r).concat(e.slice(r+1))}function replaceAt(e,r,t){if(e[r]===t)return e;for(var n=e.length,o=Array(n),a=0;n>a;a++)o[a]=e[a];return o[r]=t,o}function getIn(e,r){if(!Array.isArray(r)&&throwStr(INVALID_ARGS),null==e)return void 0;for(var t=e,n=0;n<r.length;n++){var o=r[n];if(t=null!=t?t[o]:void 0,void 0===t)return t}return t}function set(e,r,t){var n="number"==typeof r?[]:{},o=null==e?n:e;if(o[r]===t)return o;var a=clone(o);return a[r]=t,a}function doSetIn(e,r,t,n){var o=void 0,a=r[n];if(n===r.length-1)o=t;else{var s=isObject(e)?e[a]:"number"==typeof r[n+1]?[]:{};o=doSetIn(s,r,t,n+1)}return set(e,a,o)}function setIn(e,r,t){return r.length?doSetIn(e,r,t,0):t}function updateIn(e,r,t){var n=getIn(e,r),o=t(n);return setIn(e,r,o)}function merge(e,r,t,n,o,a){for(var s=arguments.length,u=Array(s>6?s-6:0),l=6;s>l;l++)u[l-6]=arguments[l];return u.length?doMerge.call.apply(doMerge,[null,!1,e,r,t,n,o,a].concat(u)):doMerge(!1,e,r,t,n,o,a)}function mergeIn(e,r,t,n,o,a,s){var u=getIn(e,r);null==u&&(u={});for(var l=void 0,i=arguments.length,c=Array(i>7?i-7:0),f=7;i>f;f++)c[f-7]=arguments[f];return l=c.length?doMerge.call.apply(doMerge,[null,!1,u,t,n,o,a,s].concat(c)):doMerge(!1,u,t,n,o,a,s),setIn(e,r,l)}function omit(e,r){for(var t=Array.isArray(r)?r:[r],n=!1,o=0;o<t.length;o++)if(hasOwnProperty.call(e,t[o])){n=!0;break}if(!n)return e;for(var a={},s=Object.keys(e),u=0;u<s.length;u++){var l=s[u];t.indexOf(l)>=0||(a[l]=e[l])}return a}function addDefaults(e,r,t,n,o,a){for(var s=arguments.length,u=Array(s>6?s-6:0),l=6;s>l;l++)u[l-6]=arguments[l];return u.length?doMerge.call.apply(doMerge,[null,!0,e,r,t,n,o,a].concat(u)):doMerge(!0,e,r,t,n,o,a)}Object.defineProperty(exports,"__esModule",{value:!0});var _typeof="function"==typeof Symbol&&"symbol"==typeof Symbol.iterator?function(e){return typeof e}:function(e){return e&&"function"==typeof Symbol&&e.constructor===Symbol&&e!==Symbol.prototype?"symbol":typeof e};exports.clone=clone,exports.addLast=addLast,exports.addFirst=addFirst,exports.removeLast=removeLast,exports.removeFirst=removeFirst,exports.insert=insert,exports.removeAt=removeAt,exports.replaceAt=replaceAt,exports.getIn=getIn,exports.set=set,exports.setIn=setIn,exports.updateIn=updateIn,exports.merge=merge,exports.mergeIn=mergeIn,exports.omit=omit,exports.addDefaults=addDefaults;/*!
  * Timm
@@ -3,0 +3,0 @@ *

package.json

 {
   "name": "timm",
-  "version": "1.2.4",
+  "version": "1.2.5",
   "description": "Immutability helpers with fast reads and acceptable writes",
@@ -26,3 +26,3 @@ "main": "lib/timm.js",
     "eslint-plugin-react": "6.4.0",
-    "extract-docs": "1.3.0",
+    "extract-docs": "1.4.0",
     "flow-bin": "0.35.0",
@@ -34,3 +34,3 @@ "immutable": "3.8.1",
     "uglifyjs": "2.4.10",
-    "xxl": "0.1.1"
+    "xxl": "1.2.0"
   },
@@ -56,3 +56,3 @@ "scripts": {
     "travis": "npm run compile && npm run testCovNoMin",
-    "xxl": "xxl --src \"[\\\"src\\\"]\"",
+    "xxl": "xxl",
     "benchmarks": "coffee tools/benchmarks.coffee"
@@ -59,0 +59,0 @@ },

src/timm.js

@@ -230,6 +230,10 @@ // @flow
   if (array[idx] === newItem) return array;
-  return array
-    .slice(0, idx)
-    .concat([newItem])
-    .concat(array.slice(idx + 1));
+
+  const len: number = array.length;
+  const result: Array<T> = Array(len);
+  for (let i = 0; i < len; i++) {
+    result[i] = array[i];
+  }
+  result[idx] = newItem;
+  return result;
 }
@@ -236,0 +240,0 @@

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Lines of code

1092

increased by0.83%

Worsened metrics

Total package byte prevSize

208034

decreased by-5.04%

No dependency changes