tslint-lines-between-class-members - npm Package Compare versions

Comparing version 1.2.3 to 1.2.4

linesBetweenClassMembersRule.js

@@ -88,3 +88,3 @@ "use strict";
         }) - 1;
-        return sourceFile.getText().substring(lineStartPositions[startPosIdx - 1], lineStartPositions[startPosIdx] - 1);
+        return sourceFile.text.substring(lineStartPositions[startPosIdx - 1], lineStartPositions[startPosIdx] - 1);
     };
@@ -91,0 +91,0 @@ LinesBetweenClassMembersWalker.prototype.onRuleLintFail = function (node) {

package.json

 {
   "name": "tslint-lines-between-class-members",
-  "version": "1.2.3",
+  "version": "1.2.4",
   "description": "Custom rule for TSLint to enforce blank lines between class methods - achieves a similar thing to lines-between-class-members in ESLint",
@@ -5,0 +5,0 @@ "scripts": {

src/linesBetweenClassMembersRule.spec.ts

@@ -34,2 +34,7 @@ import test, {AssertContext} from 'ava';
 
+test('fails when no new line and a comment above the class', (t: AssertContext) => {
+  const results = TestHelpers.lint('fails/noLineAndCommentAboveClass.ts');
+  t.is(results.errorCount, 1);
+});
+
 test('passes when empty new line between class methods', (t: AssertContext) => {
@@ -64,1 +69,6 @@ const results = TestHelpers.lint('passes/emptyNewLine.ts');
 });
+
+test('does not fail when there is a comment above class', (t: AssertContext) => {
+  const results = TestHelpers.lint('passes/commentAboveClass.ts');
+  t.is(results.errorCount, 0);
+});

src/linesBetweenClassMembersRule.ts

@@ -83,3 +83,3 @@ import * as Lint from 'tslint';
 
-    return sourceFile.getText().substring(lineStartPositions[startPosIdx - 1], lineStartPositions[startPosIdx] - 1);
+    return sourceFile.text.substring(lineStartPositions[startPosIdx - 1], lineStartPositions[startPosIdx] - 1);
   }
@@ -86,0 +86,0 @@

No alert changes

Improved metrics

Total package byte prevSize

116725

0.45%

Number of package files

27

8%

Lines of code

496

3.55%

No dependency changes